From ecaa90c704da0ada8bd3f32b3bf4f4c5d14b75cd Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Wed, 26 Mar 2025 19:16:41 +0000 Subject: [PATCH] Simplify code in CondaPackageHelper --- tests/utils/conda_package_helper.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/utils/conda_package_helper.py b/tests/utils/conda_package_helper.py index 818749f1..631181b6 100644 --- a/tests/utils/conda_package_helper.py +++ b/tests/utils/conda_package_helper.py @@ -108,11 +108,9 @@ class CondaPackageHelper: updatable = [] for pkg, inst_vs in self.installed_packages.items(): avail_vs = self.available_packages[pkg] - if (requested_only and pkg not in self.requested_packages) or ( - not avail_vs - ): + if not avail_vs or (requested_only and pkg not in self.requested_packages): continue - newest = sorted(avail_vs, key=CondaPackageHelper.semantic_cmp)[-1] + newest = max(avail_vs, key=CondaPackageHelper.semantic_cmp) current = min(inst_vs, key=CondaPackageHelper.semantic_cmp) if CondaPackageHelper.semantic_cmp( current