hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-18 07:22:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use tty for running docker commands by default (#2260)

Browse Source 
* Use tty for running docker commands by default

* Add comment about using tty=False

* Remove unrelated part
This commit is contained in:
Ayaz Salikhov
2025-03-22 17:46:38 +00:00
committed by GitHub
parent 929ebdb758
commit f47292edc0
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/utils/tracked_container.py
View File

@@ -45,8 +45,10 @@ class TrackedContainer:
extending and/or overriding key/value pairs passed to the constructor
"""
LOGGER.info(f"Running {self.image_name} with args {kwargs} ...")
default_kwargs = {"detach": True, "tty": True}
final_kwargs = default_kwargs | kwargs
self.container = self.docker_client.containers.run(
self.image_name, **kwargs, detach=True
self.image_name, **final_kwargs
)
def get_logs(self) -> str:
@@ -64,7 +66,9 @@ class TrackedContainer:
assert self.container is not None
container = self.container
LOGGER.info(f"Running cmd: `{cmd}` on container: {container.name}")
exec_result = container.exec_run(cmd, **kwargs)
default_kwargs = {"tty": True}
final_kwargs = default_kwargs | kwargs
exec_result = container.exec_run(cmd, **final_kwargs)
output = exec_result.output.decode().rstrip()
assert isinstance(output, str)
LOGGER.info(f"Command output: {output}")