Commit Graph

116 Commits

Author SHA1 Message Date
Ayaz Salikhov
55ea74f89f Exclude mamba package from tests 2024-09-30 09:13:25 +02:00
Olivier Benz
6f74c72a92 [FAST_BUILD] No sudo when run with rootless triplet (#2132)
* No sudo when run with rootless triplet

-  rootless triplet: -e NB_USER=root -e NB_UID=0 -e NB_GID=0

* Add tests for rootless triplet

* Update tests for rootless triplet

* Fix tests for rootless triplet
2024-08-11 16:50:27 +01:00
Ayaz Salikhov
615b8cc01b Ignore mypy in files with numpy 2024-07-02 10:37:46 +01:00
pre-commit-ci[bot]
949af9bbd5 [pre-commit.ci] pre-commit autoupdate (#2090) 2024-02-06 04:43:51 +04:00
Ayaz Salikhov
7a5990be1f Do not rewrite variable with another value 2024-01-23 13:11:02 +01:00
Simon Li
6e437aa489 Make start.sh the entrypoint (#2087) 2024-01-22 08:47:48 +04:00
Ayaz Salikhov
b71f4cb525 Unify access to env variables (#2086) 2024-01-21 17:32:14 +04:00
Ayaz Salikhov
a4ede5de2f Fix Python version pin (#2085) 2024-01-21 16:06:10 +04:00
Ayaz Salikhov
46d7265781 Rename test file test_python -> test_python_version 2024-01-21 14:37:52 +04:00
Ayaz Salikhov
d57bf9590d Adjust sleep times (#2080)
* Adjust sleep times

* Update test_start_container.py

* Update test_healthcheck.py

* Update pluto_check.py
2024-01-17 02:11:44 +04:00
Ayaz Salikhov
86dc0f274f Fix comments codestyle in python 2024-01-16 16:56:36 +04:00
Ayaz Salikhov
d3e18d975c Fix some style issues in tests 2024-01-16 16:35:14 +04:00
Ayaz Salikhov
c1229303d0 Rename some tests in test_healthcheck.py 2024-01-07 00:15:38 +04:00
Hugo Hromic
2a6a115a7c [FAST_BUILD] Fix Docker healthcheck when using custom runtime dirs (#2074)
* Fix Docker healthcheck when using custom runtime dirs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Use a writable directory for healthcheck test

* Allow missing import for `jupyter_core` in mypy

* Set HOME according to NB_USER in healthcheck script

* Add custom runtime dir an NB_USER case to healthcheck test

* Call `jupyter --runtime-dir` directly in healthcheck script

* Update docker_healthcheck.py

* Update docker_healthcheck.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2024-01-07 00:13:21 +04:00
Ayaz Salikhov
3253fc39b5 Fix conda hook to work in both terminal and Jupyter Notebook (#2047)
* Fix conda hook to work in both terminal and Jupyter Notebook

* Fix hook for Jupyter Terminals

* Rename startup hook to have order of precedence

* Try to increase sleep

* Comment making env_name default in custom_environment
2023-12-04 21:09:23 +01:00
Thijs Walcarius
278dd76837 Add jupyter/pytorch-notebook (#1936)
* Add PyTorch image

* Fix linting errors

* Fix link to pytorch website

* Address review comments

* Fix PytorchVersionTagger

* Remove "+cpu" suffix from pytorch version tag

* Update selecting.md

* Rename pytorch-notebook/.dockerignore to images/pytorch-notebook/.dockerignore

* Rename pytorch-notebook/Dockerfile to images/pytorch-notebook/Dockerfile

* Rename pytorch-notebook/README.md to images/pytorch-notebook/README.md

* Add pytorch-notebook to registry-overviews

* Add registry to pytorch image

* Use Quay.io

* Remove incorrect link

* Update action.yml

* Update docker.yml

* Remove information about Docker Hub, because this image won't be uploaded to Docker Hub

* Update docker.yml

* Update action.yml

* Add pytorch-notebook to registry-move.yml

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@gmail.com>
2023-11-22 11:56:45 +01:00
Ayaz Salikhov
0a75e3d3a6 Minor improvements 2023-11-21 13:17:33 +01:00
Ayaz Salikhov
d8c60bc42c Fix more grammar issues 2023-11-19 12:16:19 +01:00
Ayaz Salikhov
e6f89ded6e Mark test_nbconvert as a flaky test 2023-11-05 10:13:52 +01:00
Ayaz Salikhov
7866050baf Improve wording in test_extensions.py 2023-11-05 00:34:24 +01:00
Ayaz Salikhov
dc5ec3d08b Move test_packages.py to docker-stacks-foundation tests 2023-11-05 00:14:34 +01:00
Ayaz Salikhov
0a0e833fcb Fix quay.io naming 2023-11-05 00:03:23 +01:00
Ayaz Salikhov
8c874a1cb4 Rename run-hooks subdir to better show the test meaning 2023-11-04 11:44:52 +01:00
Ayaz Salikhov
0ad837af8f [FAST_BUILD] Test change variable value in run-hooks (#2023) 2023-11-04 11:41:59 +01:00
Ayaz Salikhov
29e6a45dd3 Introduce run_source_in_dir to make run-hooks tests easier to write 2023-11-04 11:36:19 +01:00
Ayaz Salikhov
d52ea4716e [FAST_BUILD] Test unset in run-hooks (#2022) 2023-11-04 11:34:33 +01:00
Ayaz Salikhov
64248b85c6 Increase timeout in test_spark_notebooks 2023-10-30 12:13:12 +01:00
xieshuaihu
66f7beff16 add grpcio grpcio-status to support spark connect (#2017)
* add grpcio grpcio_status to support spark connect

* Sort install list

* Fix package name

* Update pyspark docs with new deps grpcio and grpcio-status

* set grpcio and grpcio-status version as 1.56

* exclude grpcio and grpcio-status in test_packages.py

* Update selecting.md

* Update test_packages.py

* Update Dockerfile

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-10-30 12:11:32 +01:00
Ayaz Salikhov
02e7062250 Unify <somestack> usage 2023-10-21 19:49:29 +02:00
Ayaz Salikhov
f8cd90ade1 Add an ability to specify registry when using docker images (#2008)
* Add an ability to specify registry when using docker images

* Fix typo

* [TMP] Speedup workflow

* Revert "[TMP] Speedup workflow"

This reverts commit 3af0055ccf.
2023-10-19 21:15:10 +02:00
Yuvi Panda
bceaead5d2 Migrate start-notebook & start-singleuser to python (#2006)
* Migrate start-notebook.sh to bash

Based on

> Stop using bash, haha 👍

from https://github.com/jupyter/docker-stacks/issues/1532.

If there's more apetite for this, I'll try to migrate
`start.sh` and `start-singleuser.sh` as well - I think they should
all be merged together. We can remove the `.sh` suffixes for
accuracy, and keep symlinks in so old config still works. Since
the shebang is what is used to launch the correct interpreter,
the `.sh` doesn't matter.

Will help fix https://github.com/jupyter/docker-stacks/issues/1532,
as I believe all those things are going to be easier to do from
python than bash

* Rename start-notebook.sh to start-notebook

* Cleanup start-notebook a little

* Fix typo

* Migrate start-singleuser as well

* Remove unused import

* Run symlink commands as root

* Combine repetitive RUN commands

* Remove multiple args to env

-u can not be set by shebang, we must set the env var
instead

* Fix conditional inversion

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

* Fix how start-singleuser is exec'd

* Actually call jupyterhub-singleuser in start-singleuser

* Pass through any additional args we get

* Put .py suffix on the start-* scripts

* Add .sh shims for the start-* scripts

* Document start-notebook.sh and start-singleuser.sh

* Partially test start-notebook.sh

* Reflow warning docs

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-10-17 14:46:43 +02:00
Bjørn Jørgensen
52a999a554 Upgrade Apache Spark to 3.5.0 (#1995)
* 1.

* add note for pandas version

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update images/pyspark-notebook/Dockerfile

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-09-16 20:56:10 +04:00
Ayaz Salikhov
3675f63d08 Test run_hooks when executables fail (#1987) 2023-09-04 19:50:30 +04:00
Ayaz Salikhov
0d8b4e4987 Replace os with pathlib where paths are used (#1984) 2023-08-26 17:41:40 +04:00
Ayaz Salikhov
6aded4bc1d Fix style 2023-08-26 01:39:26 +04:00
Ayaz Salikhov
7a4381ff2f Use only rv['StatusCode'] to simplify code (#1982) 2023-08-25 13:47:36 +04:00
Ayaz Salikhov
74bbd0bffc Implement run-hooks as a separate script (#1979)
* Implement run-hooks as a separate script

* Add more tests

* Add more docs
2023-08-25 01:53:00 +04:00
Ayaz Salikhov
c2bf3c6bfd Revert "Temporarily disable tests using conda --json output"
This reverts commit bc938c50dc.
2023-08-24 15:25:53 +04:00
Matthias Jobst
72ef9bc17d Healthcheck gives correct result even behind proxy (#1964)
* Fixed #1962

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update base-notebook/docker_healthcheck.py

Use empty string instead of None

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-08-13 23:14:47 +04:00
Ayaz Salikhov
bc938c50dc Temporarily disable tests using conda --json output 2023-07-28 18:22:43 +04:00
Ayaz Salikhov
4b2a473cbb Revert "Temporarily disable tests using conda --json output"
This reverts commit 7c03161578.
2023-07-28 18:11:35 +04:00
Ayaz Salikhov
df06e24103 Improve wording in docs about Jupyter Notebook (#1949)
* Improve wording in docs about Jupyter Notebook

* Fixes

* Better naming

* Apply suggestions from code review
2023-07-28 12:16:02 +04:00
Ayaz Salikhov
7c03161578 Temporarily disable tests using conda --json output 2023-07-28 12:06:40 +04:00
Ayaz Salikhov
bfe5f20914 Use correct ServerApp options in examples and tests (#1947) 2023-07-26 20:09:47 +04:00
Ayaz Salikhov
2edc0fe214 Put pluto test in one common file (#1934) 2023-07-05 22:07:43 +04:00
Yuvi Panda
39582f7099 Install Pluto.jl and jupyter-pluto-proxy (#1929)
* Install Pluto.jl and jupyter-pluto-proxy

[Pluto.jl](https://plutojl.org/) is an alternative reactive notebook
frontend focused specifically on Julia. I think shipping this
by default in the julia-enabled images helps serve the Julia
community better, particularly when used with JupyterHub.

For context, I am working with the Julia users of the
[Jupyter Meets the Earth](https://jupytearth.org/) project, and
trying to understand how to best serve their needs on a JupyterHub.
We currently maintain a massive image that 'has everything', but
I'm trying to instead work upstream wherever possible so everyone
working in these subfields can benefit. Meeting Julia users where
they are at seems a useful path forward here.

* Add note about Pluto.jl to selecting.md

* Default to replacing - with _ in package imports

* Add jupyter-pluto-proxy to package import mapping

* Add Pluto.jl to datascience-notebook image

* Add test for pluto proxy starting correctly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_packages.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-07-05 18:48:36 +04:00
Ayaz Salikhov
c44f6e9476 Remove extra line in some test files 2023-07-03 00:35:00 +04:00
Ayaz Salikhov
2343fdba34 Add run_command script in tests (#1931)
* Add run_command script in tests

* Fix

* Add timeout back
2023-07-03 00:34:06 +04:00
Yuvi Panda
a489a0f259 Add jupyter/julia-notebook (#1926)
* Add jupyter/julia-notebook

There is a growing number of Julia users in the Jupyter
ecosystem who do not use R, and hence would <3 to have a
dedicated docker image that doesn't bring in all the R
stuff that datascience-notebook brings in! The built image
size is much smaller, and eventually paves the way to
better ecosystem support for Julia.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add a test for julia-notebook

* Tell tests what julia-notebook inherits from

* Sort lists with julia-notebook

* Fix README for julia-notebook

* Add julia-notebook to the makefile

* Move julia-notebook below r-notebook

* Use hard tabs in Makefile

* Do some more sorting

* Rename test_julia to avoid mypy issue

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Re-order julia/r-notebook

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

* Move julia-notebook stanza under r-notebook

* Update inheritance diagram

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-06-28 14:41:45 +04:00
Bjørn Jørgensen
df5d516e34 Pin pandas to version 1.5.3 to all spark images (#1925)
* 1.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add note

* typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove test

* >=1.5.3 and <2.0.0

* update test

* Update pyspark-notebook/Dockerfile

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pyspark-notebook/Dockerfile

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

* move test to file

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add pandas to EXCLUDED_PACKAGES

* add 1.5.3,<2.0.0 and sort list

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add '

* "pandas[version='>"

* Rename test_pandas_version.py to unit_pandas_version.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-06-27 15:42:18 +04:00