Commit Graph

9 Commits

Author SHA1 Message Date
Yuvi Panda
bceaead5d2 Migrate start-notebook & start-singleuser to python (#2006)
* Migrate start-notebook.sh to bash

Based on

> Stop using bash, haha 👍

from https://github.com/jupyter/docker-stacks/issues/1532.

If there's more apetite for this, I'll try to migrate
`start.sh` and `start-singleuser.sh` as well - I think they should
all be merged together. We can remove the `.sh` suffixes for
accuracy, and keep symlinks in so old config still works. Since
the shebang is what is used to launch the correct interpreter,
the `.sh` doesn't matter.

Will help fix https://github.com/jupyter/docker-stacks/issues/1532,
as I believe all those things are going to be easier to do from
python than bash

* Rename start-notebook.sh to start-notebook

* Cleanup start-notebook a little

* Fix typo

* Migrate start-singleuser as well

* Remove unused import

* Run symlink commands as root

* Combine repetitive RUN commands

* Remove multiple args to env

-u can not be set by shebang, we must set the env var
instead

* Fix conditional inversion

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

* Fix how start-singleuser is exec'd

* Actually call jupyterhub-singleuser in start-singleuser

* Pass through any additional args we get

* Put .py suffix on the start-* scripts

* Add .sh shims for the start-* scripts

* Document start-notebook.sh and start-singleuser.sh

* Partially test start-notebook.sh

* Reflow warning docs

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
2023-10-17 14:46:43 +02:00
Ayaz Salikhov
bfe5f20914 Use correct ServerApp options in examples and tests (#1947) 2023-07-26 20:09:47 +04:00
Ayaz Salikhov
c44f6e9476 Remove extra line in some test files 2023-07-03 00:35:00 +04:00
Ayaz Salikhov
6e62efb398 Reduce sleep timeouts in tests 2022-07-17 13:20:54 +04:00
Ayaz Salikhov
10b1efedb0 Merge branch 'master' into asalikhov/modules 2022-04-28 16:35:14 +01:00
Ayaz Salikhov
0aa95c71ad Make tests a module and make imports absolute 2022-04-01 01:26:37 +01:00
Ayaz Salikhov
c1a892c6dc Remove JUPYTER_ENABLE_LAB variable warning 2022-04-01 00:23:17 +01:00
Ayaz Salikhov
2f201a4b81 Run pre-commit tools: isort, requirements-txt-fixer 2022-03-16 14:48:23 +02:00
Ayaz Salikhov
6d04f39de6 Run tests on all children images 2022-02-17 16:34:15 +00:00