* Migrate start-notebook.sh to bash
Based on
> Stop using bash, haha 👍
from https://github.com/jupyter/docker-stacks/issues/1532.
If there's more apetite for this, I'll try to migrate
`start.sh` and `start-singleuser.sh` as well - I think they should
all be merged together. We can remove the `.sh` suffixes for
accuracy, and keep symlinks in so old config still works. Since
the shebang is what is used to launch the correct interpreter,
the `.sh` doesn't matter.
Will help fix https://github.com/jupyter/docker-stacks/issues/1532,
as I believe all those things are going to be easier to do from
python than bash
* Rename start-notebook.sh to start-notebook
* Cleanup start-notebook a little
* Fix typo
* Migrate start-singleuser as well
* Remove unused import
* Run symlink commands as root
* Combine repetitive RUN commands
* Remove multiple args to env
-u can not be set by shebang, we must set the env var
instead
* Fix conditional inversion
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
* Fix how start-singleuser is exec'd
* Actually call jupyterhub-singleuser in start-singleuser
* Pass through any additional args we get
* Put .py suffix on the start-* scripts
* Add .sh shims for the start-* scripts
* Document start-notebook.sh and start-singleuser.sh
* Partially test start-notebook.sh
* Reflow warning docs
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
---------
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
* Fixed#1962
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update base-notebook/docker_healthcheck.py
Use empty string instead of None
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
* Get healthcheck URL from JSON file
Obtain Jupyter server's full URL from
/home/$NB_USER/.local/share/jupyter/runtime/*.json
and use it for healthcheck.
* Expand tests for healthcheck
* Update pre-commit config
* Remove workdir from tests
* Wait for container start with 0.1s interval
* Quote NB_USER variable on base-notebook/Dockerfile
* Fix style and make test actually work
* Ooops, GitHub didn't show last line
* Fix mypy
* Use bash with pipefail option for healthcheck
* Create python script for healthcheck
* Don't verify SSL certificate on healthcheck
* Update healthcheck test
- Add "user" parameter
- Add tests when container should not be healthy
* Fix typo
* Update test_healthcheck.py
---------
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
* Use the JUPYTER_PORT environment variable to configure server port
- Remove port setting in jupyter_server_config.py
- Declare the $JUPYTER_PORT env on the base Dockerfile
- Use it for HEALTHCHECK
* Add test case for JUPYTER_PORT env variable
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update documentation
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update style
* Better wording
* Better wording
* Add test for custom internal port
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Parametrize internal port test case
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Try to fix test
* Better tests
Co-authored-by: Muhammad Aji Muharrom <ajimuharrom@uchicago.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@gmail.com>
