mirror of
https://github.com/jupyter/docker-stacks.git
synced 2025-10-11 12:02:56 +00:00

* Migrate start-notebook.sh to bash Based on > Stop using bash, haha 👍 from https://github.com/jupyter/docker-stacks/issues/1532. If there's more apetite for this, I'll try to migrate `start.sh` and `start-singleuser.sh` as well - I think they should all be merged together. We can remove the `.sh` suffixes for accuracy, and keep symlinks in so old config still works. Since the shebang is what is used to launch the correct interpreter, the `.sh` doesn't matter. Will help fix https://github.com/jupyter/docker-stacks/issues/1532, as I believe all those things are going to be easier to do from python than bash * Rename start-notebook.sh to start-notebook * Cleanup start-notebook a little * Fix typo * Migrate start-singleuser as well * Remove unused import * Run symlink commands as root * Combine repetitive RUN commands * Remove multiple args to env -u can not be set by shebang, we must set the env var instead * Fix conditional inversion Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com> * Fix how start-singleuser is exec'd * Actually call jupyterhub-singleuser in start-singleuser * Pass through any additional args we get * Put .py suffix on the start-* scripts * Add .sh shims for the start-* scripts * Document start-notebook.sh and start-singleuser.sh * Partially test start-notebook.sh * Reflow warning docs Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com> --------- Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
160 lines
4.4 KiB
Python
160 lines
4.4 KiB
Python
# Copyright (c) Jupyter Development Team.
|
|
# Distributed under the terms of the Modified BSD License.
|
|
import logging
|
|
import time
|
|
from typing import Optional
|
|
|
|
import pytest # type: ignore
|
|
|
|
from tests.conftest import TrackedContainer, get_health
|
|
|
|
LOGGER = logging.getLogger(__name__)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"env,cmd,user",
|
|
[
|
|
(None, None, None),
|
|
(["DOCKER_STACKS_JUPYTER_CMD=lab"], None, None),
|
|
(["DOCKER_STACKS_JUPYTER_CMD=notebook"], None, None),
|
|
(["DOCKER_STACKS_JUPYTER_CMD=server"], None, None),
|
|
(["DOCKER_STACKS_JUPYTER_CMD=nbclassic"], None, None),
|
|
(["RESTARTABLE=yes"], None, None),
|
|
(["JUPYTER_PORT=8171"], None, None),
|
|
(["JUPYTER_PORT=8117", "DOCKER_STACKS_JUPYTER_CMD=notebook"], None, None),
|
|
(None, ["start-notebook.sh"], None),
|
|
(None, ["start-notebook.py", "--ServerApp.base_url=/test"], None),
|
|
(None, ["start-notebook.py", "--ServerApp.base_url=/test/"], None),
|
|
(["GEN_CERT=1"], ["start-notebook.py", "--ServerApp.base_url=/test"], None),
|
|
(
|
|
["GEN_CERT=1", "JUPYTER_PORT=7891"],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
None,
|
|
),
|
|
(["NB_USER=testuser", "CHOWN_HOME=1"], None, "root"),
|
|
(
|
|
["NB_USER=testuser", "CHOWN_HOME=1"],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
"root",
|
|
),
|
|
(
|
|
["NB_USER=testuser", "CHOWN_HOME=1", "JUPYTER_PORT=8123"],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
"root",
|
|
),
|
|
],
|
|
)
|
|
def test_health(
|
|
container: TrackedContainer,
|
|
env: Optional[list[str]],
|
|
cmd: Optional[list[str]],
|
|
user: Optional[str],
|
|
) -> None:
|
|
running_container = container.run_detached(
|
|
tty=True,
|
|
environment=env,
|
|
command=cmd,
|
|
user=user,
|
|
)
|
|
|
|
# sleeping some time to let the server start
|
|
time_spent = 0.0
|
|
wait_time = 0.1
|
|
time_limit = 15
|
|
while time_spent < time_limit:
|
|
time.sleep(wait_time)
|
|
time_spent += wait_time
|
|
if get_health(running_container) == "healthy":
|
|
return
|
|
|
|
assert get_health(running_container) == "healthy"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"env,cmd,user",
|
|
[
|
|
(
|
|
["HTTPS_PROXY=host.docker.internal", "HTTP_PROXY=host.docker.internal"],
|
|
None,
|
|
None,
|
|
),
|
|
(
|
|
[
|
|
"NB_USER=testuser",
|
|
"CHOWN_HOME=1",
|
|
"JUPYTER_PORT=8123",
|
|
"HTTPS_PROXY=host.docker.internal",
|
|
"HTTP_PROXY=host.docker.internal",
|
|
],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
"root",
|
|
),
|
|
],
|
|
)
|
|
def test_health_proxy(
|
|
container: TrackedContainer,
|
|
env: Optional[list[str]],
|
|
cmd: Optional[list[str]],
|
|
user: Optional[str],
|
|
) -> None:
|
|
running_container = container.run_detached(
|
|
tty=True,
|
|
environment=env,
|
|
command=cmd,
|
|
user=user,
|
|
)
|
|
|
|
# sleeping some time to let the server start
|
|
time_spent = 0.0
|
|
wait_time = 0.1
|
|
time_limit = 15
|
|
while time_spent < time_limit:
|
|
time.sleep(wait_time)
|
|
time_spent += wait_time
|
|
if get_health(running_container) == "healthy":
|
|
return
|
|
|
|
assert get_health(running_container) == "healthy"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"env,cmd,user",
|
|
[
|
|
(["NB_USER=testuser", "CHOWN_HOME=1"], None, None),
|
|
(
|
|
["NB_USER=testuser", "CHOWN_HOME=1"],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
None,
|
|
),
|
|
(
|
|
["NB_USER=testuser", "CHOWN_HOME=1", "JUPYTER_PORT=8123"],
|
|
["start-notebook.py", "--ServerApp.base_url=/test"],
|
|
None,
|
|
),
|
|
],
|
|
)
|
|
def test_not_healthy(
|
|
container: TrackedContainer,
|
|
env: Optional[list[str]],
|
|
cmd: Optional[list[str]],
|
|
user: Optional[str],
|
|
) -> None:
|
|
running_container = container.run_detached(
|
|
tty=True,
|
|
environment=env,
|
|
command=cmd,
|
|
user=user,
|
|
)
|
|
|
|
# sleeping some time to let the server start
|
|
time_spent = 0.0
|
|
wait_time = 0.1
|
|
time_limit = 15
|
|
while time_spent < time_limit:
|
|
time.sleep(wait_time)
|
|
time_spent += wait_time
|
|
if get_health(running_container) == "healthy":
|
|
raise RuntimeError("Container should not be healthy for these testcases.")
|
|
|
|
assert get_health(running_container) != "healthy"
|