added missing typedoc + removed console.logs

This commit is contained in:
lotte
2020-07-22 10:27:57 +02:00
parent ee8ad1293f
commit 091ec6c917
5 changed files with 18 additions and 4 deletions

View File

@@ -415,7 +415,6 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
const arrayContext: DynamicFormArrayModel = (this.context as DynamicFormArrayGroupModel).context;
const path = this.formBuilderService.getPath(arrayContext);
const formArrayControl = this.group.root.get(path) as FormArray;
console.log('this.listId', this.listId);
this.formBuilderService.removeFormArrayGroup(this.context.index, formArrayControl, arrayContext);
}

View File

@@ -119,7 +119,6 @@ export class DsDynamicScrollableDropdownComponent extends DynamicFormControlComp
onSelect(event) {
this.group.markAsDirty();
console.log('onSelect event', event);
this.model.valueUpdates.next(event);
this.change.emit(event);
this.setCurrentValue(event);

View File

@@ -115,6 +115,9 @@ export class RelationshipEffects {
)
);
/**
* Save the latest submission ID, to make sure it's updated when the patch is finished
*/
@Effect({ dispatch: false }) updateRelationshipActions$ = this.actions$
.pipe(
ofType(RelationshipActionTypes.UPDATE_RELATIONSHIP),
@@ -123,7 +126,10 @@ export class RelationshipEffects {
})
);
@Effect() commitServerSyncBuffer = this.actions$
/**
* Save the submission object with ID updateAfterPatchSubmissionId
*/
@Effect() saveSubmissionSection = this.actions$
.pipe(
ofType(ServerSyncBufferActionTypes.EMPTY, JsonPatchOperationsActionTypes.COMMIT_JSON_PATCH_OPERATIONS),
filter(() => hasValue(this.updateAfterPatchSubmissionId)),
@@ -174,7 +180,11 @@ export class RelationshipEffects {
});
}
refreshWorkspaceItemInCache(submissionId: string): Observable<SubmissionObject> {
/**
* Make sure the SubmissionObject is refreshed in the cache after being used
* @param submissionId The ID of the submission object
*/
private refreshWorkspaceItemInCache(submissionId: string): Observable<SubmissionObject> {
return this.submissionObjectService.getHrefByID(submissionId).pipe(take(1)).pipe(
switchMap((href: string) => {
this.objectCache.remove(href);

View File

@@ -29,6 +29,9 @@ import { createSuccessfulRemoteDataObject } from '../../../../../remote-data.uti
* Tab for inside the lookup model that represents the currently selected relationships
*/
export class DsDynamicLookupRelationSelectionTabComponent {
/**
* A string that describes the type of relationship
*/
@Input() relationshipType: string;
/**

View File

@@ -242,6 +242,9 @@ export class SubmissionObjectEffects {
catchError(() => observableOf(new DiscardSubmissionErrorAction(action.payload.submissionId))));
}));
/**
* Adds all metadata an item to the SubmissionForm sections of the submission
*/
@Effect() addAllMetadataToSectionData = this.actions$.pipe(
ofType(SubmissionObjectActionTypes.UPLOAD_SECTION_DATA),
switchMap((action: UpdateSectionDataAction) => {