[TLC-674] Tidy up components, WIP spec tests

This commit is contained in:
Kim Shepherd
2024-01-23 14:00:14 +13:00
parent b672668e15
commit 0e4ad5e674
8 changed files with 267 additions and 24 deletions

View File

@@ -9,12 +9,12 @@ import { SectionDataObject } from '../models/section-data.model';
import { SubmissionService } from '../../submission.service';
import { AlertType } from '../../../shared/alert/alert-type';
import { SectionsService } from '../sections.service';
import {map} from "rxjs/operators";
import {ItemDataService} from "../../../core/data/item-data.service";
import {
WorkspaceitemSectionDuplicatesObject
} from "../../../core/submission/models/workspaceitem-section-duplicates.model";
import {Metadata} from "../../../core/shared/metadata.utils";
import {URLCombiner} from "../../../core/url-combiner/url-combiner";
import {getItemModuleRoute} from "../../../item-page/item-page-routing-paths";
/**
* Detect duplicates step
@@ -47,19 +47,12 @@ export class SubmissionSectionDuplicatesComponent extends SectionModelComponent
*/
protected subs: Subscription[] = [];
/**
* Section data observable
*/
public data$: Observable<WorkspaceitemSectionDuplicatesObject>;
/**
* Initialize instance variables.
*
* @param {TranslateService} translate
* @param {SectionsService} sectionService
* @param {SubmissionService} submissionService
* @param itemDataService
* @param nameService
* @param {string} injectedCollectionId
* @param {SectionDataObject} injectedSectionData
* @param {string} injectedSubmissionId
@@ -67,8 +60,6 @@ export class SubmissionSectionDuplicatesComponent extends SectionModelComponent
constructor(protected translate: TranslateService,
protected sectionService: SectionsService,
protected submissionService: SubmissionService,
private itemDataService: ItemDataService,
// private nameService: DSONameService,
@Inject('collectionIdProvider') public injectedCollectionId: string,
@Inject('sectionDataProvider') public injectedSectionData: SectionDataObject,
@Inject('submissionIdProvider') public injectedSubmissionId: string) {
@@ -84,13 +75,7 @@ export class SubmissionSectionDuplicatesComponent extends SectionModelComponent
*/
onSectionInit() {
this.isLoading = false;
this.data$ = this.getDuplicateData().pipe(
map((data: WorkspaceitemSectionDuplicatesObject) => {
console.dir(data);
return data;
})
);
}
}
/**
* Check if identifier section has read-only visibility
@@ -123,5 +108,9 @@ export class SubmissionSectionDuplicatesComponent extends SectionModelComponent
Observable<WorkspaceitemSectionDuplicatesObject>;
}
public getItemLink(uuid: any) {
return new URLCombiner(getItemModuleRoute(), uuid).toString();
}
protected readonly Metadata = Metadata;
}