From 13e9808df2c3be37059b7b7fbc3bb6ed74f9b1a4 Mon Sep 17 00:00:00 2001 From: Yury Bondarenko Date: Thu, 14 Mar 2024 12:30:20 +0100 Subject: [PATCH] Don't enforce ThemedComponent selectors in test HTML --- .../src/rules/html/themed-component-usages.ts | 5 ++++ .../rules/themed-component-usages.spec.ts | 30 +++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/lint/src/rules/html/themed-component-usages.ts b/lint/src/rules/html/themed-component-usages.ts index 6184805a2b..160d93326b 100644 --- a/lint/src/rules/html/themed-component-usages.ts +++ b/lint/src/rules/html/themed-component-usages.ts @@ -20,6 +20,11 @@ export default { } }, create(context: any) { + if (context.getFilename().includes('.spec.ts')) { + // skip inline templates in unit tests + return {}; + } + return { [`Element$1[name = /^${DISALLOWED_THEME_SELECTORS}/]`](node: any) { context.report({ diff --git a/lint/test/rules/themed-component-usages.spec.ts b/lint/test/rules/themed-component-usages.spec.ts index 2f5dbcec20..4ab3588ef6 100644 --- a/lint/test/rules/themed-component-usages.spec.ts +++ b/lint/test/rules/themed-component-usages.spec.ts @@ -137,6 +137,36 @@ describe('themed-component-usages (HTML)', () => { `, }, + { + name: fixture('src/test.ts'), + code: ` +@Component({ + template: '' +}) +class Test { +} + `, + }, + { + name: fixture('src/test.spec.ts'), + code: ` +@Component({ + template: '' +}) +class Test { +} + `, + }, + { + filename: fixture('src/test.spec.ts'), + code: ` +@Component({ + template: '' +}) +class Test { +} + `, + }, ], invalid: [ {