fixed import issues

This commit is contained in:
lotte
2019-12-16 11:19:08 +01:00
parent c54faf69b1
commit 149f59039e
9 changed files with 52 additions and 43 deletions

View File

@@ -1,7 +1,6 @@
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router'; import { RouterModule } from '@angular/router';
import { SearchComponent } from './search.component';
import { ConfigurationSearchPageGuard } from './configuration-search-page.guard'; import { ConfigurationSearchPageGuard } from './configuration-search-page.guard';
import { ConfigurationSearchPageComponent } from './configuration-search-page.component'; import { ConfigurationSearchPageComponent } from './configuration-search-page.component';
import { SearchPageComponent } from './search-page.component'; import { SearchPageComponent } from './search-page.component';

View File

@@ -8,9 +8,11 @@ import { ConfigurationSearchPageComponent } from './configuration-search-page.co
import { ConfigurationSearchPageGuard } from './configuration-search-page.guard'; import { ConfigurationSearchPageGuard } from './configuration-search-page.guard';
import { SearchTrackerComponent } from './search-tracker.component'; import { SearchTrackerComponent } from './search-tracker.component';
import { StatisticsModule } from '../statistics/statistics.module'; import { StatisticsModule } from '../statistics/statistics.module';
import { SearchComponent } from './search.component';
const components = [ const components = [
SearchPageComponent, SearchPageComponent,
SearchComponent,
ConfigurationSearchPageComponent, ConfigurationSearchPageComponent,
SearchTrackerComponent SearchTrackerComponent
]; ];

View File

@@ -2,16 +2,17 @@ import { Component, Inject, OnInit } from '@angular/core';
import { Angulartics2 } from 'angulartics2'; import { Angulartics2 } from 'angulartics2';
import { filter, map, switchMap } from 'rxjs/operators'; import { filter, map, switchMap } from 'rxjs/operators';
import { SearchComponent } from './search.component'; import { SearchComponent } from './search.component';
import { SearchService } from './search-service/search.service';
import { SidebarService } from '../shared/sidebar/sidebar.service'; import { SidebarService } from '../shared/sidebar/sidebar.service';
import { SearchConfigurationService } from './search-service/search-configuration.service';
import { HostWindowService } from '../shared/host-window.service'; import { HostWindowService } from '../shared/host-window.service';
import { SEARCH_CONFIG_SERVICE } from '../+my-dspace-page/my-dspace-page.component'; import { SEARCH_CONFIG_SERVICE } from '../+my-dspace-page/my-dspace-page.component';
import { RouteService } from '../core/services/route.service'; import { RouteService } from '../core/services/route.service';
import { hasValue } from '../shared/empty.util'; import { hasValue } from '../shared/empty.util';
import { SearchQueryResponse } from './search-service/search-query-response.model';
import { SearchSuccessResponse } from '../core/cache/response.models'; import { SearchSuccessResponse } from '../core/cache/response.models';
import { PaginatedSearchOptions } from './paginated-search-options.model'; import { SearchConfigurationService } from '../core/shared/search/search-configuration.service';
import { Router } from '@angular/router';
import { SearchService } from '../core/shared/search/search.service';
import { PaginatedSearchOptions } from '../shared/search/paginated-search-options.model';
import { SearchQueryResponse } from '../shared/search/search-query-response.model';
/** /**
* This component triggers a page view statistic * This component triggers a page view statistic
@@ -30,14 +31,15 @@ import { PaginatedSearchOptions } from './paginated-search-options.model';
export class SearchTrackerComponent extends SearchComponent implements OnInit { export class SearchTrackerComponent extends SearchComponent implements OnInit {
constructor( constructor(
protected service:SearchService, protected service: SearchService,
protected sidebarService:SidebarService, protected sidebarService: SidebarService,
protected windowService:HostWindowService, protected windowService: HostWindowService,
@Inject(SEARCH_CONFIG_SERVICE) public searchConfigService:SearchConfigurationService, @Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: SearchConfigurationService,
protected routeService:RouteService, protected routeService: RouteService,
public angulartics2:Angulartics2 public angulartics2: Angulartics2,
protected router: Router
) { ) {
super(service, sidebarService, windowService, searchConfigService, routeService); super(service, sidebarService, windowService, searchConfigService, routeService, router);
} }
ngOnInit():void { ngOnInit():void {
@@ -58,9 +60,9 @@ export class SearchTrackerComponent extends SearchComponent implements OnInit {
) )
) )
.subscribe((entry) => { .subscribe((entry) => {
const config:PaginatedSearchOptions = entry.searchOptions; const config: PaginatedSearchOptions = entry.searchOptions;
const searchQueryResponse:SearchQueryResponse = entry.response; const searchQueryResponse: SearchQueryResponse = entry.response;
const filters:Array<{ filter:string, operator:string, value:string, label:string; }> = []; const filters:Array<{ filter: string, operator: string, value: string, label: string; }> = [];
const appliedFilters = searchQueryResponse.appliedFilters || []; const appliedFilters = searchQueryResponse.appliedFilters || [];
for (let i = 0, filtersLength = appliedFilters.length; i < filtersLength; i++) { for (let i = 0, filtersLength = appliedFilters.length; i < filtersLength; i++) {
const appliedFilter = appliedFilters[i]; const appliedFilter = appliedFilters[i];

View File

@@ -46,5 +46,9 @@
[scopes]="(scopeListRD$ | async)" [scopes]="(scopeListRD$ | async)"
[inPlaceSearch]="inPlaceSearch"> [inPlaceSearch]="inPlaceSearch">
</ds-search-form> </ds-search-form>
<div class="row mb-3 mb-md-1">
<div class="labels col-sm-9 offset-sm-3">
<ds-search-labels *ngIf="searchEnabled" [inPlaceSearch]="inPlaceSearch"></ds-search-labels> <ds-search-labels *ngIf="searchEnabled" [inPlaceSearch]="inPlaceSearch"></ds-search-labels>
</div>
</div>
</ng-template> </ng-template>

View File

@@ -1,20 +1,22 @@
import { ChangeDetectionStrategy, Component, Inject, Input, OnInit } from '@angular/core'; import { ChangeDetectionStrategy, Component, Inject, Input, OnInit } from '@angular/core';
import { BehaviorSubject, Observable, of as observableOf, Subscription } from 'rxjs'; import { BehaviorSubject, Observable, Subscription } from 'rxjs';
import { startWith, switchMap, } from 'rxjs/operators'; import { startWith, switchMap, } from 'rxjs/operators';
import { PaginatedList } from '../core/data/paginated-list'; import { PaginatedList } from '../core/data/paginated-list';
import { RemoteData } from '../core/data/remote-data'; import { RemoteData } from '../core/data/remote-data';
import { DSpaceObject } from '../core/shared/dspace-object.model'; import { DSpaceObject } from '../core/shared/dspace-object.model';
import { pushInOut } from '../shared/animations/push'; import { pushInOut } from '../shared/animations/push';
import { HostWindowService } from '../shared/host-window.service'; import { HostWindowService } from '../shared/host-window.service';
import { PaginatedSearchOptions } from './paginated-search-options.model';
import { SearchResult } from './search-result.model';
import { SearchService } from './search-service/search.service';
import { SidebarService } from '../shared/sidebar/sidebar.service'; import { SidebarService } from '../shared/sidebar/sidebar.service';
import { hasValue, isNotEmpty } from '../shared/empty.util'; import { hasValue, isNotEmpty } from '../shared/empty.util';
import { SearchConfigurationService } from './search-service/search-configuration.service';
import { getSucceededRemoteData } from '../core/shared/operators'; import { getSucceededRemoteData } from '../core/shared/operators';
import { RouteService } from '../core/services/route.service'; import { RouteService } from '../core/services/route.service';
import { SEARCH_CONFIG_SERVICE } from '../+my-dspace-page/my-dspace-page.component'; import { SEARCH_CONFIG_SERVICE } from '../+my-dspace-page/my-dspace-page.component';
import { SearchConfigurationService } from '../core/shared/search/search-configuration.service';
import { SearchResult } from '../shared/search/search-result.model';
import { PaginatedSearchOptions } from '../shared/search/paginated-search-options.model';
import { SearchService } from '../core/shared/search/search.service';
import { currentPath } from '../shared/utils/route.utils';
import { Router } from '@angular/router';
@Component({ @Component({
selector: 'ds-search', selector: 'ds-search',
@@ -96,7 +98,8 @@ export class SearchComponent implements OnInit {
protected sidebarService: SidebarService, protected sidebarService: SidebarService,
protected windowService: HostWindowService, protected windowService: HostWindowService,
@Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: SearchConfigurationService, @Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: SearchConfigurationService,
protected routeService: RouteService) { protected routeService: RouteService,
protected router: Router) {
this.isXsOrSm$ = this.windowService.isXsOrSm(); this.isXsOrSm$ = this.windowService.isXsOrSm();
} }
@@ -159,7 +162,7 @@ export class SearchComponent implements OnInit {
*/ */
private getSearchLink(): string { private getSearchLink(): string {
if (this.inPlaceSearch) { if (this.inPlaceSearch) {
return './'; return currentPath(this.router);
} }
return this.service.getSearchLink(); return this.service.getSearchLink();
} }

View File

@@ -1,8 +1,8 @@
import { StoreEffects } from './store.effects'; import { StoreEffects } from './store.effects';
import { NotificationsEffects } from './shared/notifications/notifications.effects'; import { NotificationsEffects } from './shared/notifications/notifications.effects';
import { NavbarEffects } from './navbar/navbar.effects'; import { NavbarEffects } from './navbar/navbar.effects';
import { RelationshipEffects } from './shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects';
import { SidebarEffects } from './shared/sidebar/sidebar-effects.service'; import { SidebarEffects } from './shared/sidebar/sidebar-effects.service';
import { RelationshipEffects } from './shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects';
export const appEffects = [ export const appEffects = [
StoreEffects, StoreEffects,

View File

@@ -4,7 +4,6 @@ import { HALEndpointService } from '../shared/hal-endpoint.service';
import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
import { filter, find, map, switchMap, tap } from 'rxjs/operators'; import { filter, find, map, switchMap, tap } from 'rxjs/operators';
import { configureRequest, getSucceededRemoteData } from '../shared/operators'; import { configureRequest, getSucceededRemoteData } from '../shared/operators';
import { FindAllOptions, FindAllRequest } from './request.models';
import { Observable } from 'rxjs/internal/Observable'; import { Observable } from 'rxjs/internal/Observable';
import { RelationshipType } from '../shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../shared/item-relationships/relationship-type.model';
import { RemoteData } from './remote-data'; import { RemoteData } from './remote-data';
@@ -12,6 +11,7 @@ import { PaginatedList } from './paginated-list';
import { combineLatest as observableCombineLatest } from 'rxjs'; import { combineLatest as observableCombineLatest } from 'rxjs';
import { ItemType } from '../shared/item-relationships/item-type.model'; import { ItemType } from '../shared/item-relationships/item-type.model';
import { isNotUndefined } from '../../shared/empty.util'; import { isNotUndefined } from '../../shared/empty.util';
import { FindListOptions, FindListRequest } from './request.models';
/** /**
* The service handling all relationship requests * The service handling all relationship requests
@@ -35,11 +35,11 @@ export class RelationshipTypeService {
); );
} }
getAllRelationshipTypes(options: FindAllOptions): Observable<RemoteData<PaginatedList<RelationshipType>>> { getAllRelationshipTypes(options: FindListOptions): Observable<RemoteData<PaginatedList<RelationshipType>>> {
const link$ = this.halService.getEndpoint(this.linkPath); const link$ = this.halService.getEndpoint(this.linkPath);
return link$ return link$
.pipe( .pipe(
map((endpointURL: string) => new FindAllRequest(this.requestService.generateRequestId(), endpointURL, options)), map((endpointURL: string) => new FindListRequest(this.requestService.generateRequestId(), endpointURL, options)),
configureRequest(this.requestService), configureRequest(this.requestService),
switchMap(() => this.rdbService.buildList(link$)) switchMap(() => this.rdbService.buildList(link$))
); );

View File

@@ -3,10 +3,9 @@ import { RequestService } from '../core/data/request.service';
import { HALEndpointServiceStub } from '../shared/testing/hal-endpoint-service-stub'; import { HALEndpointServiceStub } from '../shared/testing/hal-endpoint-service-stub';
import { getMockRequestService } from '../shared/mocks/mock-request.service'; import { getMockRequestService } from '../shared/mocks/mock-request.service';
import { TrackRequest } from './track-request.model'; import { TrackRequest } from './track-request.model';
import { ResourceType } from '../core/shared/resource-type';
import { SearchOptions } from '../+search-page/search-options.model';
import { isEqual } from 'lodash'; import { isEqual } from 'lodash';
import { DSpaceObjectType } from '../core/shared/dspace-object-type.model'; import { DSpaceObjectType } from '../core/shared/dspace-object-type.model';
import { SearchOptions } from '../shared/search/search-options.model';
describe('StatisticsService', () => { describe('StatisticsService', () => {
let service:StatisticsService; let service:StatisticsService;

View File

@@ -3,10 +3,10 @@ import { Injectable } from '@angular/core';
import { DSpaceObject } from '../core/shared/dspace-object.model'; import { DSpaceObject } from '../core/shared/dspace-object.model';
import { map, take } from 'rxjs/operators'; import { map, take } from 'rxjs/operators';
import { TrackRequest } from './track-request.model'; import { TrackRequest } from './track-request.model';
import { SearchOptions } from '../+search-page/search-options.model';
import { hasValue, isNotEmpty } from '../shared/empty.util'; import { hasValue, isNotEmpty } from '../shared/empty.util';
import { HALEndpointService } from '../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../core/shared/hal-endpoint.service';
import { RestRequest } from '../core/data/request.models'; import { RestRequest } from '../core/data/request.models';
import { SearchOptions } from '../shared/search/search-options.model';
/** /**
* The statistics service * The statistics service
@@ -15,24 +15,24 @@ import { RestRequest } from '../core/data/request.models';
export class StatisticsService { export class StatisticsService {
constructor( constructor(
protected requestService:RequestService, protected requestService: RequestService,
protected halService:HALEndpointService, protected halService: HALEndpointService,
) { ) {
} }
private sendEvent(linkPath:string, body:any) { private sendEvent(linkPath: string, body: any) {
const requestId = this.requestService.generateRequestId(); const requestId = this.requestService.generateRequestId();
this.halService.getEndpoint(linkPath).pipe( this.halService.getEndpoint(linkPath).pipe(
map((endpoint:string) => new TrackRequest(requestId, endpoint, JSON.stringify(body))), map((endpoint: string) => new TrackRequest(requestId, endpoint, JSON.stringify(body))),
take(1) // otherwise the previous events will fire again take(1) // otherwise the previous events will fire again
).subscribe((request:RestRequest) => this.requestService.configure(request)); ).subscribe((request: RestRequest) => this.requestService.configure(request));
} }
/** /**
* To track a page view * To track a page view
* @param dso: The dso which was viewed * @param dso: The dso which was viewed
*/ */
trackViewEvent(dso:DSpaceObject) { trackViewEvent(dso: DSpaceObject) {
this.sendEvent('/statistics/viewevents', { this.sendEvent('/statistics/viewevents', {
targetId: dso.uuid, targetId: dso.uuid,
targetType: (dso as any).type targetType: (dso as any).type
@@ -47,10 +47,10 @@ export class StatisticsService {
* @param filters: An array of search filters used to filter the result set * @param filters: An array of search filters used to filter the result set
*/ */
trackSearchEvent( trackSearchEvent(
searchOptions:SearchOptions, searchOptions: SearchOptions,
page:{ size:number, totalElements:number, totalPages:number, number:number }, page: { size: number, totalElements: number, totalPages: number, number: number },
sort:{ by:string, order:string }, sort: { by: string, order: string },
filters?:Array<{ filter:string, operator:string, value:string, label:string }> filters?: Array<{ filter: string, operator: string, value: string, label: string }>
) { ) {
const body = { const body = {
query: searchOptions.query, query: searchOptions.query,
@@ -66,13 +66,13 @@ export class StatisticsService {
}, },
}; };
if (hasValue(searchOptions.configuration)) { if (hasValue(searchOptions.configuration)) {
Object.assign(body, {configuration: searchOptions.configuration}) Object.assign(body, { configuration: searchOptions.configuration })
} }
if (hasValue(searchOptions.dsoType)) { if (hasValue(searchOptions.dsoType)) {
Object.assign(body, {dsoType: searchOptions.dsoType.toLowerCase()}) Object.assign(body, { dsoType: searchOptions.dsoType.toLowerCase() })
} }
if (hasValue(searchOptions.scope)) { if (hasValue(searchOptions.scope)) {
Object.assign(body, {scope: searchOptions.scope}) Object.assign(body, { scope: searchOptions.scope })
} }
if (isNotEmpty(filters)) { if (isNotEmpty(filters)) {
const bodyFilters = []; const bodyFilters = [];
@@ -85,7 +85,7 @@ export class StatisticsService {
label: filter.label label: filter.label
}) })
} }
Object.assign(body, {appliedFilters: bodyFilters}) Object.assign(body, { appliedFilters: bodyFilters })
} }
this.sendEvent('/statistics/searchevents', body); this.sendEvent('/statistics/searchevents', body);
} }