hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-17 23:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

ensure getByUUID still returns undefined when there's no match

Browse Source
This commit is contained in:
Art Lowel
2020-04-07 18:26:13 +02:00
parent cea01d46f9
commit 15e44ff46c
2 changed files with 38 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
src/app/core/data/request.service.spec.ts
View File

@@ -140,13 +140,21 @@ describe('RequestService', () => {
describe('getByUUID', () => {
describe('if the request with the specified UUID exists in the store', () => {
beforeEach(() => {
let callCounter = 0;
const responses = [
cold('a', { // A direct hit in the request cache
a: {
completed: true
}
}),
cold('b', { b: undefined }), // No hit in the index
cold('c', { c: undefined }) // So no mapped hit in the request cache
];
selectSpy.and.callFake(() => {
return () => {
return () => hot('a', {
a: {
completed: true
}
});
const response = responses[callCounter];
callCounter++;
return () => response;
};
});
});
@@ -165,17 +173,25 @@ describe('RequestService', () => {
describe(`if the request with the specified UUID doesn't exist in the store `, () => {
beforeEach(() => {
let callCounter = 0;
const responses = [
cold('a', { a: undefined }), // No direct hit in the request cache
cold('b', { b: undefined }), // No hit in the index
cold('c', { c: undefined }), // So no mapped hit in the request cache
];
selectSpy.and.callFake(() => {
return () => {
return () => hot('a', { a: undefined });
const response = responses[callCounter];
callCounter++;
return () => response;
};
});
});
it(`it shouldn't return anything`, () => {
it('should return an Observable of undefined', () => {
const result = service.getByUUID(testUUID);
scheduler.expectObservable(result).toBe('');
scheduler.expectObservable(result).toBe('a', { a: undefined });
});
});
@@ -183,12 +199,11 @@ describe('RequestService', () => {
beforeEach(() => {
let callCounter = 0;
const responses = [
cold('a', { a: undefined }), // No hit in the request cache with that UUID
cold('a', { a: undefined }), // No direct hit in the request cache with that UUID
cold('b', { b: 'otherRequestUUID' }), // A hit in the index, which returns the uuid of the cached request
cold('c', { c: { // the call to retrieve the cached request using the UUID from the index
c: {
completed: true
}
cold('c', { // the call to retrieve the cached request using the UUID from the index
c: {
completed: true
}
})
];
@@ -204,10 +219,9 @@ describe('RequestService', () => {
it(`it should return the cached request`, () => {
const result = service.getByUUID(testUUID);
scheduler.expectObservable(result).toBe('c', { c: {
c: {
completed: true
}
scheduler.expectObservable(result).toBe('c', {
c: {
completed: true
}
});
});