hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-18 15:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dispaly an error notification when an error occured on submission save

Browse Source
This commit is contained in:
Giuseppe Digilio
2019-02-28 18:39:12 +01:00
parent ce06b1af2a
commit 167c50e9a3
5 changed files with 47 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/app/submission/objects/submission-objects.effects.spec.ts
View File

@@ -715,6 +715,38 @@ describe('SubmissionObjectEffects test suite', () => {
});
});
describe('saveError$', () => {
it('should display a new error notification', () => {
actions = hot('--a-', {
a: {
type: SubmissionObjectActionTypes.SAVE_SUBMISSION_FORM_ERROR,
payload: {
submissionId: submissionId
}
}
});
submissionObjectEffects.saveError$.subscribe(() => {
expect(notificationsServiceStub.error).toHaveBeenCalled();
});
});
it('should display a new error notification', () => {
actions = hot('--a-', {
a: {
type: SubmissionObjectActionTypes.SAVE_SUBMISSION_SECTION_FORM_ERROR,
payload: {
submissionId: submissionId
}
}
});
submissionObjectEffects.saveError$.subscribe(() => {
expect(notificationsServiceStub.error).toHaveBeenCalled();
});
});
});
describe('discardSubmission$', () => {
it('should return a DISCARD_SUBMISSION_SUCCESS action on success', () => {
store.nextState({

5
src/app/submission/objects/submission-objects.effects.ts
View File

@@ -137,6 +137,11 @@ export class SubmissionObjectEffects {
catchError(() => observableOf(new SaveSubmissionSectionFormErrorAction(action.payload.submissionId))));
}));
@Effect({dispatch: false}) saveError$ = this.actions$.pipe(
ofType(SubmissionObjectActionTypes.SAVE_SUBMISSION_FORM_ERROR, SubmissionObjectActionTypes.SAVE_SUBMISSION_SECTION_FORM_ERROR),
withLatestFrom(this.store$),
tap(() => this.notificationsService.error(null, this.translate.get('submission.sections.general.save_error_notice'))));
@Effect() saveAndDeposit$ = this.actions$.pipe(
ofType(SubmissionObjectActionTypes.SAVE_AND_DEPOSIT_SUBMISSION),
withLatestFrom(this.store$),