Merge pull request #2930 from alexandrevryghem/fix-sync-i18n-script_contribute-main

Fix sync-i18n script throwing a compile error & added some missing translation keys

scripts/sync-i18n-files.ts

@@ -275,9 +275,11 @@ function readFileIfExists(pathToFile) {
     try {
       return fs.readFileSync(pathToFile, 'utf8');
     } catch (e) {
+      if (e instanceof Error) {
         console.error('Error:', e.stack);
       }
     }
+  }
   return null;
 }
 

src/app/item-page/edit-item-page/item-move/item-move.component.html

@@ -6,7 +6,7 @@
             <div class="row">
                 <div class="col-12">
                   <div class="card mb-3">
-                    <div class="card-header">{{'dso-selector.placeholder' | translate: { type: 'collection' } }}</div>
+                    <div class="card-header">{{'dso-selector.placeholder' | translate: { type: 'dso-selector.placeholder.type.collection' | translate } }}</div>
                     <div class="card-body">
                       <ds-authorized-collection-selector [types]="COLLECTIONS"
                                                          [currentDSOId]="selectedCollection ? selectedCollection.id : originalCollection.id"

src/app/shared/dso-selector/dso-selector/dso-selector.component.ts

@@ -190,7 +190,7 @@ export class DSOSelectorComponent implements OnInit, OnDestroy {
    * The search will always start with the initial currentDSOId value
    */
   ngOnInit(): void {
-    this.typesString = this.types.map((type: string) => type.toString().toLowerCase()).join(', ');
+    this.typesString = this.types.map((type: string) => this.translate.instant(`dso-selector.placeholder.type.${type.toString().toLowerCase()}`)).join(', ');
 
     // Create an observable searching for the current DSO (return empty list if there's no current DSO)
     let currentDSOResult$: Observable<PaginatedList<SearchResult<DSpaceObject>>>;

src/assets/i18n/en.json5

@@ -1726,6 +1726,12 @@
 
   "dso-selector.placeholder": "Search for a {{ type }}",
 
+  "dso-selector.placeholder.type.community": "community",
+
+  "dso-selector.placeholder.type.collection": "collection",
+
+  "dso-selector.placeholder.type.item": "item",
+
   "dso-selector.select.collection.head": "Select a collection",
 
   "dso-selector.set-scope.community.head": "Select a search scope",

src/assets/i18n/fr.json5

@@ -176,7 +176,8 @@
 
   // "admin.registries.bitstream-formats.table.name": "Name",
   "admin.registries.bitstream-formats.table.name": "Nom",
-  // TODO New key - Add a translation
+
+  // "admin.registries.bitstream-formats.table.id": "ID",
   "admin.registries.bitstream-formats.table.id": "ID",
 
   // "admin.registries.bitstream-formats.table.return": "Back",
@@ -253,7 +254,8 @@
 
   // "admin.registries.schema.fields.table.field": "Field",
   "admin.registries.schema.fields.table.field": "Champ",
-  // TODO New key - Add a translation
+
+  // "admin.registries.schema.fields.table.id": "ID",
   "admin.registries.schema.fields.table.id": "ID",
 
   // "admin.registries.schema.fields.table.scopenote": "Scope Note",
@@ -776,9 +778,6 @@
   "admin.reports.collections.match_all_selected_filters": "Correspondant à tous les filtres sélectionnés",
 
 
-  //"admin.reports.items.title": "Metadata Query Report",
-  "admin.reports.items.title": "Rapport de requête de métadonnées",
-
   //"admin.reports.items.breadcrumbs": "Metadata Query Report",
   "admin.reports.items.breadcrumbs": "Requête de métadonnées",
 
@@ -2248,6 +2247,15 @@
   // "dso-selector.placeholder": "Search for a {{ type }}",
   "dso-selector.placeholder": "Rechercher un(e) {{ type }}",
 
+  // "dso-selector.placeholder.type.community": "community",
+  "dso-selector.placeholder.type.community": "communauté",
+
+  // "dso-selector.placeholder.type.collection": "collection",
+  "dso-selector.placeholder.type.collection": "collection",
+
+  // "dso-selector.placeholder.type.item": "item",
+  "dso-selector.placeholder.type.item": "item",
+
   // "dso-selector.select.collection.head": "Select a collection",
   "dso-selector.select.collection.head": "Sélectionner une collection",
 
@@ -6463,9 +6471,6 @@
   //"workspace.search.results.head": "Your submissions",
   "workspace.search.results.head": "Vos dépôts",
 
-  // "workspace.search.results.head": "Your submissions",
-  "workspace.search.results.head": "Vos dépôts",
-
   // "workflowAdmin.search.results.head": "Administer Workflow",
   "workflowAdmin.search.results.head": "Workflow Administrateur",
 

src/assets/i18n/nl.json5

@@ -839,10 +839,6 @@
   "admin.reports.collections.match_all_selected_filters": "Matching all selected filters",
 
 
-  //"admin.reports.items.title": "Metadata Query Report",
-  // TODO New key - Add a translation
-  "admin.reports.items.title": "Metadata Query Report",
-
   //"admin.reports.items.breadcrumbs": "Metadata Query Report",
   // TODO New key - Add a translation
   "admin.reports.items.breadcrumbs": "Metadata Query Report",
@@ -2377,6 +2373,15 @@
   // "dso-selector.placeholder": "Search for a {{ type }}",
   "dso-selector.placeholder": "Zoek een {{ type }}",
 
+  // "dso-selector.placeholder.type.community": "community",
+  "dso-selector.placeholder.type.community": "community",
+
+  // "dso-selector.placeholder.type.collection": "collection",
+  "dso-selector.placeholder.type.collection": "collectie",
+
+  // "dso-selector.placeholder.type.item": "item",
+  "dso-selector.placeholder.type.item": "item",
+
 
 
   // "confirmation-modal.export-metadata.header": "Export metadata for {{ dsoName }}",