72699: Additional fixes for maintaining and clearing the redirect url on login components

src/app/core/auth/auth.service.ts

@@ -436,6 +436,10 @@ export class AuthService {
     this.store.dispatch(new SetRedirectUrlAction(isNotUndefined(url) ? url : ''));
   }
 
+  /**
+   * Set the redirect url if the current one has not been set yet
+   * @param newRedirectUrl
+   */
   setRedirectUrlIfNotSet(newRedirectUrl: string) {
     this.getRedirectUrl().pipe(
       take(1))

src/app/shared/log-in/container/log-in-container.component.ts

@@ -15,6 +15,12 @@ export class LogInContainerComponent implements OnInit {
 
   @Input() authMethod: AuthMethod;
 
+  /**
+   * A boolean representing if LogInContainerComponent is in a standalone page
+   * @type {boolean}
+   */
+  @Input() isStandalonePage: boolean;
+
   /**
    * Injector to inject a section component with the @Input parameters
    * @type {Injector}
@@ -36,6 +42,7 @@ export class LogInContainerComponent implements OnInit {
     this.objectInjector = Injector.create({
       providers: [
         { provide: 'authMethodProvider', useFactory: () => (this.authMethod), deps: [] },
+        { provide: 'isStandalonePage', useFactory: () => (this.isStandalonePage), deps: [] },
       ],
       parent: this.injector
     });

src/app/shared/log-in/log-in.component.html

@@ -4,7 +4,7 @@
     <div *ngIf="i === 1" class="text-center mt-2">
       <span class="align-middle">{{"login.form.or-divider" | translate}}</span>
     </div>
-    <ds-log-in-container [authMethod]="authMethod"></ds-log-in-container>
+    <ds-log-in-container [authMethod]="authMethod" [isStandalonePage]="isStandalonePage"></ds-log-in-container>
   </ng-container>
 
   <div class="dropdown-divider"></div>

src/app/shared/log-in/log-in.component.ts

@@ -2,9 +2,16 @@ import { Component, Input, OnInit } from '@angular/core';
 import { Observable } from 'rxjs';
 import { select, Store } from '@ngrx/store';
 import { AuthMethod } from '../../core/auth/models/auth.method';
-import { getAuthenticationMethods, isAuthenticated, isAuthenticationLoading } from '../../core/auth/selectors';
+import {
+  getAuthenticationError,
+  getAuthenticationMethods,
+  isAuthenticated,
+  isAuthenticationLoading
+} from '../../core/auth/selectors';
 import { CoreState } from '../../core/core.reducers';
 import { getForgotPasswordPath, getRegisterPath } from '../../app-routing.module';
+import { hasValue } from '../empty.util';
+import { AuthService } from '../../core/auth/auth.service';
 
 /**
  * /users/sign-in
@@ -41,7 +48,8 @@ export class LogInComponent implements OnInit {
    */
   public loading: Observable<boolean>;
 
-  constructor(private store: Store<CoreState>) {
+  constructor(private store: Store<CoreState>,
+              private authService: AuthService) {
   }
 
   ngOnInit(): void {
@@ -55,6 +63,13 @@ export class LogInComponent implements OnInit {
 
     // set isAuthenticated
     this.isAuthenticated = this.store.pipe(select(isAuthenticated));
+
+    // Clear the redirect URL if an authentication error occurs and this is not a standalone page
+    this.store.pipe(select(getAuthenticationError)).subscribe((error) => {
+      if (hasValue(error) && !this.isStandalonePage) {
+        this.authService.clearRedirectUrl();
+      }
+    });
   }
 
   getRegisterPath() {

src/app/shared/log-in/methods/password/log-in-password.component.spec.ts

@@ -55,6 +55,7 @@ describe('LogInPasswordComponent', () => {
       providers: [
         { provide: AuthService, useClass: AuthServiceStub },
         { provide: 'authMethodProvider', useValue: new AuthMethod(AuthMethodType.Password) },
+        { provide: 'isStandalonePage', useValue: true },
         { provide: HardRedirectService, useValue: hardRedirectService },
       ],
       schemas: [

src/app/shared/log-in/methods/password/log-in-password.component.ts

@@ -68,6 +68,7 @@ export class LogInPasswordComponent implements OnInit {
   /**
    * @constructor
    * @param {AuthMethod} injectedAuthMethodModel
+   * @param {boolean} isStandalonePage
    * @param {AuthService} authService
    * @param {HardRedirectService} hardRedirectService
    * @param {FormBuilder} formBuilder
@@ -75,6 +76,7 @@ export class LogInPasswordComponent implements OnInit {
    */
   constructor(
     @Inject('authMethodProvider') public injectedAuthMethodModel: AuthMethod,
+    @Inject('isStandalonePage') public isStandalonePage: boolean,
     private authService: AuthService,
     private hardRedirectService: HardRedirectService,
     private formBuilder: FormBuilder,
@@ -140,7 +142,11 @@ export class LogInPasswordComponent implements OnInit {
     email.trim();
     password.trim();
 
-    this.authService.setRedirectUrlIfNotSet(this.hardRedirectService.getCurrentRoute());
+    if (!this.isStandalonePage) {
+      this.authService.setRedirectUrl(this.hardRedirectService.getCurrentRoute());
+    } else {
+      this.authService.setRedirectUrlIfNotSet('/');
+    }
 
     // dispatch AuthenticationAction
     this.store.dispatch(new AuthenticateAction(email, password));

src/app/shared/log-in/methods/shibboleth/log-in-shibboleth.component.spec.ts

@@ -62,6 +62,7 @@ describe('LogInShibbolethComponent', () => {
       providers: [
         { provide: AuthService, useClass: AuthServiceStub },
         { provide: 'authMethodProvider', useValue: new AuthMethod(AuthMethodType.Shibboleth, location) },
+        { provide: 'isStandalonePage', useValue: true },
         { provide: NativeWindowService, useFactory: NativeWindowMockFactory },
         { provide: Router, useValue: new RouterStub() },
         { provide: ActivatedRoute, useValue: new ActivatedRouteStub() },

src/app/shared/log-in/methods/shibboleth/log-in-shibboleth.component.ts

@@ -51,6 +51,7 @@ export class LogInShibbolethComponent implements OnInit {
   /**
    * @constructor
    * @param {AuthMethod} injectedAuthMethodModel
+   * @param {boolean} isStandalonePage
    * @param {NativeWindowRef} _window
    * @param {RouteService} route
    * @param {AuthService} authService
@@ -59,6 +60,7 @@ export class LogInShibbolethComponent implements OnInit {
    */
   constructor(
     @Inject('authMethodProvider') public injectedAuthMethodModel: AuthMethod,
+    @Inject('isStandalonePage') public isStandalonePage: boolean,
     @Inject(NativeWindowService) protected _window: NativeWindowRef,
     private route: RouteService,
     private authService: AuthService,
@@ -81,7 +83,11 @@ export class LogInShibbolethComponent implements OnInit {
   }
 
   redirectToShibboleth() {
-    this.authService.setRedirectUrlIfNotSet(this.hardRedirectService.getCurrentRoute())
+    if (!this.isStandalonePage) {
+      this.authService.setRedirectUrl(this.hardRedirectService.getCurrentRoute());
+    } else {
+      this.authService.setRedirectUrlIfNotSet('/');
+    }
     let newLocationUrl = this.location;
     const currentUrl = this._window.nativeWindow.location.href;
     const myRegexp = /\?redirectUrl=(.*)/g;

src/app/shared/testing/auth-service.stub.ts

@@ -162,4 +162,8 @@ export class AuthServiceStub {
   redirectAfterLoginSuccess() {
     return;
   }
+
+  clearRedirectUrl() {
+    return;
+  }
 }