44024: simple search ui finished

This commit is contained in:
Lotte Hofstede
2017-09-21 16:40:19 +02:00
parent 821fba7f4e
commit 1a149b9d54
3 changed files with 20 additions and 21 deletions

View File

@@ -119,16 +119,15 @@ export function isEmpty(obj?: any): boolean {
}
if (objectType === 'object') {
if (Object.keys(obj).length === 0) {
return true;
}
const length = obj.length;
if (typeof length === 'number') {
return !length;
}
}
if (Object.keys(obj).length === 0) {
return true;
}
return false;
}

View File

@@ -26,7 +26,7 @@
[disabled]="paginationOptions.disabled"
[ellipses]="paginationOptions.ellipses"
[maxSize]="(isXs)?5:paginationOptions.maxSize"
[(page)]="currentPage"
[page]="currentPage"
(pageChange)="doPageChange($event)"
[pageSize]="pageSize"
[rotate]="paginationOptions.rotate"

View File

@@ -258,22 +258,22 @@ describe('Pagination component', () => {
expect(testComp.pageSizeChanged).toHaveBeenCalledWith(5);
}));
// it('should set correct route parameters', fakeAsync(() => {
// const paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references.p;
// routerStub = testFixture.debugElement.injector.get(Router) as any;
//
// testComp.collectionSize = 60;
//
// changePage(testFixture, 3);
// tick();
// expect(routerStub.navigate).toHaveBeenCalledWith([], { queryParams: { pageId: 'test', page: 3, pageSize: 10, sortDirection: 0, sortField: 'name' } });
// expect(paginationComponent.currentPage).toEqual(3);
//
// changePageSize(testFixture, '20');
// tick();
// expect(routerStub.navigate).toHaveBeenCalledWith([], { queryParams: { pageId: 'test', page: 3, pageSize: 20, sortDirection: 0, sortField: 'name' } });
// expect(paginationComponent.pageSize).toEqual(20);
// }));
it('should set correct route parameters', fakeAsync(() => {
const paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references.p;
routerStub = testFixture.debugElement.injector.get(Router) as any;
testComp.collectionSize = 60;
changePage(testFixture, 3);
tick();
expect(routerStub.navigate).toHaveBeenCalledWith([], { queryParams: { pageId: 'test', page: 3, pageSize: 10, sortDirection: 0, sortField: 'name' } });
expect(paginationComponent.currentPage).toEqual(3);
changePageSize(testFixture, '20');
tick();
expect(routerStub.navigate).toHaveBeenCalledWith([], { queryParams: { pageId: 'test', page: 3, pageSize: 20, sortDirection: 0, sortField: 'name' } });
expect(paginationComponent.pageSize).toEqual(20);
}));
it('should get parameters from route', () => {