From 1c4763b409843e17ff10fbab23778d4a64a712f8 Mon Sep 17 00:00:00 2001 From: Yana De Pauw Date: Thu, 4 Mar 2021 09:07:58 +0100 Subject: [PATCH] 77349: Add additional properties and update comment --- .../browse-by-switcher.component.ts | 2 +- .../collection-page.component.ts | 16 ++++++++++------ .../+community-page/community-page.component.ts | 13 +++++++------ .../objectnotfound/objectnotfound.component.ts | 7 ++++--- .../configuration-search-page.component.ts | 2 +- .../app/+search-page/search-page.component.ts | 3 ++- .../community-list-page.component.ts | 3 ++- .../custom/app/forbidden/forbidden.component.ts | 6 ++---- .../end-user-agreement.component.ts | 2 +- .../custom/app/info/privacy/privacy.component.ts | 2 +- .../app/pagenotfound/pagenotfound.component.ts | 7 ++++--- .../collection-statistics-page.component.ts | 2 +- .../community-statistics-page.component.ts | 2 +- .../item-statistics-page.component.ts | 2 +- .../site-statistics-page.component.ts | 2 +- 15 files changed, 39 insertions(+), 32 deletions(-) diff --git a/src/themes/custom/app/+browse-by/+browse-by-switcher/browse-by-switcher.component.ts b/src/themes/custom/app/+browse-by/+browse-by-switcher/browse-by-switcher.component.ts index b772701ad0..58fee73779 100644 --- a/src/themes/custom/app/+browse-by/+browse-by-switcher/browse-by-switcher.component.ts +++ b/src/themes/custom/app/+browse-by/+browse-by-switcher/browse-by-switcher.component.ts @@ -9,7 +9,7 @@ import { BrowseBySwitcherComponent as BaseComponent } from '../../../../../app/+ }) /** - * Component to render the news section on the home page + * Component for determining what Browse-By component to use depending on the metadata (browse ID) provided */ export class BrowseBySwitcherComponent extends BaseComponent {} diff --git a/src/themes/custom/app/+collection-page/collection-page.component.ts b/src/themes/custom/app/+collection-page/collection-page.component.ts index f38a90631f..9d1d5f03f9 100644 --- a/src/themes/custom/app/+collection-page/collection-page.component.ts +++ b/src/themes/custom/app/+collection-page/collection-page.component.ts @@ -1,17 +1,21 @@ -import { Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component } from '@angular/core'; import { CollectionPageComponent as BaseComponent} from '../../../../app/+collection-page/collection-page.component'; +import { fadeIn, fadeInOut } from '../../../../app/shared/animations/fade'; + -/** - * This component representing the `Forbidden` DSpace page. - */ @Component({ selector: 'ds-collection-page', // templateUrl: './collection-page.component.html', templateUrl: '../../../../app/+collection-page/collection-page.component.html', // styleUrls: ['./collection-page.component.scss'] - styleUrls: ['../../../../app/+collection-page/collection-page.component.scss'] + styleUrls: ['../../../../app/+collection-page/collection-page.component.scss'], + changeDetection: ChangeDetectionStrategy.OnPush, + animations: [ + fadeIn, + fadeInOut + ] }) /** - * Component to render the news section on the home page + * This component represents a detail page for a single collection */ export class CollectionPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/+community-page/community-page.component.ts b/src/themes/custom/app/+community-page/community-page.component.ts index 2df33a0b9e..54e9352eb8 100644 --- a/src/themes/custom/app/+community-page/community-page.component.ts +++ b/src/themes/custom/app/+community-page/community-page.component.ts @@ -1,17 +1,18 @@ -import { Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component } from '@angular/core'; import { CommunityPageComponent as BaseComponent} from '../../../../app/+community-page/community-page.component'; +import { fadeInOut } from '../../../../app/shared/animations/fade'; + -/** - * This component representing the `Forbidden` DSpace page. - */ @Component({ selector: 'ds-community-page', // templateUrl: './community-page.component.html', templateUrl: '../../../../app/+community-page/community-page.component.html', // styleUrls: ['./community-page.component.scss'] - styleUrls: ['../../../../app/+community-page/community-page.component.scss'] + styleUrls: ['../../../../app/+community-page/community-page.component.scss'], + changeDetection: ChangeDetectionStrategy.OnPush, + animations: [fadeInOut] }) /** - * Component to render the news section on the home page + * This component represents a detail page for a single community */ export class CommunityPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/+lookup-by-id/objectnotfound/objectnotfound.component.ts b/src/themes/custom/app/+lookup-by-id/objectnotfound/objectnotfound.component.ts index f41553ff00..2c10ddde53 100644 --- a/src/themes/custom/app/+lookup-by-id/objectnotfound/objectnotfound.component.ts +++ b/src/themes/custom/app/+lookup-by-id/objectnotfound/objectnotfound.component.ts @@ -1,4 +1,4 @@ -import { Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component } from '@angular/core'; import { ObjectNotFoundComponent as BaseComponent } from '../../../../../app/+lookup-by-id/objectnotfound/objectnotfound.component'; @Component({ @@ -6,11 +6,12 @@ import { ObjectNotFoundComponent as BaseComponent } from '../../../../../app/+lo // styleUrls: ['./objectnotfound.component.scss'], styleUrls: ['../../../../../app/+lookup-by-id/objectnotfound/objectnotfound.component.scss'], // templateUrl: './objectnotfound.component.html', - templateUrl: '../../../../../app/+lookup-by-id/objectnotfound/objectnotfound.component.html' + templateUrl: '../../../../../app/+lookup-by-id/objectnotfound/objectnotfound.component.html', + changeDetection: ChangeDetectionStrategy.Default }) /** - * Component to render the news section on the home page + * This component representing the `PageNotFound` DSpace page. */ export class ObjectNotFoundComponent extends BaseComponent {} diff --git a/src/themes/custom/app/+search-page/configuration-search-page.component.ts b/src/themes/custom/app/+search-page/configuration-search-page.component.ts index 88e9746b71..42e8dbf2d0 100644 --- a/src/themes/custom/app/+search-page/configuration-search-page.component.ts +++ b/src/themes/custom/app/+search-page/configuration-search-page.component.ts @@ -21,7 +21,7 @@ import { ConfigurationSearchPageComponent as BaseComponent } from '../../../../a }) /** - * Component to render the news section on the home page + * This component renders a search page using a configuration as input. */ export class ConfigurationSearchPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/+search-page/search-page.component.ts b/src/themes/custom/app/+search-page/search-page.component.ts index 1b7c912260..c9bcd65349 100644 --- a/src/themes/custom/app/+search-page/search-page.component.ts +++ b/src/themes/custom/app/+search-page/search-page.component.ts @@ -9,7 +9,8 @@ import { SearchPageComponent as BaseComponent } from '../../../../app/+search-pa }) /** - * Component to render the news section on the home page + * This component represents the whole search page + * It renders search results depending on the current search options */ export class SearchPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/community-list-page/community-list-page.component.ts b/src/themes/custom/app/community-list-page/community-list-page.component.ts index 87e8be0a96..1dbfa15b40 100644 --- a/src/themes/custom/app/community-list-page/community-list-page.component.ts +++ b/src/themes/custom/app/community-list-page/community-list-page.component.ts @@ -9,7 +9,8 @@ import { CommunityListPageComponent as BaseComponent } from '../../../../app/com }) /** - * Component to render the news section on the home page + * Page with title and the community list tree, as described in community-list.component; + * navigated to with community-list.page.routing.module */ export class CommunityListPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/forbidden/forbidden.component.ts b/src/themes/custom/app/forbidden/forbidden.component.ts index e374d67508..915cf651cb 100644 --- a/src/themes/custom/app/forbidden/forbidden.component.ts +++ b/src/themes/custom/app/forbidden/forbidden.component.ts @@ -1,9 +1,7 @@ import { Component } from '@angular/core'; import { ForbiddenComponent as BaseComponent } from '../../../../app/forbidden/forbidden.component'; -/** - * This component representing the `Forbidden` DSpace page. - */ + @Component({ selector: 'ds-forbidden', // templateUrl: './forbidden.component.html', @@ -12,6 +10,6 @@ import { ForbiddenComponent as BaseComponent } from '../../../../app/forbidden/f styleUrls: ['../../../../app/forbidden/forbidden.component.scss'] }) /** - * Component to render the news section on the home page + * This component representing the `Forbidden` DSpace page. */ export class ForbiddenComponent extends BaseComponent {} diff --git a/src/themes/custom/app/info/end-user-agreement/end-user-agreement.component.ts b/src/themes/custom/app/info/end-user-agreement/end-user-agreement.component.ts index 7e4f490023..e3e5ac8d19 100644 --- a/src/themes/custom/app/info/end-user-agreement/end-user-agreement.component.ts +++ b/src/themes/custom/app/info/end-user-agreement/end-user-agreement.component.ts @@ -10,7 +10,7 @@ import { EndUserAgreementComponent as BaseComponent } from '../../../../../app/i }) /** - * Component to render the news section on the home page + * Component displaying the End User Agreement and an option to accept it */ export class EndUserAgreementComponent extends BaseComponent {} diff --git a/src/themes/custom/app/info/privacy/privacy.component.ts b/src/themes/custom/app/info/privacy/privacy.component.ts index fb7f193f4e..f261c64c14 100644 --- a/src/themes/custom/app/info/privacy/privacy.component.ts +++ b/src/themes/custom/app/info/privacy/privacy.component.ts @@ -10,6 +10,6 @@ import { PrivacyComponent as BaseComponent } from '../../../../../app/info/priva }) /** - * Component to render the news section on the home page + * Component displaying the Privacy Statement */ export class PrivacyComponent extends BaseComponent {} diff --git a/src/themes/custom/app/pagenotfound/pagenotfound.component.ts b/src/themes/custom/app/pagenotfound/pagenotfound.component.ts index 565b648172..71dc7332d4 100644 --- a/src/themes/custom/app/pagenotfound/pagenotfound.component.ts +++ b/src/themes/custom/app/pagenotfound/pagenotfound.component.ts @@ -1,4 +1,4 @@ -import { Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component } from '@angular/core'; import { PageNotFoundComponent as BaseComponent } from '../../../../app/pagenotfound/pagenotfound.component'; @Component({ @@ -6,11 +6,12 @@ import { PageNotFoundComponent as BaseComponent } from '../../../../app/pagenotf // styleUrls: ['./pagenotfound.component.scss'], styleUrls: ['../../../../app/pagenotfound/pagenotfound.component.scss'], // templateUrl: './pagenotfound.component.html' - templateUrl: '../../../../app/pagenotfound/pagenotfound.component.html' + templateUrl: '../../../../app/pagenotfound/pagenotfound.component.html', + changeDetection: ChangeDetectionStrategy.Default }) /** - * Component to render the news section on the home page + * This component representing the `PageNotFound` DSpace page. */ export class PageNotFoundComponent extends BaseComponent {} diff --git a/src/themes/custom/app/statistics-page/collection-statistics-page/collection-statistics-page.component.ts b/src/themes/custom/app/statistics-page/collection-statistics-page/collection-statistics-page.component.ts index 0d637fa44d..f3fa9d3e42 100644 --- a/src/themes/custom/app/statistics-page/collection-statistics-page/collection-statistics-page.component.ts +++ b/src/themes/custom/app/statistics-page/collection-statistics-page/collection-statistics-page.component.ts @@ -10,7 +10,7 @@ import { CollectionStatisticsPageComponent as BaseComponent } from '../../../../ }) /** - * Component to render the news section on the home page + * Component representing the statistics page for a collection. */ export class CollectionStatisticsPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/statistics-page/community-statistics-page/community-statistics-page.component.ts b/src/themes/custom/app/statistics-page/community-statistics-page/community-statistics-page.component.ts index 7094d944c9..76aac6aa15 100644 --- a/src/themes/custom/app/statistics-page/community-statistics-page/community-statistics-page.component.ts +++ b/src/themes/custom/app/statistics-page/community-statistics-page/community-statistics-page.component.ts @@ -10,7 +10,7 @@ import { CommunityStatisticsPageComponent as BaseComponent } from '../../../../. }) /** - * Component to render the news section on the home page + * Component representing the statistics page for a community. */ export class CommunityStatisticsPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/statistics-page/item-statistics-page/item-statistics-page.component.ts b/src/themes/custom/app/statistics-page/item-statistics-page/item-statistics-page.component.ts index f436d7ea9f..f2adbc9c21 100644 --- a/src/themes/custom/app/statistics-page/item-statistics-page/item-statistics-page.component.ts +++ b/src/themes/custom/app/statistics-page/item-statistics-page/item-statistics-page.component.ts @@ -10,7 +10,7 @@ import { ItemStatisticsPageComponent as BaseComponent } from '../../../../../app }) /** - * Component to render the news section on the home page + * Component representing the statistics page for an item. */ export class ItemStatisticsPageComponent extends BaseComponent {} diff --git a/src/themes/custom/app/statistics-page/site-statistics-page/site-statistics-page.component.ts b/src/themes/custom/app/statistics-page/site-statistics-page/site-statistics-page.component.ts index 3634a55ada..30dc6502ea 100644 --- a/src/themes/custom/app/statistics-page/site-statistics-page/site-statistics-page.component.ts +++ b/src/themes/custom/app/statistics-page/site-statistics-page/site-statistics-page.component.ts @@ -10,7 +10,7 @@ import { SiteStatisticsPageComponent as BaseComponent } from '../../../../../app }) /** - * Component to render the news section on the home page + * Component representing the site-wide statistics page. */ export class SiteStatisticsPageComponent extends BaseComponent {}