From 25a51c97644a81cef0504faf11859074711a477b Mon Sep 17 00:00:00 2001
From: Giuseppe Digilio <giuseppe.digilio@4science.it>
Date: Mon, 15 Nov 2021 18:52:33 +0100
Subject: [PATCH] [DSC-287] Add test to guard

---
 .../server-check/server-check.guard.spec.ts   | 47 +++++++++++++++++--
 .../core/server-check/server-check.guard.ts   | 20 ++++----
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/src/app/core/server-check/server-check.guard.spec.ts b/src/app/core/server-check/server-check.guard.spec.ts
index fc072cd73c..976021dcdb 100644
--- a/src/app/core/server-check/server-check.guard.spec.ts
+++ b/src/app/core/server-check/server-check.guard.spec.ts
@@ -1,16 +1,55 @@
-import { TestBed } from '@angular/core/testing';
-
 import { ServerCheckGuard } from './server-check.guard';
+import { createFailedRemoteDataObject$, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
+import { first } from 'rxjs/operators';
+import { getPageInternalServerErrorRoute } from '../../app-routing-paths';
 
 describe('ServerCheckGuard', () => {
   let guard: ServerCheckGuard;
+  let router;
+  let rootDataServiceStub: any;
+
+  rootDataServiceStub = jasmine.createSpyObj('RootDataService', {
+    findRoot: jasmine.createSpy('findRoot')
+  });
+  router = jasmine.createSpyObj('Router', {
+    navigateByUrl: jasmine.createSpy('navigateByUrl')
+  });
 
   beforeEach(() => {
-    TestBed.configureTestingModule({});
-    guard = TestBed.inject(ServerCheckGuard);
+    guard = new ServerCheckGuard(router, rootDataServiceStub);
   });
 
   it('should be created', () => {
     expect(guard).toBeTruthy();
   });
+
+  describe('when root endpoint has succeeded', () => {
+    beforeEach(() => {
+      rootDataServiceStub.findRoot.and.returnValue(createSuccessfulRemoteDataObject$({}));
+    });
+
+    it('should not redirect to error page', () => {
+      guard.canActivate({} as any, {} as any).pipe(
+        first()
+      ).subscribe((canActivate: boolean) => {
+        expect(canActivate).toEqual(true);
+        expect(router.navigateByUrl).not.toHaveBeenCalled();
+      });
+    });
+  });
+
+  describe('when root endpoint has not succeeded', () => {
+    beforeEach(() => {
+      rootDataServiceStub.findRoot.and.returnValue(createFailedRemoteDataObject$());
+    });
+
+    it('should redirect to error page', () => {
+      guard.canActivate({} as any, {} as any).pipe(
+        first()
+      ).subscribe((canActivate: boolean) => {
+        expect(canActivate).toEqual(false);
+        expect(router.navigateByUrl).toHaveBeenCalledWith(getPageInternalServerErrorRoute());
+      });
+    });
+  });
 });
diff --git a/src/app/core/server-check/server-check.guard.ts b/src/app/core/server-check/server-check.guard.ts
index 32ff57ebb3..478a710567 100644
--- a/src/app/core/server-check/server-check.guard.ts
+++ b/src/app/core/server-check/server-check.guard.ts
@@ -1,26 +1,30 @@
 import { Injectable } from '@angular/core';
-import { CanActivate, ActivatedRouteSnapshot, RouterStateSnapshot, UrlTree } from '@angular/router';
+import { ActivatedRouteSnapshot, CanActivate, Router, RouterStateSnapshot } from '@angular/router';
+
 import { Observable } from 'rxjs';
-import { RootDataService } from '../data/root-data.service';
 import { map, tap } from 'rxjs/operators';
+
+import { RootDataService } from '../data/root-data.service';
 import { RemoteData } from '../data/remote-data';
 import { getPageInternalServerErrorRoute } from '../../app-routing-paths';
-import { Router } from '@angular/router';
+import { getFirstCompletedRemoteData } from '../shared/operators';
 
 @Injectable({
   providedIn: 'root'
 })
 export class ServerCheckGuard implements CanActivate {
-  constructor(private router: Router,private rootDataService: RootDataService) {}
+  constructor(private router: Router, private rootDataService: RootDataService) {
+  }
 
   canActivate(
     route: ActivatedRouteSnapshot,
-    state: RouterStateSnapshot): Observable<boolean | UrlTree> | Promise<boolean | UrlTree> | boolean | UrlTree {
+    state: RouterStateSnapshot): Observable<boolean> {
 
     return this.rootDataService.findRoot().pipe(
-      map( (res: RemoteData<any>) => res.hasSucceeded ),
-      tap( (responsehasSucceeded: boolean) => {
-        if (!responsehasSucceeded) {
+      getFirstCompletedRemoteData(),
+      map((res: RemoteData<any>) => res.hasSucceeded),
+      tap((hasSucceeded: boolean) => {
+        if (!hasSucceeded) {
           this.router.navigateByUrl(getPageInternalServerErrorRoute());
         }
       }),