62589: PR Feedback

src/app/core/core.module.ts

@@ -117,7 +117,7 @@ import { MetadatafieldParsingService } from './data/metadatafield-parsing.servic
 import { NormalizedSubmissionUploadsModel } from './config/models/normalized-config-submission-uploads.model';
 import { NormalizedBrowseEntry } from './shared/normalized-browse-entry.model';
 import { BrowseDefinition } from './shared/browse-definition.model';
-import { MappingCollectionsReponseParsingService } from './data/mapping-collections-reponse-parsing.service';
+import { MappedCollectionsReponseParsingService } from './data/mapped-collections-reponse-parsing.service';
 import { ObjectSelectService } from '../shared/object-select/object-select.service';
 
 const IMPORTS = [
@@ -165,7 +165,7 @@ const PROVIDERS = [
   RegistryMetadataschemasResponseParsingService,
   RegistryMetadatafieldsResponseParsingService,
   RegistryBitstreamformatsResponseParsingService,
-  MappingCollectionsReponseParsingService,
+  MappedCollectionsReponseParsingService,
   DebugResponseParsingService,
   SearchResponseParsingService,
   MyDSpaceResponseParsingService,

src/app/core/data/item-data.service.ts

@@ -15,7 +15,7 @@ import { HALEndpointService } from '../shared/hal-endpoint.service';
 import {
   DeleteRequest,
   FindAllOptions,
-  MappingCollectionsRequest,
+  MappedCollectionsRequest,
   PatchRequest,
   PostRequest,
   RestRequest
@@ -133,7 +133,7 @@ export class ItemDataService extends DataService<Item> {
     const request$ = this.getMappingCollectionsEndpoint(itemId).pipe(
       isNotEmptyOperator(),
       distinctUntilChanged(),
-      map((endpointURL: string) => new MappingCollectionsRequest(this.requestService.generateRequestId(), endpointURL)),
+      map((endpointURL: string) => new MappedCollectionsRequest(this.requestService.generateRequestId(), endpointURL)),
       configureRequest(this.requestService)
     );
 

src/app/core/data/mapped-collections-reponse-parsing.service.ts

@@ -7,7 +7,11 @@ import { PageInfo } from '../shared/page-info.model';
 import { ErrorResponse, GenericSuccessResponse, RestResponse } from '../cache/response.models';
 
 @Injectable()
-export class MappingCollectionsReponseParsingService implements ResponseParsingService {
+/**
+ * A ResponseParsingService used to parse DSpaceRESTV2Response coming from the REST API to a GenericSuccessResponse
+ * containing a PaginatedList of mapped collections
+ */
+export class MappedCollectionsReponseParsingService implements ResponseParsingService {
   parse(request: RestRequest, data: DSpaceRESTV2Response): RestResponse {
     const payload = data.payload;
 

src/app/core/data/request.models.ts

@@ -18,7 +18,7 @@ import { MetadataschemaParsingService } from './metadataschema-parsing.service';
 import { MetadatafieldParsingService } from './metadatafield-parsing.service';
 import { URLCombiner } from '../url-combiner/url-combiner';
 import { TaskResponseParsingService } from '../tasks/task-response-parsing.service';
-import { MappingCollectionsReponseParsingService } from './mapping-collections-reponse-parsing.service';
+import { MappedCollectionsReponseParsingService } from './mapped-collections-reponse-parsing.service';
 
 /* tslint:disable:max-classes-per-file */
 
@@ -186,9 +186,12 @@ export class BrowseItemsRequest extends GetRequest {
   }
 }
 
-export class MappingCollectionsRequest extends GetRequest {
+/**
+ * Request to fetch the mapped collections of an item
+ */
+export class MappedCollectionsRequest extends GetRequest {
   getResponseParser(): GenericConstructor<ResponseParsingService> {
-    return MappingCollectionsReponseParsingService;
+    return MappedCollectionsReponseParsingService;
   }
 }