From 281a4cd1d7b77ff8c9f51f5cb3e254f497821521 Mon Sep 17 00:00:00 2001
From: lotte <lotte_hofstede@hotmail.com>
Date: Tue, 26 Mar 2019 09:36:07 +0100
Subject: [PATCH] Fixed issues when there are no values for a specific facet

---
 .../search-filters/search-filter/search-filter.component.html   | 2 +-
 .../search-filters/search-filter/search-filter.component.scss   | 2 +-
 .../search-filters/search-filter/search-filter.component.ts     | 1 -
 .../+search-page/search-filters/search-filters.component.html   | 2 +-
 src/app/shared/error/error.component.ts                         | 1 -
 5 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/app/+search-page/search-filters/search-filter/search-filter.component.html b/src/app/+search-page/search-filters/search-filter/search-filter.component.html
index e2c128593f..5c4db44d24 100644
--- a/src/app/+search-page/search-filters/search-filter/search-filter.component.html
+++ b/src/app/+search-page/search-filters/search-filter/search-filter.component.html
@@ -1,4 +1,4 @@
-<div *ngIf="active$ | async">
+<div class="facet-filter d-block mb-3 p-3" *ngIf="active$ | async">
     <div (click)="toggle()" class="filter-name"><h5 class="d-inline-block mb-0">{{'search.filters.filter.' + filter.name + '.head'| translate}}</h5> <span class="filter-toggle fas float-right"
                                                                       [ngClass]="(collapsed$ | async) ? 'fa-plus' : 'fa-minus'"></span></div>
     <div [@slide]="(collapsed$ | async) ? 'collapsed' : 'expanded'"  (@slide.start)="startSlide($event)" (@slide.done)="finishSlide($event)" class="search-filter-wrapper" [ngClass]="{'closed' : closed}">
diff --git a/src/app/+search-page/search-filters/search-filter/search-filter.component.scss b/src/app/+search-page/search-filters/search-filter/search-filter.component.scss
index 4e45f49468..1db5e9a1b2 100644
--- a/src/app/+search-page/search-filters/search-filter/search-filter.component.scss
+++ b/src/app/+search-page/search-filters/search-filter/search-filter.component.scss
@@ -1,7 +1,7 @@
 @import '../../../../styles/variables.scss';
 @import '../../../../styles/mixins.scss';
 
-:host {
+:host .facet-filter {
   border: 1px solid map-get($theme-colors, light);
   cursor: pointer;
   .search-filter-wrapper.closed {
diff --git a/src/app/+search-page/search-filters/search-filter/search-filter.component.ts b/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
index 3a5e4bfc55..14ba8f0b76 100644
--- a/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
+++ b/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
@@ -124,7 +124,6 @@ export class SearchFilterComponent implements OnInit {
           return observableOf(true);
         } else {
           return this.searchConfigService.searchOptions.pipe(
-            first(),
             switchMap((options) => {
                 return this.searchService.getFacetValuesFor(this.filter, 1, options).pipe(
                   filter((RD) => !RD.isLoading),
diff --git a/src/app/+search-page/search-filters/search-filters.component.html b/src/app/+search-page/search-filters/search-filters.component.html
index ab2a96d752..895765f6ac 100644
--- a/src/app/+search-page/search-filters/search-filters.component.html
+++ b/src/app/+search-page/search-filters/search-filters.component.html
@@ -1,7 +1,7 @@
 <h3>{{"search.filters.head" | translate}}</h3>
 <div *ngIf="(filters | async)?.hasSucceeded">
     <div *ngFor="let filter of (filters | async)?.payload; trackBy: trackUpdate">
-        <ds-search-filter class="d-block mb-3 p-3" [filter]="filter"></ds-search-filter>
+        <ds-search-filter [filter]="filter"></ds-search-filter>
     </div>
 </div>
 <a class="btn btn-primary" [routerLink]="[getSearchLink()]" [queryParams]="clearParams | async" queryParamsHandling="merge" role="button">{{"search.filters.reset" | translate}}</a>
\ No newline at end of file
diff --git a/src/app/shared/error/error.component.ts b/src/app/shared/error/error.component.ts
index 6900869183..bcb30c5fdc 100644
--- a/src/app/shared/error/error.component.ts
+++ b/src/app/shared/error/error.component.ts
@@ -32,5 +32,4 @@ export class ErrorComponent {
       this.subscription.unsubscribe();
     }
   }
-
 }