changes to address feedback

server.ts

@@ -118,11 +118,6 @@ export function app() {
    */
   server.use('/sitemap**', createProxyMiddleware({ target: `${environment.rest.baseUrl}/sitemaps`, changeOrigin: true }));
 
-  // TODO: implement data requests securely
-  server.get('/api/**', (req, res) => {
-    res.status(404).send('data requests are not yet supported');
-  });
-
   /**
    * Checks if the rateLimiter property is present
    * When it is present, the rateLimiter will be enabled. When it is undefined, the rateLimiter will be disabled.

src/app/+admin/admin-access-control/group-registry/group-form/group-form.component.ts

@@ -148,7 +148,6 @@ export class GroupFormComponent implements OnInit, OnDestroy {
     this.canEdit$ = this.groupDataService.getActiveGroup().pipe(
       hasValueOperator(),
       switchMap((group: Group) => {
-        console.log(group);
         return observableCombineLatest(
           this.authorizationService.isAuthorized(FeatureID.CanDelete, isNotEmpty(group) ? group.self : undefined),
           this.hasLinkedDSO(group),

src/app/core/services/hard-redirect.service.ts

@@ -5,7 +5,7 @@ import { URLCombiner } from '../url-combiner/url-combiner';
 /**
  * Service to take care of hard redirects
  */
-@Injectable({providedIn: 'root'})
+@Injectable()
 export abstract class HardRedirectService {
 
   /**

src/app/core/services/server-cookie.service.ts

@@ -2,7 +2,7 @@ import { Injectable } from '@angular/core';
 import { CookieAttributes } from 'js-cookie';
 import { CookieService, ICookieService } from './cookie.service';
 
-@Injectable({providedIn: 'root'})
+@Injectable()
 export class ServerCookieService extends CookieService implements ICookieService {
 
   public set(name: string, value: any, options?: CookieAttributes): void {

src/app/core/services/server-hard-redirect.service.ts

@@ -6,7 +6,7 @@ import { HardRedirectService } from './hard-redirect.service';
 /**
  * Service for performing hard redirects within the server app module
  */
-@Injectable({providedIn: 'root'})
+@Injectable()
 export class ServerHardRedirectService extends HardRedirectService {
 
   constructor(

src/app/shared/mocks/angulartics.service.mock.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@angular/core';
 
 /* tslint:disable:no-empty */
-@Injectable({providedIn: 'root'})
+@Injectable()
 export class AngularticsMock {
   public eventTrack(action, properties) { }
   public startTracking(): void {}

tsconfig.server.json

@@ -5,8 +5,7 @@
     "module": "commonjs"
   },
   "files": [
-    "src/main.server.ts",
+    "src/main.server.ts"
-    "server.ts"
   ],
   "angularCompilerOptions": {
     "entryModule": "./src/modules/app/server-app.module#ServerAppModule"