hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 01:54:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

71894: WIP: fix EditInPlace tests

Browse Source
This commit is contained in:
Marie Verdonck
2020-07-22 17:28:45 +02:00
parent 4a0444d669
commit 2ebb1640b4
4 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/+item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.html
View File

@@ -5,7 +5,7 @@
</div> </div>
<div *ngIf="(editable | async)" class="field-container"> <div *ngIf="(editable | async)" class="field-container">
<ds-filter-input-suggestions [suggestions]="(metadataFieldSuggestions | async)" <ds-filter-input-suggestions [suggestions]="(metadataFieldSuggestions | async)"
[(ngModel)]="metadata.key" [(ngModel)]="metadata.key"
(submitSuggestion)="update(suggestionControl)" (submitSuggestion)="update(suggestionControl)"
(clickSuggestion)="update(suggestionControl)" (clickSuggestion)="update(suggestionControl)"
(typeSuggestion)="update(suggestionControl)" (typeSuggestion)="update(suggestionControl)"
@@ -17,6 +17,8 @@
[ngModelOptions]="{standalone: true}" [ngModelOptions]="{standalone: true}"
></ds-filter-input-suggestions> ></ds-filter-input-suggestions>
</div> </div>
<small class="text-danger"
*ngIf="(valid | async) === false">{{"item.edit.metadata.metadatafield.invalid" | translate}}</small>
</div> </div>
</td> </td>
<td class="w-100"> <td class="w-100">

5
src/app/+item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.spec.ts
View File

@@ -17,6 +17,7 @@ import { MetadatumViewModel } from '../../../../core/shared/metadata.models';
import { InputSuggestion } from '../../../../shared/input-suggestions/input-suggestions.model'; import { InputSuggestion } from '../../../../shared/input-suggestions/input-suggestions.model';
import { SharedModule } from '../../../../shared/shared.module'; import { SharedModule } from '../../../../shared/shared.module';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils';
import { followLink } from '../../../../shared/utils/follow-link-config.model';
import { EditInPlaceFieldComponent } from './edit-in-place-field.component'; import { EditInPlaceFieldComponent } from './edit-in-place-field.component';
let comp: EditInPlaceFieldComponent; let comp: EditInPlaceFieldComponent;
@@ -57,7 +58,7 @@ const fieldUpdate = {
}; };
let scheduler: TestScheduler; let scheduler: TestScheduler;
fdescribe('EditInPlaceFieldComponent', () => { describe('EditInPlaceFieldComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
scheduler = getTestScheduler(); scheduler = getTestScheduler();
@@ -211,7 +212,7 @@ fdescribe('EditInPlaceFieldComponent', () => {
it('it should call queryMetadataFields on the metadataFieldService with the correct query', () => { it('it should call queryMetadataFields on the metadataFieldService with the correct query', () => {
expect(metadataFieldService.queryMetadataFields).toHaveBeenCalledWith(query); expect(metadataFieldService.queryMetadataFields).toHaveBeenCalledWith(query, null, followLink('schema'));
}); });
it('it should set metadataFieldSuggestions to the right value', () => { it('it should set metadataFieldSuggestions to the right value', () => {

1
src/app/shared/input-suggestions/filter-suggestions/filter-input-suggestions.component.html
View File

@@ -8,6 +8,7 @@
[ngClass]="{'is-invalid': !valid}" [ngClass]="{'is-invalid': !valid}"
[dsDebounce]="debounceTime" (onDebounce)="find($event)" [dsDebounce]="debounceTime" (onDebounce)="find($event)"
[placeholder]="placeholder" [placeholder]="placeholder"
ng-model-options="{standalone: true}"
autocomplete="off"> autocomplete="off">
<input type="submit" class="d-none"/> <input type="submit" class="d-none"/>
<small class="text-danger" <small class="text-danger"

2
src/app/shared/input-suggestions/filter-suggestions/filter-input-suggestions.component.ts
View File

@@ -37,7 +37,7 @@ export class FilterInputSuggestionsComponent extends InputSuggestionsComponent i
ngOnInit() { ngOnInit() {
this.form = new FormGroup({ this.form = new FormGroup({
metadataNameField: new FormControl('', { metadataNameField: new FormControl(this._value, {
asyncValidators: [this.metadataFieldValidator.validate.bind(this.metadataFieldValidator)], asyncValidators: [this.metadataFieldValidator.validate.bind(this.metadataFieldValidator)],
validators: [Validators.required] validators: [Validators.required]
}) })