diff --git a/src/app/submission/form/collection/submission-form-collection.component.ts b/src/app/submission/form/collection/submission-form-collection.component.ts
index ba7eb88c6f..f90814f185 100644
--- a/src/app/submission/form/collection/submission-form-collection.component.ts
+++ b/src/app/submission/form/collection/submission-form-collection.component.ts
@@ -28,6 +28,7 @@ import { CollectionDataService } from '../../../core/data/collection-data.servic
import { CollectionDropdownComponent } from '../../../shared/collection-dropdown/collection-dropdown.component';
import { SectionsService } from '../../sections/sections.service';
import { getFirstSucceededRemoteDataPayload } from '../../../core/shared/operators';
+import { SectionsType } from '../../sections/sections-type';
/**
* This component allows to show the current collection the submission belonging to and to change it.
@@ -142,7 +143,7 @@ export class SubmissionFormCollectionComponent implements OnChanges, OnInit {
*/
ngOnInit() {
this.pathCombiner = new JsonPatchOperationPathCombiner('sections', 'collection');
- this.available$ = this.sectionsService.isSectionAvailable(this.submissionId, 'collection');
+ this.available$ = this.sectionsService.isSectionTypeAvailable(this.submissionId, SectionsType.collection);
}
/**
diff --git a/src/app/submission/form/submission-form.component.html b/src/app/submission/form/submission-form.component.html
index 33b5d4be12..c86d4e0195 100644
--- a/src/app/submission/form/submission-form.component.html
+++ b/src/app/submission/form/submission-form.component.html
@@ -3,7 +3,6 @@
diff --git a/src/app/submission/form/submission-upload-files/submission-upload-files.component.ts b/src/app/submission/form/submission-upload-files/submission-upload-files.component.ts
index 2c348d2c87..e49127e80f 100644
--- a/src/app/submission/form/submission-upload-files/submission-upload-files.component.ts
+++ b/src/app/submission/form/submission-upload-files/submission-upload-files.component.ts
@@ -13,6 +13,7 @@ import { UploaderOptions } from '../../../shared/uploader/uploader-options.model
import parseSectionErrors from '../../utils/parseSectionErrors';
import { SubmissionJsonPatchOperationsService } from '../../../core/submission/submission-json-patch-operations.service';
import { WorkspaceItem } from '../../../core/submission/models/workspaceitem.model';
+import { SectionsType } from '../../sections/sections-type';
/**
* This component represents the drop zone that provides to add files to the submission.
@@ -35,12 +36,6 @@ export class SubmissionUploadFilesComponent implements OnChanges {
*/
@Input() submissionId: string;
- /**
- * The upload section id
- * @type {string}
- */
- @Input() sectionId: string;
-
/**
* The uploader configuration options
* @type {UploaderOptions}
@@ -110,7 +105,7 @@ export class SubmissionUploadFilesComponent implements OnChanges {
* Check if upload functionality is enabled
*/
ngOnChanges() {
- this.uploadEnabled = this.sectionService.isSectionAvailable(this.submissionId, this.sectionId);
+ this.uploadEnabled = this.sectionService.isSectionTypeAvailable(this.submissionId, SectionsType.Upload);
}
/**
@@ -136,14 +131,16 @@ export class SubmissionUploadFilesComponent implements OnChanges {
.forEach((sectionId) => {
const sectionData = normalizeSectionData(sections[sectionId]);
const sectionErrors = errorsList[sectionId];
- if (sectionId === 'upload') {
- // Look for errors on upload
- if ((isEmpty(sectionErrors))) {
- this.notificationsService.success(null, this.translate.get('submission.sections.upload.upload-successful'));
- } else {
- this.notificationsService.error(null, this.translate.get('submission.sections.upload.upload-failed'));
+ this.sectionService.isSectionType(this.submissionId, sectionId, SectionsType.Upload).subscribe((isUpload) => {
+ if (isUpload) {
+ // Look for errors on upload
+ if ((isEmpty(sectionErrors))) {
+ this.notificationsService.success(null, this.translate.get('submission.sections.upload.upload-successful'));
+ } else {
+ this.notificationsService.error(null, this.translate.get('submission.sections.upload.upload-failed'));
+ }
}
- }
+ });
this.sectionService.updateSectionData(this.submissionId, sectionId, sectionData, sectionErrors);
});
}
diff --git a/src/app/submission/sections/sections.service.ts b/src/app/submission/sections/sections.service.ts
index d8d1491cb7..afe5dde570 100644
--- a/src/app/submission/sections/sections.service.ts
+++ b/src/app/submission/sections/sections.service.ts
@@ -328,6 +328,22 @@ export class SectionsService {
distinctUntilChanged());
}
+ /**
+ * Check if given section id is of a given section type
+ * @param submissionId
+ * @param sectionId
+ * @param sectionType
+ */
+ public isSectionType(submissionId: string, sectionId: string, sectionType: SectionsType): Observable {
+ return this.store.select(submissionObjectFromIdSelector(submissionId)).pipe(
+ filter((submissionState: SubmissionObjectEntry) => isNotUndefined(submissionState)),
+ map((submissionState: SubmissionObjectEntry) => {
+ return isNotUndefined(submissionState.sections) && isNotUndefined(submissionState.sections[sectionId]
+ && submissionState.sections[sectionId].sectionType === sectionType );
+ }),
+ distinctUntilChanged());
+ }
+
/**
* Dispatch a new [EnableSectionAction] to add a new section and move page target to it
*