From 027182130544c0c76c995e84f0cf42a5e6c83e5b Mon Sep 17 00:00:00 2001 From: lotte Date: Tue, 14 Jan 2020 14:50:46 +0100 Subject: [PATCH 1/4] updated tslint rules that have been renamed --- tslint.json | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tslint.json b/tslint.json index b4f905d324..92bb66cee1 100644 --- a/tslint.json +++ b/tslint.json @@ -40,7 +40,7 @@ ], "no-access-missing-member": false, "no-arg": true, - "no-attribute-parameter-decorator": true, + "no-attribute-decorator": true, "no-bitwise": true, "no-console": [ true, @@ -81,9 +81,8 @@ false ], "prefer-const": true, - "pipe-naming": [ + "pipe-prefix": [ true, - "camelCase", "ds" ], "quotemark": [ @@ -147,10 +146,10 @@ "no-input-rename": true, "no-output-rename": true, "templates-use-public": false, - "use-host-property-decorator": true, - "use-input-property-decorator": true, + "no-host-metadata-property": true, + "no-inputs-metadata-property": true, "use-life-cycle-interface": false, - "use-output-property-decorator": true, + "no-outputs-metadata-property": true, "use-pipe-transform-interface": true // "rxjs-collapse-imports": true, // "rxjs-pipeable-operators-only": true, From 2e06357291fecb9453891f5e4b03ec46cb76f8ab Mon Sep 17 00:00:00 2001 From: Art Lowel Date: Wed, 15 Jan 2020 11:12:49 +0100 Subject: [PATCH 2/4] upgrade to bionic --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 901dee8186..4dd4943f7c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,5 +1,5 @@ sudo: required -dist: trusty +dist: bionic env: # Install the latest docker-compose version for ci testing. @@ -38,7 +38,6 @@ addons: sources: - google-chrome packages: - - dpkg - google-chrome-stable language: node_js From 1d6e9d5b96b7807cfbacd2f0f92acf6b18b2cb90 Mon Sep 17 00:00:00 2001 From: Art Lowel Date: Wed, 15 Jan 2020 11:32:29 +0100 Subject: [PATCH 3/4] add xvfb service for headless chrome --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 4dd4943f7c..9c80cc0447 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,6 +12,9 @@ env: DSPACE_REST_NAMESPACE: '/server/api' DSPACE_REST_SSL: false +services: + - xvfb + before_install: # Docker Compose Install - curl -L https://github.com/docker/compose/releases/download/${COMPOSE_VERSION}/docker-compose-`uname -s`-`uname -m` > docker-compose From 94a71b69d1022a0932f346e4216fe8f6db4faf5b Mon Sep 17 00:00:00 2001 From: Art Lowel Date: Wed, 15 Jan 2020 11:56:04 +0100 Subject: [PATCH 4/4] remove chrome source, doesn't work anyway and doesn't seem to be needed. Remove chromium to try to solve the issue where travis can't find chrome --- .travis.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index 9c80cc0447..c42923886d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,13 +36,6 @@ before_script: after_script: - docker-compose -f ./docker/docker-compose-travis.yml down -addons: - apt: - sources: - - google-chrome - packages: - - google-chrome-stable - language: node_js node_js: @@ -55,8 +48,6 @@ cache: bundler_args: --retry 5 script: - # Use Chromium instead of Chrome. - - export CHROME_BIN=chromium-browser - yarn run build - yarn run ci - cat coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js