From 3b9a334258bd247556d686766c8375d0392d342a Mon Sep 17 00:00:00 2001
From: Giuseppe Digilio <giuseppe.digilio@4science.it>
Date: Thu, 3 May 2018 14:40:34 +0200
Subject: [PATCH] Reduced use of own css

---
 src/app/+login-page/login-page.component.html   | 12 ++++++++----
 src/app/+login-page/login-page.component.scss   |  6 ++++++
 src/app/core/auth/auth.service.ts               |  1 +
 .../auth-nav-menu/auth-nav-menu.component.html  |  2 +-
 .../auth-nav-menu/auth-nav-menu.component.ts    | 13 +++++++++++--
 src/app/shared/log-in/log-in.component.html     |  4 ++--
 src/app/shared/log-in/log-in.component.scss     | 17 -----------------
 src/styles/_custom_variables.scss               |  2 ++
 8 files changed, 31 insertions(+), 26 deletions(-)

diff --git a/src/app/+login-page/login-page.component.html b/src/app/+login-page/login-page.component.html
index 76f4e68ef1..8ff87748ca 100644
--- a/src/app/+login-page/login-page.component.html
+++ b/src/app/+login-page/login-page.component.html
@@ -1,5 +1,9 @@
-<div class="text-center mt-5">
-  <img class="mb-4" src="assets/images/dspace-logo.png" alt="" width="72" height="72">
-  <h1 class="h3 mb-0 font-weight-normal">{{"login.form.header" | translate}}</h1>
-  <ds-log-in></ds-log-in>
+<div class="container">
+  <div class="text-center mt-5 row justify-content-md-center">
+    <div class="col-sm-6 col-md-4">
+      <img class="mb-4 login-logo" src="assets/images/dspace-logo.png">
+      <h1 class="h3 mb-0 font-weight-normal">{{"login.form.header" | translate}}</h1>
+      <ds-log-in></ds-log-in>
+    </div>
+  </div>
 </div>
diff --git a/src/app/+login-page/login-page.component.scss b/src/app/+login-page/login-page.component.scss
index e69de29bb2..38adf24671 100644
--- a/src/app/+login-page/login-page.component.scss
+++ b/src/app/+login-page/login-page.component.scss
@@ -0,0 +1,6 @@
+@import '../../styles/variables.scss';
+
+.login-logo {
+  height: $login-logo-height;
+  width: $login-logo-width;
+}
diff --git a/src/app/core/auth/auth.service.ts b/src/app/core/auth/auth.service.ts
index cd48d67ee8..58e80713e2 100644
--- a/src/app/core/auth/auth.service.ts
+++ b/src/app/core/auth/auth.service.ts
@@ -135,6 +135,7 @@ export class AuthService {
    */
   public checkAuthenticationToken(): Observable<AuthTokenInfo> {
     return this.store.select(getAuthenticationToken)
+      .take(1)
       .map((authTokenInfo: AuthTokenInfo) => {
         let token: AuthTokenInfo;
         // Retrieve authentication token info and check if is valid
diff --git a/src/app/shared/auth-nav-menu/auth-nav-menu.component.html b/src/app/shared/auth-nav-menu/auth-nav-menu.component.html
index e66e75be4c..7e60b789dd 100644
--- a/src/app/shared/auth-nav-menu/auth-nav-menu.component.html
+++ b/src/app/shared/auth-nav-menu/auth-nav-menu.component.html
@@ -2,7 +2,7 @@
   <li *ngIf="!(isAuthenticated | async) && !(windowService.isMobileView() | async) && showAuth" class="nav-item dropdown" (click)="$event.stopPropagation();">
     <div ngbDropdown placement="bottom-right" class="d-inline-block float-right" @fadeInOut>
       <a href="#" id="dropdownLogin" class="nav-link" (click)="$event.preventDefault()" ngbDropdownToggle><i class="fa fa-sign-in fa-fw" aria-hidden="true"></i> {{ 'nav.login' | translate }}<span class="caret"></span></a>
-      <div id="loginDropdownMenu" ngbDropdownMenu aria-labelledby="dropdownLogin">
+      <div id="loginDropdownMenu" [ngClass]="{'pl-3 pr-3': (loading | async)}" ngbDropdownMenu aria-labelledby="dropdownLogin">
         <ds-log-in></ds-log-in>
       </div>
     </div>
diff --git a/src/app/shared/auth-nav-menu/auth-nav-menu.component.ts b/src/app/shared/auth-nav-menu/auth-nav-menu.component.ts
index 3becbdbd91..c3246438c8 100644
--- a/src/app/shared/auth-nav-menu/auth-nav-menu.component.ts
+++ b/src/app/shared/auth-nav-menu/auth-nav-menu.component.ts
@@ -7,7 +7,7 @@ import { fadeInOut, fadeOut } from '../animations/fade';
 import { HostWindowService } from '../host-window.service';
 import { AppState, routerStateSelector } from '../../app.reducer';
 import { hasValue, isNotUndefined } from '../empty.util';
-import { getAuthenticatedUser, isAuthenticated } from '../../core/auth/selectors';
+import { getAuthenticatedUser, isAuthenticated, isAuthenticationLoading } from '../../core/auth/selectors';
 import { Subscription } from 'rxjs/Subscription';
 import { Eperson } from '../../core/eperson/models/eperson.model';
 
@@ -24,6 +24,12 @@ export class AuthNavMenuComponent implements OnDestroy, OnInit {
    */
   public isAuthenticated: Observable<boolean>;
 
+  /**
+   * True if the authentication is loading.
+   * @type {boolean}
+   */
+  public loading: Observable<boolean>;
+
   public showAuth = false;
 
   public user: Observable<Eperson>;
@@ -35,9 +41,12 @@ export class AuthNavMenuComponent implements OnDestroy, OnInit {
   }
 
   ngOnInit(): void {
-    // set loading
+    // set isAuthenticated
     this.isAuthenticated = this.store.select(isAuthenticated);
 
+    // set loading
+    this.loading = this.store.select(isAuthenticationLoading);
+
     this.user = this.store.select(getAuthenticatedUser);
 
     this.subs.push(this.store.select(routerStateSelector)
diff --git a/src/app/shared/log-in/log-in.component.html b/src/app/shared/log-in/log-in.component.html
index 0fe6c280de..bcb6b49c9e 100644
--- a/src/app/shared/log-in/log-in.component.html
+++ b/src/app/shared/log-in/log-in.component.html
@@ -4,7 +4,7 @@
   <input id="inputEmail"
          autocomplete="off"
          autofocus
-         class="form-control"
+         class="form-control form-control-lg position-relative"
          formControlName="email"
          placeholder="{{'login.form.email' | translate}}"
          required
@@ -12,7 +12,7 @@
   <label for="inputPassword" class="sr-only">{{"login.form.password" | translate}}</label>
   <input id="inputPassword"
          autocomplete="off"
-         class="form-control"
+         class="form-control form-control-lg position-relative"
          placeholder="{{'login.form.password' | translate}}"
          formControlName="password"
          required
diff --git a/src/app/shared/log-in/log-in.component.scss b/src/app/shared/log-in/log-in.component.scss
index e6226bc015..5e4393edaf 100644
--- a/src/app/shared/log-in/log-in.component.scss
+++ b/src/app/shared/log-in/log-in.component.scss
@@ -1,21 +1,5 @@
 @import '../../../styles/variables.scss';
 
-.form-login {
-  width: 100%;
-  max-width: 330px;
-  padding: 15px;
-  margin: 0 auto;
-}
-.form-login .checkbox {
-  font-weight: 400;
-}
-.form-login .form-control {
-  position: relative;
-  box-sizing: border-box;
-  height: auto;
-  padding: 10px;
-  font-size: 16px;
-}
 .form-login .form-control:focus {
   z-index: 2;
 }
@@ -25,7 +9,6 @@
   border-bottom-left-radius: 0;
 }
 .form-login input[type="password"] {
-  margin-bottom: 10px;
   border-top-left-radius: 0;
   border-top-right-radius: 0;
 }
diff --git a/src/styles/_custom_variables.scss b/src/styles/_custom_variables.scss
index 4dcc161cc4..d04e9e8c83 100644
--- a/src/styles/_custom_variables.scss
+++ b/src/styles/_custom_variables.scss
@@ -3,4 +3,6 @@ $content-spacing: $spacer * 1.5;
 $button-height: $input-btn-padding-y * 2 + $input-btn-line-height + calculateRem($input-btn-border-width*2);
 $card-height-percentage:98%;
 $card-thumbnail-height:240px;
+$login-logo-height:72px;
+$login-logo-width:72px;