hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 18:14:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

130484: Correctly update the 'showLoadMoreLink$' observable

Browse Source
This commit is contained in:
Andreas Awouters
2025-04-30 14:08:37 +02:00
parent d3b48f4ea4
commit 41afcf9cf6
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/app/item-page/edit-item-page/item-bitstreams/item-bitstreams.component.ts
View File

@@ -30,7 +30,6 @@ import {
map, map,
switchMap, switchMap,
take, take,
tap,
} from 'rxjs/operators'; } from 'rxjs/operators';
import { AlertComponent } from 'src/app/shared/alert/alert.component'; import { AlertComponent } from 'src/app/shared/alert/alert.component';
import { AlertType } from 'src/app/shared/alert/alert-type'; import { AlertType } from 'src/app/shared/alert/alert-type';
@@ -239,27 +238,30 @@ export class ItemBitstreamsComponent extends AbstractItemUpdateComponent impleme
this.itemService.getBundles(this.item.id, new PaginatedSearchOptions({ pagination: this.bundlesOptions })).pipe( this.itemService.getBundles(this.item.id, new PaginatedSearchOptions({ pagination: this.bundlesOptions })).pipe(
getFirstSucceededRemoteData(), getFirstSucceededRemoteData(),
getRemoteDataPayload(), getRemoteDataPayload(),
tap((bundlesPL: PaginatedList<Bundle>) => ).subscribe((bundles: PaginatedList<Bundle>) => {
this.showLoadMoreLink$.next(bundlesPL.pageInfo.currentPage < bundlesPL.pageInfo.totalPages), this.updateBundles(bundles);
),
map((bundlePage: PaginatedList<Bundle>) => bundlePage.page),
).subscribe((bundles: Bundle[]) => {
this.updateBundlesSubject(bundles);
}); });
} }
updateBundlesSubject(newBundles: Bundle[]) { /**
* Update the subject containing the bundles with the provided bundles.
* Also updates the showLoadMoreLink observable so it does not show up when it is no longer necessary.
*/
updateBundles(newBundlesPL: PaginatedList<Bundle>) {
const currentBundles = this.bundlesSubject.getValue(); const currentBundles = this.bundlesSubject.getValue();
const bundlesToAdd: Bundle[] = []; const bundlesToAdd: Bundle[] = [];
// Only add bundles to the bundle subject if they are not present yet // Only add bundles to the bundle subject if they are not present yet
newBundles.forEach(newBundle => { newBundlesPL.page.forEach(newBundle => {
if (!currentBundles.some(currentBundle => currentBundle.id === newBundle.id)) { if (!currentBundles.some(currentBundle => currentBundle.id === newBundle.id)) {
bundlesToAdd.push(newBundle); bundlesToAdd.push(newBundle);
} }
}); });
this.bundlesSubject.next([...currentBundles, ...bundlesToAdd]); const updatedBundles = [...currentBundles, ...bundlesToAdd];
this.showLoadMoreLink$.next(updatedBundles.length < newBundlesPL.totalElements);
this.bundlesSubject.next(updatedBundles);
} }