hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-08 10:34:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CST-3782] Fix issue with dispatchOperationsFromRemoveEvent method

Browse Source
This commit is contained in:
Giuseppe Digilio
2021-02-18 09:58:06 +01:00
parent 1901ace5a6
commit 42636c6f95
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/app/submission/sections/form/section-form-operations.service.spec.ts
View File

@@ -1,4 +1,4 @@
import { waitForAsync, TestBed } from '@angular/core/testing'; import { TestBed, waitForAsync } from '@angular/core/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core'; import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { import {
@@ -35,10 +35,10 @@ describe('SectionFormOperationsService test suite', () => {
let serviceAsAny: any; let serviceAsAny: any;
const jsonPatchOpBuilder: any = jasmine.createSpyObj('jsonPatchOpBuilder', { const jsonPatchOpBuilder: any = jasmine.createSpyObj('jsonPatchOpBuilder', {
add: jasmine.createSpy('add'), add: jasmine.createSpy('add'),
replace: jasmine.createSpy('replace'), replace: jasmine.createSpy('replace'),
remove: jasmine.createSpy('remove'), remove: jasmine.createSpy('remove'),
}); });
const pathCombiner = new JsonPatchOperationPathCombiner('sections', 'test'); const pathCombiner = new JsonPatchOperationPathCombiner('sections', 'test');
const dynamicFormControlChangeEvent: DynamicFormControlEvent = { const dynamicFormControlChangeEvent: DynamicFormControlEvent = {

3
src/app/submission/sections/form/section-form-operations.service.ts
View File

@@ -285,9 +285,10 @@ export class SectionFormOperationsService {
previousValue: FormFieldPreviousValueObject): void { previousValue: FormFieldPreviousValueObject): void {
const path = this.getFieldPathFromEvent(event); const path = this.getFieldPathFromEvent(event);
const value = this.getFieldValueFromChangeEvent(event); const value = this.getFieldValueFromChangeEvent(event);
console.log(value);
if (this.formBuilder.isQualdropGroup(event.model as DynamicFormControlModel)) { if (this.formBuilder.isQualdropGroup(event.model as DynamicFormControlModel)) {
this.dispatchOperationsFromMap(this.getQualdropValueMap(event), pathCombiner, event, previousValue); this.dispatchOperationsFromMap(this.getQualdropValueMap(event), pathCombiner, event, previousValue);
} else if (isNotEmpty(value) && (value instanceof FormFieldMetadataValueObject && value.hasValue())) { } else if ((isNotEmpty(value) && typeof value === 'string') || (isNotEmpty(value) && value instanceof FormFieldMetadataValueObject && value.hasValue())) {
this.operationsBuilder.remove(pathCombiner.getPath(path)); this.operationsBuilder.remove(pathCombiner.getPath(path));
} }
} }