[CST-4510] Address feedback

This commit is contained in:
Giuseppe Digilio
2021-10-15 10:25:30 +02:00
parent d08807544f
commit 4d277991ef
2 changed files with 5 additions and 5 deletions

View File

@@ -180,20 +180,20 @@ export class SubmissionImportExternalComponent implements OnInit, OnDestroy {
* Retrieve external source entries. * Retrieve external source entries.
*/ */
private retrieveExternalSources(): void { private retrieveExternalSources(): void {
/* if (hasValue(this.retrieveExternalSourcesSub)) { if (hasValue(this.retrieveExternalSourcesSub)) {
this.retrieveExternalSourcesSub.unsubscribe(); this.retrieveExternalSourcesSub.unsubscribe();
}*/ }
this.retrieveExternalSourcesSub = this.reload$.pipe( this.retrieveExternalSourcesSub = this.reload$.pipe(
filter((sourceQueryObject: ExternalSourceData) => isNotEmpty(sourceQueryObject.sourceId) && isNotEmpty(sourceQueryObject.query)), filter((sourceQueryObject: ExternalSourceData) => isNotEmpty(sourceQueryObject.sourceId) && isNotEmpty(sourceQueryObject.query)),
switchMap((sourceQueryObject: ExternalSourceData) => { switchMap((sourceQueryObject: ExternalSourceData) => {
const query = sourceQueryObject.query; const query = sourceQueryObject.query;
this.routeData = sourceQueryObject; this.routeData = sourceQueryObject;
return this.searchConfigService.paginatedSearchOptions.pipe( return this.searchConfigService.paginatedSearchOptions.pipe(
tap((v) => this.isLoading$.next(true)), tap(() => this.isLoading$.next(true)),
filter((searchOptions) => searchOptions.query === query), filter((searchOptions) => searchOptions.query === query),
mergeMap((searchOptions) => this.externalService.getExternalSourceEntries(this.routeData.sourceId, searchOptions).pipe( mergeMap((searchOptions) => this.externalService.getExternalSourceEntries(this.routeData.sourceId, searchOptions).pipe(
getFinishedRemoteData(), getFinishedRemoteData(),
)), ))
); );
} }
), ),

View File

@@ -2435,7 +2435,7 @@
"nav.user.description" : "User profile bar", "nav.user.description" : "User profile bar",
"none.listelement.badge": "Untyped", "none.listelement.badge": "Item",
"orgunit.listelement.badge": "Organizational Unit", "orgunit.listelement.badge": "Organizational Unit",