From 4de99ba19d51b3bdc57fbf93c0853bc0b8f33b5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Abel=20G=C3=B3mez?= Date: Thu, 4 Jul 2024 06:02:31 +0200 Subject: [PATCH] Refactor condition --- .../comcol-page-browse-by.component.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/app/shared/comcol/comcol-page-browse-by/comcol-page-browse-by.component.ts b/src/app/shared/comcol/comcol-page-browse-by/comcol-page-browse-by.component.ts index b0a3eafeb7..2a2489de05 100644 --- a/src/app/shared/comcol/comcol-page-browse-by/comcol-page-browse-by.component.ts +++ b/src/app/shared/comcol/comcol-page-browse-by/comcol-page-browse-by.component.ts @@ -144,12 +144,14 @@ export class ComcolPageBrowseByComponent implements OnDestroy, OnInit { distinctUntilChanged(), ), ]).subscribe(([navOptions, url]: [ComColPageNavOption[], string]) => { - for (const option of navOptions) { - if (url?.split('?')[0].endsWith(`/${this.id}`)) { - const option = navOptions.find(o => o.id === this.appConfig[this.contentType].defaultBrowseTab); - void this.router.navigate([option.routerLink], { queryParams: option.params }); - } else if (option.routerLink === url?.split('?')[0]) { - this.currentOption$.next(option); + if (url?.split('?')[0].endsWith(`/${this.id}`)) { + const option = navOptions.find(o => o.id === this.appConfig[this.contentType].defaultBrowseTab); + void this.router.navigate([option.routerLink], { queryParams: option.params }); + } else { + for (const option of navOptions) { + if (option.routerLink === url?.split('?')[0]) { + this.currentOption$.next(option); + } } } }));