58789: TSLint error fixing

src/app/+admin/admin-registries/admin-registries.module.ts

@@ -8,7 +8,7 @@ import { TranslateModule } from '@ngx-translate/core';
 import { BitstreamFormatsComponent } from './bitstream-formats/bitstream-formats.component';
 import { SharedModule } from '../../shared/shared.module';
 import { MetadataSchemaFormComponent } from './metadata-registry/metadata-schema-form/metadata-schema-form.component';
-import {MetadataFieldFormComponent} from "./metadata-schema/metadata-field-form/metadata-field-form.component";
+import {MetadataFieldFormComponent} from './metadata-schema/metadata-field-form/metadata-field-form.component';
 
 @NgModule({
   imports: [

src/app/+admin/admin-registries/metadata-registry/metadata-registry.actions.ts

@@ -1,7 +1,7 @@
 import { Action } from '@ngrx/store';
-import {type} from "../../../shared/ngrx/type";
-import {MetadataSchema} from "../../../core/metadata/metadataschema.model";
-import {MetadataField} from "../../../core/metadata/metadatafield.model";
+import { type } from '../../../shared/ngrx/type';
+import { MetadataSchema } from '../../../core/metadata/metadataschema.model';
+import { MetadataField } from '../../../core/metadata/metadatafield.model';
 
 /**
  * For each action type in an action group, make a simple

src/app/+admin/admin-registries/metadata-registry/metadata-registry.component.ts

@@ -5,9 +5,7 @@ import {RemoteData} from '../../../core/data/remote-data';
 import { PaginatedList } from '../../../core/data/paginated-list';
 import { MetadataSchema } from '../../../core/metadata/metadataschema.model';
 import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
-import {Store} from "@ngrx/store";
-import {AppState} from "../../../app.reducer";
-import {map} from "rxjs/operators";
+import { map } from 'rxjs/operators';
 
 @Component({
   selector: 'ds-metadata-registry',
@@ -41,7 +39,7 @@ export class MetadataRegistryComponent {
 
   isActive(schema: MetadataSchema): Observable<boolean> {
     return this.getActiveSchema().pipe(
-      map(activeSchema => schema === activeSchema)
+      map((activeSchema) => schema === activeSchema)
     );
   }
 
@@ -57,15 +55,15 @@ export class MetadataRegistryComponent {
 
   isSelected(schema: MetadataSchema): Observable<boolean> {
     return this.registryService.getSelectedMetadataSchemas().pipe(
-      map(schemas => schemas.find(selectedSchema => selectedSchema == schema) != null)
+      map((schemas) => schemas.find((selectedSchema) => selectedSchema === schema) != null)
     );
   }
 
   deleteSchemas() {
     this.registryService.getSelectedMetadataSchemas().subscribe(
-      schemas => {
-        console.log("metadata schemas to delete: ");
-        for (let schema of schemas) {
+      (schemas) => {
+        console.log('metadata schemas to delete: ');
+        for (const schema of schemas) {
           console.log(schema);
         }
       }

src/app/+admin/admin-registries/metadata-registry/metadata-registry.effects.ts

@@ -1,12 +1,12 @@
 /**
  * Makes sure that if the user navigates to another route, the sidebar is collapsed
  */
-import {Injectable} from "@angular/core";
-import {Actions, Effect, ofType} from "@ngrx/effects";
-import {filter, map, tap} from "rxjs/operators";
-import {SearchSidebarCollapseAction} from "../../../+search-page/search-sidebar/search-sidebar.actions";
+import { Injectable } from '@angular/core';
+import { Actions, Effect, ofType } from '@ngrx/effects';
+import { filter, map, tap } from 'rxjs/operators';
+import { SearchSidebarCollapseAction } from '../../../+search-page/search-sidebar/search-sidebar.actions';
 import * as fromRouter from '@ngrx/router-store';
-import {URLBaser} from "../../../core/url-baser/url-baser";
+import { URLBaser } from '../../../core/url-baser/url-baser';
 
 @Injectable()
 export class SearchSidebarEffects {

src/app/+admin/admin-registries/metadata-registry/metadata-registry.reducers.ts

@@ -1,4 +1,4 @@
-import {MetadataSchema} from "../../../core/metadata/metadataschema.model";
+import { MetadataSchema } from '../../../core/metadata/metadataschema.model';
 import {
   MetadataRegistryAction,
   MetadataRegistryActionTypes,
@@ -8,8 +8,8 @@ import {
   MetadataRegistryEditSchemaAction,
   MetadataRegistrySelectFieldAction,
   MetadataRegistrySelectSchemaAction
-} from "./metadata-registry.actions";
-import {MetadataField} from "../../../core/metadata/metadatafield.model";
+} from './metadata-registry.actions';
+import { MetadataField } from '../../../core/metadata/metadatafield.model';
 
 /**
  * The auth state.
@@ -57,7 +57,7 @@ export function metadataRegistryReducer(state = initialState, action: MetadataRe
     case MetadataRegistryActionTypes.DESELECT_SCHEMA: {
       return Object.assign({}, state, {
         selectedSchemas: state.selectedSchemas.filter(
-          selectedSchema => selectedSchema != (action as MetadataRegistryDeselectSchemaAction).schema
+          (selectedSchema) => selectedSchema !== (action as MetadataRegistryDeselectSchemaAction).schema
         )
       });
     }
@@ -83,7 +83,7 @@ export function metadataRegistryReducer(state = initialState, action: MetadataRe
     case MetadataRegistryActionTypes.DESELECT_FIELD: {
       return Object.assign({}, state, {
         selectedFields: state.selectedFields.filter(
-          selectedField => selectedField != (action as MetadataRegistryDeselectFieldAction).field
+          (selectedField) => selectedField !== (action as MetadataRegistryDeselectFieldAction).field
         )
       });
     }

src/app/+admin/admin-registries/metadata-registry/metadata-schema-form/metadata-schema-form.component.ts

@@ -4,23 +4,22 @@ import {
   DynamicFormGroupModel,
   DynamicFormLayout,
   DynamicInputModel
-} from "@ng-dynamic-forms/core";
-import {MetadataSchema} from "../../../../core/metadata/metadataschema.model";
-import {RegistryService} from "../../../../core/registry/registry.service";
-import {FormService} from "../../../../shared/form/form.service";
-import {FormBuilderService} from "../../../../shared/form/builder/form-builder.service";
-import {FormGroup} from "@angular/forms";
-import {Store} from "@ngrx/store";
-import {AppState} from "../../../../app.reducer";
+} from '@ng-dynamic-forms/core';
+import { FormGroup } from '@angular/forms';
+import { RegistryService } from '../../../../core/registry/registry.service';
+import { FormBuilderService } from '../../../../shared/form/builder/form-builder.service';
+import { FormService } from '../../../../shared/form/form.service';
+import { Store } from '@ngrx/store';
+import { AppState } from '../../../../app.reducer';
 
 @Component({
   selector: 'ds-metadata-schema-form',
   templateUrl: './metadata-schema-form.component.html',
-  styleUrls: ['./metadata-schema-form.component.css']
+  // styleUrls: ['./metadata-schema-form.component.css']
 })
 export class MetadataSchemaFormComponent implements OnInit {
 
-  formId: string = 'metadata-schema-form';
+  formId = 'metadata-schema-form';
 
   private name: DynamicInputModel = new DynamicInputModel({
     id: 'name',
@@ -28,7 +27,7 @@ export class MetadataSchemaFormComponent implements OnInit {
     name: 'name',
     validators: {
       required: null,
-      pattern: "^[^ ,_]{1,32}$"
+      pattern: '^[^ ,_]{1,32}$'
     },
     required: true,
   });
@@ -44,8 +43,8 @@ export class MetadataSchemaFormComponent implements OnInit {
 
   formModel: DynamicFormControlModel[] = [
     new DynamicFormGroupModel({
-      id: "schema",
-      legend: "schema",
+      id: 'schema',
+      legend: 'schema',
       group: [
         this.namespace,
         this.name
@@ -54,13 +53,13 @@ export class MetadataSchemaFormComponent implements OnInit {
   ];
 
   formLayout: DynamicFormLayout = {
-    "name": {
+    name: {
       grid: {
         control: 'col col-sm-5',
         label: 'col col-sm-5'
       }
     },
-    "namespace": {
+    namespace: {
       grid: {
         control: 'col col-sm-5',
         label: 'col col-sm-5'
@@ -78,11 +77,11 @@ export class MetadataSchemaFormComponent implements OnInit {
   ngOnInit() {
 
     this.formGroup = this.formBuilderService.createFormGroup(this.formModel);
-    this.registryService.getActiveMetadataSchema().subscribe(schema => {
+    this.registryService.getActiveMetadataSchema().subscribe((schema) => {
       this.formGroup.patchValue({
           schema: {
-            name: schema != null ? schema.prefix : "",
-            namespace: schema != null ? schema.namespace : ""
+            name: schema != null ? schema.prefix : '',
+            namespace: schema != null ? schema.namespace : ''
           }
         }
       );
@@ -95,16 +94,16 @@ export class MetadataSchemaFormComponent implements OnInit {
 
   onSubmit() {
     this.registryService.getActiveMetadataSchema().subscribe(
-      schema => {
+      (schema) => {
 
         if (schema == null) {
-          console.log("metadata field to create:");
-          console.log("prefix: " + this.name.value);
-          console.log("namespace: " + this.namespace.value);
+          console.log('metadata field to create:');
+          console.log('prefix: ' + this.name.value);
+          console.log('namespace: ' + this.namespace.value);
         } else {
-          console.log("metadata field to update:");
-          console.log("prefix: " + this.name.value);
-          console.log("namespace: " + this.namespace.value);
+          console.log('metadata field to update:');
+          console.log('prefix: ' + this.name.value);
+          console.log('namespace: ' + this.namespace.value);
         }
       }
     );

src/app/+admin/admin-registries/metadata-schema/metadata-field-form/metadata-field-form.component.ts

@@ -1,20 +1,20 @@
 import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
-import {DynamicFormControlModel, DynamicFormGroupModel, DynamicInputModel} from "@ng-dynamic-forms/core";
-import {RegistryService} from "../../../../core/registry/registry.service";
-import {MetadataSchema} from "../../../../core/metadata/metadataschema.model";
-import {FormGroup} from "@angular/forms";
-import {FormBuilderService} from "../../../../shared/form/builder/form-builder.service";
-import {Observable} from "rxjs";
-import {MetadataField} from "../../../../core/metadata/metadatafield.model";
+import { MetadataSchema } from '../../../../core/metadata/metadataschema.model';
+import { DynamicFormControlModel, DynamicFormGroupModel, DynamicInputModel } from '@ng-dynamic-forms/core';
+import { FormGroup } from '@angular/forms';
+import { RegistryService } from '../../../../core/registry/registry.service';
+import { FormBuilderService } from '../../../../shared/form/builder/form-builder.service';
+import { Observable } from 'rxjs/internal/Observable';
+import { MetadataField } from '../../../../core/metadata/metadatafield.model';
 
 @Component({
   selector: 'ds-metadata-field-form',
   templateUrl: './metadata-field-form.component.html',
-  styleUrls: ['./metadata-field-form.component.css']
+  // styleUrls: ['./metadata-field-form.component.css']
 })
 export class MetadataFieldFormComponent implements OnInit {
 
-  formId: string = 'metadata-field-form';
+  formId = 'metadata-field-form';
 
   @Input() metadataSchema: MetadataSchema;
 
@@ -42,8 +42,8 @@ export class MetadataFieldFormComponent implements OnInit {
 
   formModel: DynamicFormControlModel[] = [
     new DynamicFormGroupModel({
-      id: "field",
-      legend: "field",
+      id: 'field',
+      legend: 'field',
       group: [
         this.element,
         this.qualifier,
@@ -62,12 +62,12 @@ export class MetadataFieldFormComponent implements OnInit {
   ngOnInit() {
 
     this.formGroup = this.formBuilderService.createFormGroup(this.formModel);
-    this.registryService.getActiveMetadataField().subscribe(field => {
+    this.registryService.getActiveMetadataField().subscribe((field) => {
       this.formGroup.patchValue({
           field: {
-            element: field != null ? field.element : "",
-            qualifier: field != null ? field.qualifier : "",
-            scopeNote: field != null ? field.scopeNote : ""
+            element: field != null ? field.element : '',
+            qualifier: field != null ? field.qualifier : '',
+            scopeNote: field != null ? field.scopeNote : ''
           }
         }
       );
@@ -84,22 +84,26 @@ export class MetadataFieldFormComponent implements OnInit {
 
   onSubmit() {
     this.registryService.getActiveMetadataField().subscribe(
-      field => {
+      (field) => {
 
         if (field == null) {
-          console.log("metadata field to create:");
-          console.log("element: " + this.element.value);
-          if (this.qualifier.value)
-            console.log("qualifier: " + this.qualifier.value);
-          if (this.scopeNote.value)
-            console.log("scopeNote: " + this.scopeNote.value);
+          console.log('metadata field to create:');
+          console.log('element: ' + this.element.value);
+          if (this.qualifier.value) {
+            console.log('qualifier: ' + this.qualifier.value);
+          }
+          if (this.scopeNote.value) {
+            console.log('scopeNote: ' + this.scopeNote.value);
+          }
         } else {
-          console.log("metadata field to update:");
-          console.log("element: " + this.element.value);
-          if (this.qualifier.value)
-            console.log("qualifier: " + this.qualifier.value);
-          if (this.scopeNote.value)
-            console.log("scopeNote: " + this.scopeNote.value);
+          console.log('metadata field to update:');
+          console.log('element: ' + this.element.value);
+          if (this.qualifier.value) {
+            console.log('qualifier: ' + this.qualifier.value);
+          }
+          if (this.scopeNote.value) {
+            console.log('scopeNote: ' + this.scopeNote.value);
+          }
         }
       }
     );

src/app/+admin/admin-registries/metadata-schema/metadata-schema.component.ts

@@ -7,7 +7,7 @@ import {PaginatedList} from '../../../core/data/paginated-list';
 import { MetadataField } from '../../../core/metadata/metadatafield.model';
 import { MetadataSchema } from '../../../core/metadata/metadataschema.model';
 import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
-import {map} from "rxjs/operators";
+import { map } from 'rxjs/operators';
 
 @Component({
   selector: 'ds-metadata-schema',
@@ -59,7 +59,7 @@ export class MetadataSchemaComponent implements OnInit {
 
   isActive(field: MetadataField): Observable<boolean> {
     return this.getActiveField().pipe(
-      map(activeField => field === activeField)
+      map((activeField) => field === activeField)
     );
   }
 
@@ -75,15 +75,15 @@ export class MetadataSchemaComponent implements OnInit {
 
   isSelected(field: MetadataField): Observable<boolean> {
     return this.registryService.getSelectedMetadataFields().pipe(
-      map(fields => fields.find(selectedField => selectedField == field) != null)
+      map((fields) => fields.find((selectedField) => selectedField === field) != null)
     );
   }
 
   deleteFields() {
     this.registryService.getSelectedMetadataFields().subscribe(
-      fields => {
-        console.log("metadata fields to delete: ");
-        for (let field of fields) {
+      (fields) => {
+        console.log('metadata fields to delete: ');
+        for (const field of fields) {
           console.log(field);
         }
       }

src/app/+admin/admin-routing.module.ts

@@ -1,11 +1,15 @@
 import { RouterModule } from '@angular/router';
 import { NgModule } from '@angular/core';
-import {AuthenticatedGuard} from "../core/auth/authenticated.guard";
+import { AuthenticatedGuard } from '../core/auth/authenticated.guard';
 
 @NgModule({
   imports: [
     RouterModule.forChild([
-      { path: 'registries', loadChildren: './admin-registries/admin-registries.module#AdminRegistriesModule', canActivate: [AuthenticatedGuard] }
+      {
+        path: 'registries',
+        loadChildren: './admin-registries/admin-registries.module#AdminRegistriesModule',
+        canActivate: [AuthenticatedGuard]
+      }
     ])
   ]
 })

src/app/+community-page/community-page.component.ts

@@ -25,7 +25,6 @@ export class CommunityPageComponent implements OnInit, OnDestroy {
   communityRD$: Observable<RemoteData<Community>>;
   logoRD$: Observable<RemoteData<Bitstream>>;
 
-
   private subs: Subscription[] = [];
 
   constructor(
@@ -42,14 +41,9 @@ export class CommunityPageComponent implements OnInit, OnDestroy {
       map((rd: RemoteData<Community>) => rd.payload),
       filter((community: Community) => hasValue(community)),
       mergeMap((community: Community) => community.logo));
-
-
   }
 
   ngOnDestroy(): void {
     this.subs.filter((sub) => hasValue(sub)).forEach((sub) => sub.unsubscribe());
   }
-
-
-
 }

src/app/app.reducer.ts

@@ -17,7 +17,7 @@ import { truncatableReducer, TruncatablesState } from './shared/truncatable/trun
 import {
   metadataRegistryReducer,
   MetadataRegistryState
-} from "./+admin/admin-registries/metadata-registry/metadata-registry.reducers";
+} from './+admin/admin-registries/metadata-registry/metadata-registry.reducers';
 
 export interface AppState {
   router: fromRouter.RouterReducerState;

src/app/core/cache/models/normalized-object-factory.ts

@@ -10,7 +10,7 @@ import { NormalizedBitstreamFormat } from './normalized-bitstream-format.model';
 import { NormalizedResourcePolicy } from './normalized-resource-policy.model';
 import { NormalizedEPerson } from '../../eperson/models/normalized-eperson.model';
 import { NormalizedGroup } from '../../eperson/models/normalized-group.model';
-import {NormalizedMetadataSchema} from "../../metadata/normalized-metadata-schema.model";
+import { NormalizedMetadataSchema } from '../../metadata/normalized-metadata-schema.model';
 
 export class NormalizedObjectFactory {
   public static getConstructor(type: ResourceType): GenericConstructor<NormalizedObject> {

src/app/core/cache/response.models.ts

@@ -9,7 +9,7 @@ import {RegistryMetadataschemasResponse} from '../registry/registry-metadatasche
 import { RegistryMetadatafieldsResponse } from '../registry/registry-metadatafields-response.model';
 import { RegistryBitstreamformatsResponse } from '../registry/registry-bitstreamformats-response.model';
 import { AuthStatus } from '../auth/models/auth-status.model';
-import {MetadataSchema} from "../metadata/metadataschema.model";
+import { MetadataSchema } from '../metadata/metadataschema.model';
 
 /* tslint:disable:max-classes-per-file */
 export class RestResponse {

src/app/core/config/config.service.spec.ts

@@ -36,7 +36,6 @@ describe('ConfigService', () => {
   const scopedEndpoint = `${serviceEndpoint}/${scopeName}`;
   const searchEndpoint = `${serviceEndpoint}/${BROWSE}?uuid=${scopeID}`;
 
-
   function initTestService(): TestService {
     return new TestService(
       requestService,

src/app/core/data/metadata-schema-data.service.ts

@@ -1,23 +1,17 @@
-import {distinctUntilChanged, filter, map, tap} from 'rxjs/operators';
 import { Injectable } from '@angular/core';
 import { Store } from '@ngrx/store';
 import { Observable } from 'rxjs';
-import {isNotEmpty} from '../../shared/empty.util';
 import { BrowseService } from '../browse/browse.service';
 import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
 import { CoreState } from '../core.reducers';
-import {URLCombiner} from '../url-combiner/url-combiner';
 
 import { DataService } from './data.service';
 import { RequestService } from './request.service';
 import { HALEndpointService } from '../shared/hal-endpoint.service';
 import { FindAllOptions, GetRequest, RestRequest } from './request.models';
 import { ObjectCacheService } from '../cache/object-cache.service';
-import {MetadataSchema} from "../metadata/metadataschema.model";
-import {NormalizedMetadataSchema} from "../metadata/normalized-metadata-schema.model";
-import {GenericConstructor} from "../shared/generic-constructor";
-import {ResponseParsingService} from "./parsing.service";
-import {RegistryMetadatafieldsResponseParsingService} from "./registry-metadatafields-response-parsing.service";
+import { MetadataSchema } from '../metadata/metadataschema.model';
+import { NormalizedMetadataSchema } from '../metadata/normalized-metadata-schema.model';
 
 @Injectable()
 export class MetadataSchemaDataService extends DataService<NormalizedMetadataSchema, MetadataSchema> {

src/app/core/metadata/normalized-metadata-schema.model.ts

@@ -1,9 +1,9 @@
 import { autoserialize } from 'cerialize';
-import {NormalizedObject} from "../cache/models/normalized-object.model";
-import {mapsTo} from "../cache/builders/build-decorators";
-import {CacheableObject} from "../cache/object-cache.reducer";
-import {ListableObject} from "../../shared/object-collection/shared/listable-object.model";
-import {MetadataSchema} from "./metadataschema.model";
+import { NormalizedObject } from '../cache/models/normalized-object.model';
+import { mapsTo } from '../cache/builders/build-decorators';
+import { CacheableObject } from '../cache/object-cache.reducer';
+import { ListableObject } from '../../shared/object-collection/shared/listable-object.model';
+import { MetadataSchema } from './metadataschema.model';
 
 @mapsTo(MetadataSchema)
 export class NormalizedMetadataSchema extends NormalizedObject implements CacheableObject, ListableObject {

src/app/core/registry/registry.service.ts

@@ -27,9 +27,9 @@ import {PaginationComponentOptions} from '../../shared/pagination/pagination-com
 import { RegistryBitstreamformatsResponseParsingService } from '../data/registry-bitstreamformats-response-parsing.service';
 import { RegistryBitstreamformatsResponse } from './registry-bitstreamformats-response.model';
 import { getResponseFromEntry } from '../shared/operators';
-import {createSelector, select, Store} from "@ngrx/store";
-import {AppState} from "../../app.reducer";
-import {MetadataRegistryState} from "../../+admin/admin-registries/metadata-registry/metadata-registry.reducers";
+import { createSelector, select, Store } from '@ngrx/store';
+import { AppState } from '../../app.reducer';
+import { MetadataRegistryState } from '../../+admin/admin-registries/metadata-registry/metadata-registry.reducers';
 import {
   MetadataRegistryCancelFieldAction,
   MetadataRegistryCancelSchemaAction,
@@ -39,8 +39,8 @@ import {
   MetadataRegistryEditSchemaAction,
   MetadataRegistrySelectFieldAction,
   MetadataRegistrySelectSchemaAction
-} from "../../+admin/admin-registries/metadata-registry/metadata-registry.actions";
-import {flatMap, map, tap} from "rxjs/operators";
+} from '../../+admin/admin-registries/metadata-registry/metadata-registry.actions';
+import { flatMap, map, tap } from 'rxjs/operators';
 
 const metadataRegistryStateSelector = (state: AppState) => state.metadataRegistry;
 const editMetadataSchemaSelector = createSelector(metadataRegistryStateSelector, (metadataState: MetadataRegistryState) => metadataState.editSchema);
@@ -199,7 +199,7 @@ export class RegistryService {
   }
 
   private getMetadataFieldsBySchemaRequestObs(pagination: PaginationComponentOptions, schema: MetadataSchema): Observable<RestRequest> {
-    return this.halService.getEndpoint(this.metadataFieldsPath + "/search/bySchema").pipe(
+    return this.halService.getEndpoint(this.metadataFieldsPath + '/search/bySchema').pipe(
       // return this.halService.getEndpoint(this.metadataFieldsPath).pipe(
       map((url: string) => {
         const args: string[] = [];