From 532f4725b261ce4b60e3c3d24675f237ffe04dbd Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Mon, 20 Nov 2023 13:29:44 +0100 Subject: [PATCH] CST-12498 Final refactor --- .../ldn-service-form-edit.component.ts | 7 +++++-- .../ldn-service-form.component.ts | 3 ++- .../ldnServicesRD$-mock.ts | 2 +- .../ldn-services-directory.component.spec.ts | 5 +++-- .../ldn-services-directory.component.ts | 15 +++++++-------- 5 files changed, 18 insertions(+), 14 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts index a9659b4cce..b4ec221d5b 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts @@ -183,6 +183,7 @@ export class LdnServiceFormEditComponent implements OnInit { } + /** * Generates an array of patch operations based on form changes * @returns Array of patch operations @@ -253,6 +254,7 @@ export class LdnServiceFormEditComponent implements OnInit { patternArray.controls[index].patchValue({patternLabel: this.translateService.instant('ldn-service.form.pattern.' + patternValue + '.label')}) } + /** * Selects an outbound item filter by updating its value based on the provided filter value and index * @param filterValue - The selected filter value @@ -370,8 +372,8 @@ export class LdnServiceFormEditComponent implements OnInit { } /** - * Resets the form and navigates back to the LDN services page - */ + * Resets the form and navigates back to the LDN services page + */ resetFormAndLeave() { this.sendBack(); this.closeModal(); @@ -418,6 +420,7 @@ export class LdnServiceFormEditComponent implements OnInit { this.markedForDeletionOutboundPattern.splice(i, 1); } } + /** * Deletes marked inbound patterns from the form model */ diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts index 28aa6c4ef0..d903fec63e 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts @@ -137,7 +137,7 @@ export class LdnServiceFormComponent implements OnInit { } /** - * Handles the creation of an LDN service by validating form fields, + * Handles the creation of an LDN service by retrieving and validating form fields, * and submitting the form data to the LDN services endpoint. */ createService() { @@ -334,6 +334,7 @@ export class LdnServiceFormComponent implements OnInit { private sendBack() { this.router.navigateByUrl('admin/ldn/services'); } + /** * Creates a form group for an outbound pattern in the notifyServiceOutboundPatterns form array. * diff --git a/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts b/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts index 005bf0cf0d..bf40c34efe 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts @@ -84,7 +84,7 @@ export const mockLdnServices: LdnService[] = [{ get self(): string { return ""; }, -},{ +}, { uuid: "2", enabled: false, score: 0, diff --git a/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts b/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts index c5ec66c757..35bf3d598c 100644 --- a/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts +++ b/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts @@ -15,7 +15,7 @@ import {LdnServicesOverviewComponent} from './ldn-services-directory.component'; import {createSuccessfulRemoteDataObject$} from "../../../shared/remote-data.utils"; import {createPaginatedList} from "../../../shared/testing/utils.test"; -describe('LdnServicesOverviewComponent', ( ) => { +describe('LdnServicesOverviewComponent', () => { let component: LdnServicesOverviewComponent; let fixture: ComponentFixture; let ldnServicesService; @@ -45,7 +45,8 @@ describe('LdnServicesOverviewComponent', ( ) => { {provide: PaginationService, useValue: paginationService}, { provide: NgbModal, useValue: { - open: () => { /*comment*/} + open: () => { /*comment*/ + } } }, {provide: ChangeDetectorRef, useValue: {}}, diff --git a/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.ts b/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.ts index 12d196023e..826b4b4154 100644 --- a/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.ts @@ -27,7 +27,7 @@ import {TranslateService} from '@ngx-translate/core'; /** * The `LdnServicesOverviewComponent` is a component that provides an overview of LDN (Linked Data Notifications) services. * It displays a paginated list of LDN services, allows users to edit and delete services, - * toggle the status of each service directly form the page and allows for creation of new services redirecting the user on the creation form + * toggle the status of each service directly form the page and allows for creation of new services redirecting the user on the creation/edit form */ @Component({ selector: 'ds-ldn-services-directory', @@ -52,14 +52,13 @@ export class LdnServicesOverviewComponent implements OnInit, OnDestroy { modalRef: any; - constructor( - protected ldnServicesService: LdnServicesService, - protected paginationService: PaginationService, - protected modalService: NgbModal, - public cdRef: ChangeDetectorRef, - private notificationService: NotificationsService, - private translateService: TranslateService, + protected ldnServicesService: LdnServicesService, + protected paginationService: PaginationService, + protected modalService: NgbModal, + public cdRef: ChangeDetectorRef, + private notificationService: NotificationsService, + private translateService: TranslateService, ) { }