upgrade to angular 10 intermediate commit

e2e/tsconfig.json

@@ -8,7 +8,7 @@
     "moduleResolution": "node",
     "outDir": "../dist/out-tsc-e2e",
     "sourceMap": true,
-    "target": "es5",
+    "target": "es2018",
     "typeRoots": [
       "../node_modules/@types"
     ]

package.json

@@ -57,26 +57,26 @@
     "minimist": "^1.2.5"
   },
   "dependencies": {
-    "@angular/animations": "~9.1.12",
+    "@angular/animations": "~10.2.3",
-    "@angular/cdk": "8.2.3",
+    "@angular/cdk": "^10.2.6",
-    "@angular/common": "~9.1.12",
+    "@angular/common": "~10.2.3",
-    "@angular/compiler": "~9.1.12",
+    "@angular/compiler": "~10.2.3",
-    "@angular/core": "~9.1.12",
+    "@angular/core": "~10.2.3",
-    "@angular/forms": "~9.1.12",
+    "@angular/forms": "~10.2.3",
-    "@angular/localize": "9.1.12",
+    "@angular/localize": "10.2.3",
-    "@angular/platform-browser": "~9.1.12",
+    "@angular/platform-browser": "~10.2.3",
-    "@angular/platform-browser-dynamic": "~9.1.12",
+    "@angular/platform-browser-dynamic": "~10.2.3",
-    "@angular/platform-server": "~9.1.12",
+    "@angular/platform-server": "~10.2.3",
-    "@angular/router": "~9.1.12",
+    "@angular/router": "~10.2.3",
     "@angularclass/bootloader": "1.0.1",
     "@ng-bootstrap/ng-bootstrap": "6.2.0",
-    "@ng-dynamic-forms/core": "9.1.0",
+    "@ng-dynamic-forms/core": "^12.0.0",
-    "@ng-dynamic-forms/ui-ng-bootstrap": "9.1.0",
+    "@ng-dynamic-forms/ui-ng-bootstrap": "^12.0.0",
     "@ngrx/effects": "^9.2.0",
     "@ngrx/router-store": "^9.2.0",
     "@ngrx/store": "^9.2.0",
     "@nguniversal/express-engine": "9.1.1",
-    "@ngx-translate/core": "12.1.2",
+    "@ngx-translate/core": "^13.0.0",
     "@nicky-lenaers/ngx-scroll-to": "^9.0.0",
     "angular-idle-preload": "3.0.0",
     "angular2-text-mask": "9.0.0",
@@ -89,7 +89,7 @@
     "core-js": "^3.7.0",
     "debug-loader": "^0.0.1",
     "deepmerge": "^4.2.2",
-    "express": "4.17.1",
+    "express": "^4.17.1",
     "fast-json-patch": "^2.0.7",
     "file-saver": "^1.3.8",
     "filesize": "^6.1.0",
@@ -117,28 +117,28 @@
     "rxjs-spy": "^7.5.1",
     "sass-resources-loader": "^2.0.0",
     "sortablejs": "1.7.0",
-    "tslib": "^1.10.0",
+    "tslib": "^2.0.0",
     "webfontloader": "1.6.28",
-    "zone.js": "^0.10.3"
+    "zone.js": "^0.11.3"
   },
   "devDependencies": {
     "@angular-builders/custom-webpack": "9.2.0",
-    "@angular-devkit/build-angular": "~0.901.12",
+    "@angular-devkit/build-angular": "~0.1002.0",
-    "@angular/cli": "~9.1.12",
+    "@angular/cli": "~10.2.0",
-    "@angular/compiler-cli": "~9.1.12",
+    "@angular/compiler-cli": "~10.2.3",
-    "@angular/language-service": "~9.1.12",
+    "@angular/language-service": "~10.2.3",
     "@fortawesome/fontawesome-free": "^5.5.0",
     "@ngrx/store-devtools": "^9.2.0",
     "@ngtools/webpack": "9.1.12",
     "@types/deep-freeze": "0.1.1",
-    "@types/express": "4.17.9",
+    "@types/express": "^4.17.9",
     "@types/file-saver": "^1.3.0",
-    "@types/jasmine": "^3.3.9",
+    "@types/jasmine": "^3.6.2",
     "@types/jasminewd2": "~2.0.3",
     "@types/js-cookie": "2.1.0",
     "@types/lodash": "^4.14.110",
-    "@types/node": "^12.11.1",
+    "@types/node": "^14.14.9",
-    "codelyzer": "^5.1.2",
+    "codelyzer": "^6.0.1",
     "compression-webpack-plugin": "^3.0.1",
     "copy-webpack-plugin": "^5.1.1",
     "css-loader": "3.4.0",
@@ -148,14 +148,14 @@
     "fork-ts-checker-webpack-plugin": "^0.4.10",
     "html-webpack-plugin": "^3.2.0",
     "http-proxy-middleware": "^1.0.5",
-    "jasmine-core": "^3.3.0",
+    "jasmine-core": "^3.6.0",
     "jasmine-marbles": "0.3.1",
-    "jasmine-spec-reporter": "~4.2.1",
+    "jasmine-spec-reporter": "^6.0.0",
-    "karma": "^5.0.9",
+    "karma": "^5.2.3",
-    "karma-chrome-launcher": "~2.2.0",
+    "karma-chrome-launcher": "^3.1.0",
-    "karma-coverage-istanbul-reporter": "~2.0.1",
+    "karma-coverage-istanbul-reporter": "~3.0.2",
-    "karma-jasmine": "2.0.1",
+    "karma-jasmine": "^4.0.1",
-    "karma-jasmine-html-reporter": "^1.4.0",
+    "karma-jasmine-html-reporter": "^1.5.4",
     "karma-mocha-reporter": "2.2.5",
     "nodemon": "^2.0.2",
     "npm-run-all": "^4.1.5",
@@ -174,9 +174,9 @@
     "terser-webpack-plugin": "^2.3.1",
     "ts-loader": "^5.2.0",
     "ts-node": "^8.8.1",
-    "tslint": "~5.15.0",
+    "tslint": "^6.1.3",
-    "typescript": "~3.8.3",
+    "typescript": "~4.0.5",
-    "webpack": "^4.0.0",
+    "webpack": "^5.6.0",
     "webpack-bundle-analyzer": "^3.3.2",
     "webpack-cli": "^3.1.0",
     "webpack-node-externals": "1.7.2"

src/app/+workflowitems-edit-page/workflow-item-action-page.component.ts

@@ -1,4 +1,4 @@
-import { OnInit } from '@angular/core';
+import { OnInit, Directive } from '@angular/core';
 import { Observable } from 'rxjs';
 import { map, switchMap, take } from 'rxjs/operators';
 import { TranslateService } from '@ngx-translate/core';
@@ -15,6 +15,7 @@ import { isEmpty } from '../shared/empty.util';
 /**
  * Abstract component representing a page to perform an action on a workflow item
  */
+@Directive()
 export abstract class WorkflowItemActionPageComponent implements OnInit {
   public type;
   public wfi$: Observable<WorkflowItem>;

src/app/statistics-page/statistics-page/statistics-page.component.ts

@@ -1,4 +1,4 @@
-import { OnInit } from '@angular/core';
+import { OnInit, Directive } from '@angular/core';
 import { combineLatest, Observable } from 'rxjs';
 import { UsageReportService } from '../../core/statistics/usage-report-data.service';
 import { map, switchMap } from 'rxjs/operators';
@@ -12,6 +12,7 @@ import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
 /**
  * Class representing an abstract statistics page component.
  */
+@Directive()
 export abstract class StatisticsPageComponent<T extends DSpaceObject> implements OnInit {
 
   /**

src/app/submission/sections/models/section.model.ts

@@ -1,4 +1,4 @@
-import { Inject, OnDestroy, OnInit } from '@angular/core';
+import { Inject, OnDestroy, OnInit, Directive } from '@angular/core';
 
 import { Observable, Subscription } from 'rxjs';
 import { filter, startWith } from 'rxjs/operators';
@@ -14,6 +14,7 @@ export interface SectionDataModel {
 /**
  * An abstract model class for a submission edit form section.
  */
+@Directive()
 export abstract class SectionModelComponent implements OnDestroy, OnInit, SectionDataModel {
   protected abstract sectionService: SectionsService;
 

tsconfig.json

@@ -12,7 +12,7 @@
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "sourceMap": true,
-    "module": "esnext",
+    "module": "es2020",
     "moduleResolution": "node",
     "noEmitHelpers": true,
     "importHelpers": true,

tslint.json

@@ -20,6 +20,9 @@
     "curly": true,
     "eofline": true,
     "forin": true,
+    "deprecation": {
+      "severity": "warning"
+    },
     "import-blacklist": [
       true
     ],
@@ -70,7 +73,6 @@
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
-    "no-use-before-declare": false,
     "no-var-keyword": true,
     "no-var-requires": false,
     "object-literal-shorthand": false,