From ea726a7dba11a2852da5fed104b5d9a37184fb74 Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Thu, 2 Nov 2023 14:16:14 +0100 Subject: [PATCH 01/21] CST-12455 Moved patterns to be using i18n, added id to represent the string to send to the rest when doing operations --- .../ldn-service-form-edit.component.html | 4 +- .../ldn-service-form.component.html | 4 +- .../ldn-service-coar-patterns.ts | 137 +++++++++--------- src/assets/i18n/en.json5 | 53 +++++++ 4 files changed, 129 insertions(+), 69 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html index 568f3ed46f..8b086ceead 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html @@ -90,7 +90,7 @@ name="additionalInboundPattern{{i}}" required> + [ngValue]="pattern.id">{{ pattern.name | translate }} @@ -167,7 +167,7 @@ required> + [ngValue]="pattern.id">{{ pattern.name | translate }}
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html index f1afa886f1..23287ea671 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html @@ -81,7 +81,7 @@ name="additionalInboundPattern{{i}}" required> + [ngValue]="pattern.id">{{ pattern.name | translate }}
@@ -150,7 +150,7 @@ required> + [ngValue]="pattern.id ">{{ pattern.name | translate }}
diff --git a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts index 7b0c25e832..dca0fd8daf 100644 --- a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts +++ b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts @@ -1,69 +1,76 @@ export const notifyPatterns = [ - { - name: 'Acknowledge and Accept', - description: 'This pattern is used to acknowledge and accept a request (offer). It implies an intention to act on the request.', - category: 'Acknowledgements' - }, - { - name: 'Acknowledge and Reject', - description: 'This pattern is used to acknowledge and reject a request (offer). It signifies no further action regarding the request.', - category: 'Acknowledgements' - }, - { - name: 'Acknowledge and Tentatively Accept', - description: 'This pattern is used to acknowledge and tentatively accept a request (offer). It implies an intention to act, which may change.', - category: 'Acknowledgements' - }, - { - name: 'Acknowledge and Tentatively Reject', - description: 'This pattern is used to acknowledge and tentatively reject a request (offer). It signifies no further action, subject to change.', - category: 'Acknowledgements' - }, - { - name: 'Announce Endorsement', - description: 'This pattern is used to announce the existence of an endorsement, referencing the endorsed resource.', - category: 'Announcements' - }, - { - name: 'Announce Ingest', - description: 'This pattern is used to announce that a resource has been ingested.', - category: 'Announcements' - }, - { - name: 'Announce Relationship', - description: 'This pattern is used to announce a relationship between two resources.', - category: 'Announcements' - }, - { - name: 'Announce Review', - description: 'This pattern is used to announce the existence of a review, referencing the reviewed resource.', - category: 'Announcements' - }, - { - name: 'Announce Service Result', - description: 'This pattern is used to announce the existence of a "service result", referencing the relevant resource.', - category: 'Announcements' - }, - { - name: 'Request Endorsement', - description: 'This pattern is used to request endorsement of a resource owned by the origin system.', - category: 'Requests' - }, - { - name: 'Request Ingest', - description: 'This pattern is used to request that the target system ingest a resource.', - category: 'Requests' - }, - { - name: 'Request Review', - description: 'This pattern is used to request a review of a resource owned by the origin system.', - category: 'Requests' - }, - { - name: 'Undo Offer', - description: 'This pattern is used to undo (retract) an offer previously made.', - category: 'Undo' - } + { + id: 'ask-accept', + name: 'ldn-service.form.label.pattern.acknowledge-and-accept.name', + description: 'ldn-service.form.label.pattern.acknowledge-and-accept.description', + category: 'ldn-service.form.label.pattern.acknowledge-and-accept.category' + }, + { + id: 'ask-reject', + name: 'ldn-service.form.label.pattern.acknowledge-and-reject.name', + description: 'ldn-service.form.label.pattern.acknowledge-and-reject.description', + category: 'Acknowledgements' + }, + { + id: 'ask-tentative', + name: 'ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.name', + description: 'ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.description', + category: 'Acknowledgements' + }, + { + id: 'announce-endorsement', + name: 'ldn-service.form.label.pattern.announce-endorsement.name', + description: 'ldn-service.form.label.pattern.announce-endorsement.description', + category: 'Announcements' + }, + { + id: 'announce-ingest', + name: 'ldn-service.form.label.pattern.announce-ingest.name', + description: 'ldn-service.form.label.pattern.announce-ingest.description', + category: 'Announcements' + }, + { + id: 'announce-relationship', + name: 'ldn-service.form.label.pattern.announce-relationship.name', + description: 'ldn-service.form.label.pattern.announce-relationship.description', + category: 'Announcements' + }, + { + id: 'announce-review', + name: 'ldn-service.form.label.pattern.announce-review.name', + description: 'ldn-service.form.label.pattern.announce-review.description', + category: 'Announcements' + }, + { + id: 'announce-service-result', + name: 'ldn-service.form.label.pattern.announce-service-result.name', + description: 'ldn-service.form.label.pattern.announce-service-result.description', + category: 'Announcements' + }, + { + id: 'request-endorsement', + name: 'ldn-service.form.label.pattern.request-endorsement.name', + description: 'ldn-service.form.label.pattern.request-endorsement.description', + category: 'Requests' + }, + { + id: 'request-ingest', + name: 'ldn-service.form.label.pattern.request-ingest.name', + description: 'ldn-service.form.label.pattern.request-ingest.description', + category: 'Requests' + }, + { + id: 'request-review', + name: 'ldn-service.form.label.pattern.request-review.name', + description: 'ldn-service.form.label.pattern.request-review.description', + category: 'Requests' + }, + { + id: 'undo', + name: 'ldn-service.form.label.pattern.undo-offer.name', + description: 'ldn-service.form.label.pattern.undo-offer.description', + category: 'Undo' + } ]; diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5 index 108433de21..7cda0e603b 100644 --- a/src/assets/i18n/en.json5 +++ b/src/assets/i18n/en.json5 @@ -936,6 +936,59 @@ "ldn-new-service.form.placeholder.ldnUrl": "Please specify the URL of the LDN Inbox", "ldn-new-service.form.label.inboundPattern": "Inbound Patterns", "ldn-new-service.form.label.placeholder.inboundPattern": "Select an Inbound Pattern", + + "ldn-service.form.label.pattern.acknowledge-and-accept.name": "Acknowledge and Accept", + "ldn-service.form.label.pattern.acknowledge-and-accept.description": "This pattern is used to acknowledge and accept a request (offer). It implies an intention to act on the request.", + "ldn-service.form.label.pattern.acknowledge-and-accept.category": "Acknowledgements", + + "ldn-service.form.label.pattern.acknowledge-and-reject.name": "Acknowledge and Reject", + "ldn-service.form.label.pattern.acknowledge-and-reject.description": "This pattern is used to acknowledge and reject a request (offer). It signifies no further action regarding the request.", + "ldn-service.form.label.pattern.acknowledge-and-reject.category": "Acknowledgements", + + "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.name": "Acknowledge and Tentatively Accept", + "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.description": "This pattern is used to acknowledge and tentatively accept a request (offer). It implies an intention to act, which may change.", + "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.category": "Acknowledgements", + + "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.name": "Acknowledge and Tentatively Reject", + "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.description": "This pattern is used to acknowledge and tentatively reject a request (offer). It signifies no further action, subject to change.", + "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.category": "Acknowledgements", + + "ldn-service.form.label.pattern.announce-endorsement.name": "Announce Endorsement", + "ldn-service.form.label.pattern.announce-endorsement.description": "This pattern is used to announce the existence of an endorsement, referencing the endorsed resource.", + "ldn-service.form.label.pattern.announce-endorsement.category": "Announcements", + + "ldn-service.form.label.pattern.announce-ingest.name": "Announce Ingest", + "ldn-service.form.label.pattern.announce-ingest.description": "This pattern is used to announce that a resource has been ingested.", + "ldn-service.form.label.pattern.announce-ingest.category": "Announcements", + + "ldn-service.form.label.pattern.announce-relationship.name": "Announce Relationship", + "ldn-service.form.label.pattern.announce-relationship.description": "This pattern is used to announce a relationship between two resources.", + "ldn-service.form.label.pattern.announce-relationship.category": "Announcements", + + "ldn-service.form.label.pattern.announce-review.name": "Announce Review", + "ldn-service.form.label.pattern.announce-review.description": "This pattern is used to announce the existence of a review, referencing the reviewed resource.", + "ldn-service.form.label.pattern.announce-review.category": "Announcements", + + "ldn-service.form.label.pattern.announce-service-result.name": "Announce Service Result", + "ldn-service.form.label.pattern.announce-service-result.description": "This pattern is used to announce the existence of a 'service result', referencing the relevant resource.", + "ldn-service.form.label.pattern.announce-service-result.category": "Announcements", + + "ldn-service.form.label.pattern.request-endorsement.name": "Request Endorsement", + "ldn-service.form.label.pattern.request-endorsement.description": "This pattern is used to request endorsement of a resource owned by the origin system.", + "ldn-service.form.label.pattern.request-endorsement.category": "Requests", + + "ldn-service.form.label.pattern.request-ingest.name": "Request Ingest", + "ldn-service.form.label.pattern.request-ingest.description": "This pattern is used to request that the target system ingest a resource.", + "ldn-service.form.label.pattern.request-ingest.category": "Requests", + + "ldn-service.form.label.pattern.request-review.name": "Request Review", + "ldn-service.form.label.pattern.request-review.description": "This pattern is used to request a review of a resource owned by the origin system.", + "ldn-service.form.label.pattern.request-review.category": "Requests", + + "ldn-service.form.label.pattern.undo-offer.name": "Undo Offer", + "ldn-service.form.label.pattern.undo-offer.description": "This pattern is used to undo (retract) an offer previously made.", + "ldn-service.form.label.pattern.undo-offer.category": "Undo", + "ldn-new-service.form.label.placeholder.selectedItemFilter": "No Item Filter Selected", "ldn-new-service.form.label.ItemFilter": "Item Filter", "ldn-new-service.form.label.automatic": "Automatic", From 92330953bff4b2d57278d0e6b192cf8e86490633 Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Fri, 10 Nov 2023 10:04:32 +0100 Subject: [PATCH 02/21] CST-12455 Provided json5 key values based on the string arrays --- .../ldn-service-form-edit.component.html | 4 +- .../ldn-service-form-edit.component.ts | 4 +- .../ldn-service-form.component.html | 4 +- .../ldn-service-form.component.ts | 7 +- .../ldn-service-coar-patterns.ts | 150 +++++++++--------- src/assets/i18n/en.json5 | 78 ++++----- 6 files changed, 128 insertions(+), 119 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html index 8b086ceead..56105ce805 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html @@ -90,7 +90,7 @@ name="additionalInboundPattern{{i}}" required> + [value]="pattern">{{ 'ldn-service.form.pattern.'+pattern+'.label' | translate }}
@@ -167,7 +167,7 @@ required> + [value]="pattern">{{ 'ldn-service.form.pattern.'+pattern+'.label' | translate }}
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts index fa460afbca..f0422e39e4 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts @@ -37,8 +37,8 @@ export class LdnServiceFormEditComponent implements OnInit { @ViewChild('confirmModal', {static: true}) confirmModal: TemplateRef; @ViewChild('resetFormModal', {static: true}) resetFormModal: TemplateRef; - public inboundPatterns: object[] = notifyPatterns; - public outboundPatterns: object[] = notifyPatterns; + public inboundPatterns: string[] = notifyPatterns; + public outboundPatterns: string[] = notifyPatterns; itemfiltersRD$: Observable>>; config: FindListOptions = Object.assign(new FindListOptions(), { elementsPerPage: 20 diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html index 23287ea671..1b4aa9048d 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html @@ -81,7 +81,7 @@ name="additionalInboundPattern{{i}}" required> + [value]="pattern">{{ 'ldn-service.form.pattern.'+pattern+'.label' | translate }}
@@ -150,7 +150,7 @@ required> + [value]="pattern">{{ 'ldn-service.form.pattern.'+pattern+'.label' | translate }}
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts index a2c4919a4d..0ddefcd82e 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.ts @@ -45,8 +45,10 @@ export class LdnServiceFormComponent implements OnInit { formModel: FormGroup; @ViewChild('confirmModal', {static: true}) confirmModal: TemplateRef; @ViewChild('resetFormModal', {static: true}) resetFormModal: TemplateRef; - public inboundPatterns: object[] = notifyPatterns; - public outboundPatterns: object[] = notifyPatterns; + //public inboundPatterns: object[] = notifyPatterns; + //public outboundPatterns: object[] = notifyPatterns; + public inboundPatterns: string[] = notifyPatterns; + public outboundPatterns: string[] = notifyPatterns; itemfiltersRD$: Observable>>; config: FindListOptions = Object.assign(new FindListOptions(), { elementsPerPage: 20 @@ -96,6 +98,7 @@ export class LdnServiceFormComponent implements OnInit { } ngOnInit(): void { + console.log(notifyPatterns) this.setItemfilters(); } diff --git a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts index dca0fd8daf..a882d5db11 100644 --- a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts +++ b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts @@ -1,76 +1,82 @@ export const notifyPatterns = [ - { - id: 'ask-accept', - name: 'ldn-service.form.label.pattern.acknowledge-and-accept.name', - description: 'ldn-service.form.label.pattern.acknowledge-and-accept.description', - category: 'ldn-service.form.label.pattern.acknowledge-and-accept.category' - }, - { - id: 'ask-reject', - name: 'ldn-service.form.label.pattern.acknowledge-and-reject.name', - description: 'ldn-service.form.label.pattern.acknowledge-and-reject.description', - category: 'Acknowledgements' - }, - { - id: 'ask-tentative', - name: 'ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.name', - description: 'ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.description', - category: 'Acknowledgements' - }, - { - id: 'announce-endorsement', - name: 'ldn-service.form.label.pattern.announce-endorsement.name', - description: 'ldn-service.form.label.pattern.announce-endorsement.description', - category: 'Announcements' - }, - { - id: 'announce-ingest', - name: 'ldn-service.form.label.pattern.announce-ingest.name', - description: 'ldn-service.form.label.pattern.announce-ingest.description', - category: 'Announcements' - }, - { - id: 'announce-relationship', - name: 'ldn-service.form.label.pattern.announce-relationship.name', - description: 'ldn-service.form.label.pattern.announce-relationship.description', - category: 'Announcements' - }, - { - id: 'announce-review', - name: 'ldn-service.form.label.pattern.announce-review.name', - description: 'ldn-service.form.label.pattern.announce-review.description', - category: 'Announcements' - }, - { - id: 'announce-service-result', - name: 'ldn-service.form.label.pattern.announce-service-result.name', - description: 'ldn-service.form.label.pattern.announce-service-result.description', - category: 'Announcements' - }, - { - id: 'request-endorsement', - name: 'ldn-service.form.label.pattern.request-endorsement.name', - description: 'ldn-service.form.label.pattern.request-endorsement.description', - category: 'Requests' - }, - { - id: 'request-ingest', - name: 'ldn-service.form.label.pattern.request-ingest.name', - description: 'ldn-service.form.label.pattern.request-ingest.description', - category: 'Requests' - }, - { - id: 'request-review', - name: 'ldn-service.form.label.pattern.request-review.name', - description: 'ldn-service.form.label.pattern.request-review.description', - category: 'Requests' - }, - { - id: 'undo', - name: 'ldn-service.form.label.pattern.undo-offer.name', - description: 'ldn-service.form.label.pattern.undo-offer.description', - category: 'Undo' - } + //{ + 'ack-accept', + //name: 'ldn-service.form.pattern.acknowledge-and-accept.label', + //description: 'ldn-service.form.pattern.acknowledge-and-accept.description', + //category: 'ldn-service.form.pattern.acknowledge-and-accept.category' + //}, + //{ + 'ack-reject', + //name: 'ldn-service.form.pattern.acknowledge-and-reject.label', + //description: 'ldn-service.form.pattern.acknowledge-and-reject.description', + //category: 'ldn-service.form.pattern.acknowledge-and-reject.category' + //}, + //{ + 'ack-tentative-accept', + //name: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.label', + //description: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.description', + //category: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.category' + //}, + //{ + 'ack-tentative-reject', + //name: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.label', + //description: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.description', + //category: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.category' + //}, + //{ + 'announce-endorsement', + //name: 'ldn-service.form.pattern.announce-endorsement.label', + //description: 'ldn-service.form.pattern.announce-endorsement.description', + //category: 'ldn-service.form.pattern.announce-endorsement.category' + //}, + //{ + 'announce-ingest', + //name: 'ldn-service.form.pattern.announce-ingest.label', + //description: 'ldn-service.form.pattern.announce-ingest.description', + //category: 'ldn-service.form.pattern.announce-ingest.category' + //}, + //{ + 'announce-relationship', + //name: 'ldn-service.form.pattern.announce-relationship.label', + //description: 'ldn-service.form.pattern.announce-relationship.description', + //category: 'ldn-service.form.pattern.announce-relationship.category' + //}, + //{ + 'announce-review', + //name: 'ldn-service.form.pattern.announce-review.label', + //description: 'ldn-service.form.pattern.announce-review.description', + //category: 'ldn-service.form.pattern.announce-review.category' + //}, + //{ + 'announce-service-result', + //name: 'ldn-service.form.pattern.announce-service-result.label', + //description: 'ldn-service.form.pattern.announce-service-result.description', + //category: 'ldn-service.form.pattern.announce-service-result.category' + //}, + //{ + 'request-endorsement', + //name: 'ldn-service.form.pattern.request-endorsement.label', + //description: 'ldn-service.form.pattern.request-endorsement.description', + //category: 'ldn-service.form.pattern.request-endorsement.category' + //}, + //{ + 'request-ingest', + //name: 'ldn-service.form.pattern.request-ingest.label', + //description: 'ldn-service.form.pattern.request-ingest.description', + //category: 'ldn-service.form.pattern.request-ingest.category' + //}, + //{ + 'request-review', + //name: 'ldn-service.form.pattern.request-review.label', + //description: 'ldn-service.form.pattern.request-review.description', + //category: 'ldn-service.form.pattern.request-review.category' + //}, + //{ + 'undo-offer', + //name: 'ldn-service.form.pattern.undo-offer.label', + //description: 'ldn-service.form.pattern.undo-offer.description', + //category: 'ldn-service.form.pattern.undo-offer.category' + //} ]; diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5 index 7cda0e603b..81562814d4 100644 --- a/src/assets/i18n/en.json5 +++ b/src/assets/i18n/en.json5 @@ -937,57 +937,57 @@ "ldn-new-service.form.label.inboundPattern": "Inbound Patterns", "ldn-new-service.form.label.placeholder.inboundPattern": "Select an Inbound Pattern", - "ldn-service.form.label.pattern.acknowledge-and-accept.name": "Acknowledge and Accept", - "ldn-service.form.label.pattern.acknowledge-and-accept.description": "This pattern is used to acknowledge and accept a request (offer). It implies an intention to act on the request.", - "ldn-service.form.label.pattern.acknowledge-and-accept.category": "Acknowledgements", + "ldn-service.form.pattern.ack-accept.label": "Acknowledge and Accept", + "ldn-service.form.pattern.ack-accept.description": "This pattern is used to acknowledge and accept a request (offer). It implies an intention to act on the request.", + "ldn-service.form.pattern.ack-accept.category": "Acknowledgements", - "ldn-service.form.label.pattern.acknowledge-and-reject.name": "Acknowledge and Reject", - "ldn-service.form.label.pattern.acknowledge-and-reject.description": "This pattern is used to acknowledge and reject a request (offer). It signifies no further action regarding the request.", - "ldn-service.form.label.pattern.acknowledge-and-reject.category": "Acknowledgements", + "ldn-service.form.pattern.ack-reject.label": "Acknowledge and Reject", + "ldn-service.form.pattern.ack-reject.description": "This pattern is used to acknowledge and reject a request (offer). It signifies no further action regarding the request.", + "ldn-service.form.pattern.ack-reject.category": "Acknowledgements", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.name": "Acknowledge and Tentatively Accept", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.description": "This pattern is used to acknowledge and tentatively accept a request (offer). It implies an intention to act, which may change.", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-accept.category": "Acknowledgements", + "ldn-service.form.pattern.ack-tentative-accept.label": "Acknowledge and Tentatively Accept", + "ldn-service.form.pattern.ack-tentative-accept.description": "This pattern is used to acknowledge and tentatively accept a request (offer). It implies an intention to act, which may change.", + "ldn-service.form.pattern.ack-tentative-accept.category": "Acknowledgements", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.name": "Acknowledge and Tentatively Reject", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.description": "This pattern is used to acknowledge and tentatively reject a request (offer). It signifies no further action, subject to change.", - "ldn-service.form.label.pattern.acknowledge-and-tentatively-reject.category": "Acknowledgements", + "ldn-service.form.pattern.ack-tentative-reject.label": "Acknowledge and Tentatively Reject", + "ldn-service.form.pattern.ack-tentative-reject.description": "This pattern is used to acknowledge and tentatively reject a request (offer). It signifies no further action, subject to change.", + "ldn-service.form.pattern.ack-tentative-reject.category": "Acknowledgements", - "ldn-service.form.label.pattern.announce-endorsement.name": "Announce Endorsement", - "ldn-service.form.label.pattern.announce-endorsement.description": "This pattern is used to announce the existence of an endorsement, referencing the endorsed resource.", - "ldn-service.form.label.pattern.announce-endorsement.category": "Announcements", + "ldn-service.form.pattern.announce-endorsement.label": "Announce Endorsement", + "ldn-service.form.pattern.announce-endorsement.description": "This pattern is used to announce the existence of an endorsement, referencing the endorsed resource.", + "ldn-service.form.pattern.announce-endorsement.category": "Announcements", - "ldn-service.form.label.pattern.announce-ingest.name": "Announce Ingest", - "ldn-service.form.label.pattern.announce-ingest.description": "This pattern is used to announce that a resource has been ingested.", - "ldn-service.form.label.pattern.announce-ingest.category": "Announcements", + "ldn-service.form.pattern.announce-ingest.label": "Announce Ingest", + "ldn-service.form.pattern.announce-ingest.description": "This pattern is used to announce that a resource has been ingested.", + "ldn-service.form.pattern.announce-ingest.category": "Announcements", - "ldn-service.form.label.pattern.announce-relationship.name": "Announce Relationship", - "ldn-service.form.label.pattern.announce-relationship.description": "This pattern is used to announce a relationship between two resources.", - "ldn-service.form.label.pattern.announce-relationship.category": "Announcements", + "ldn-service.form.pattern.announce-relationship.label": "Announce Relationship", + "ldn-service.form.pattern.announce-relationship.description": "This pattern is used to announce a relationship between two resources.", + "ldn-service.form.pattern.announce-relationship.category": "Announcements", - "ldn-service.form.label.pattern.announce-review.name": "Announce Review", - "ldn-service.form.label.pattern.announce-review.description": "This pattern is used to announce the existence of a review, referencing the reviewed resource.", - "ldn-service.form.label.pattern.announce-review.category": "Announcements", + "ldn-service.form.pattern.announce-review.label": "Announce Review", + "ldn-service.form.pattern.announce-review.description": "This pattern is used to announce the existence of a review, referencing the reviewed resource.", + "ldn-service.form.pattern.announce-review.category": "Announcements", - "ldn-service.form.label.pattern.announce-service-result.name": "Announce Service Result", - "ldn-service.form.label.pattern.announce-service-result.description": "This pattern is used to announce the existence of a 'service result', referencing the relevant resource.", - "ldn-service.form.label.pattern.announce-service-result.category": "Announcements", + "ldn-service.form.pattern.announce-service-result.label": "Announce Service Result", + "ldn-service.form.pattern.announce-service-result.description": "This pattern is used to announce the existence of a 'service result', referencing the relevant resource.", + "ldn-service.form.pattern.announce-service-result.category": "Announcements", - "ldn-service.form.label.pattern.request-endorsement.name": "Request Endorsement", - "ldn-service.form.label.pattern.request-endorsement.description": "This pattern is used to request endorsement of a resource owned by the origin system.", - "ldn-service.form.label.pattern.request-endorsement.category": "Requests", + "ldn-service.form.pattern.request-endorsement.label": "Request Endorsement", + "ldn-service.form.pattern.request-endorsement.description": "This pattern is used to request endorsement of a resource owned by the origin system.", + "ldn-service.form.pattern.request-endorsement.category": "Requests", - "ldn-service.form.label.pattern.request-ingest.name": "Request Ingest", - "ldn-service.form.label.pattern.request-ingest.description": "This pattern is used to request that the target system ingest a resource.", - "ldn-service.form.label.pattern.request-ingest.category": "Requests", + "ldn-service.form.pattern.request-ingest.label": "Request Ingest", + "ldn-service.form.pattern.request-ingest.description": "This pattern is used to request that the target system ingest a resource.", + "ldn-service.form.pattern.request-ingest.category": "Requests", - "ldn-service.form.label.pattern.request-review.name": "Request Review", - "ldn-service.form.label.pattern.request-review.description": "This pattern is used to request a review of a resource owned by the origin system.", - "ldn-service.form.label.pattern.request-review.category": "Requests", + "ldn-service.form.pattern.request-review.label": "Request Review", + "ldn-service.form.pattern.request-review.description": "This pattern is used to request a review of a resource owned by the origin system.", + "ldn-service.form.pattern.request-review.category": "Requests", - "ldn-service.form.label.pattern.undo-offer.name": "Undo Offer", - "ldn-service.form.label.pattern.undo-offer.description": "This pattern is used to undo (retract) an offer previously made.", - "ldn-service.form.label.pattern.undo-offer.category": "Undo", + "ldn-service.form.pattern.undo-offer.label": "Undo Offer", + "ldn-service.form.pattern.undo-offer.description": "This pattern is used to undo (retract) an offer previously made.", + "ldn-service.form.pattern.undo-offer.category": "Undo", "ldn-new-service.form.label.placeholder.selectedItemFilter": "No Item Filter Selected", "ldn-new-service.form.label.ItemFilter": "Item Filter", From f4b8c7f1f1deb128c9671e9fc054b1e28e6555a5 Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Fri, 10 Nov 2023 10:44:39 +0100 Subject: [PATCH 03/21] CST-12179 Removed comments --- .../ldn-service-coar-patterns.ts | 105 +++++------------- 1 file changed, 27 insertions(+), 78 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts index a882d5db11..8620bfc80c 100644 --- a/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts +++ b/src/app/admin/admin-ldn-services/ldn-services-patterns/ldn-service-coar-patterns.ts @@ -1,82 +1,31 @@ export const notifyPatterns = [ - //{ - 'ack-accept', - //name: 'ldn-service.form.pattern.acknowledge-and-accept.label', - //description: 'ldn-service.form.pattern.acknowledge-and-accept.description', - //category: 'ldn-service.form.pattern.acknowledge-and-accept.category' - //}, - //{ - 'ack-reject', - //name: 'ldn-service.form.pattern.acknowledge-and-reject.label', - //description: 'ldn-service.form.pattern.acknowledge-and-reject.description', - //category: 'ldn-service.form.pattern.acknowledge-and-reject.category' - //}, - //{ - 'ack-tentative-accept', - //name: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.label', - //description: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.description', - //category: 'ldn-service.form.pattern.acknowledge-and-tentatively-accept.category' - //}, - //{ - 'ack-tentative-reject', - //name: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.label', - //description: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.description', - //category: 'ldn-service.form.pattern.acknowledge-and-tentatively-reject.category' - //}, - //{ - 'announce-endorsement', - //name: 'ldn-service.form.pattern.announce-endorsement.label', - //description: 'ldn-service.form.pattern.announce-endorsement.description', - //category: 'ldn-service.form.pattern.announce-endorsement.category' - //}, - //{ - 'announce-ingest', - //name: 'ldn-service.form.pattern.announce-ingest.label', - //description: 'ldn-service.form.pattern.announce-ingest.description', - //category: 'ldn-service.form.pattern.announce-ingest.category' - //}, - //{ - 'announce-relationship', - //name: 'ldn-service.form.pattern.announce-relationship.label', - //description: 'ldn-service.form.pattern.announce-relationship.description', - //category: 'ldn-service.form.pattern.announce-relationship.category' - //}, - //{ - 'announce-review', - //name: 'ldn-service.form.pattern.announce-review.label', - //description: 'ldn-service.form.pattern.announce-review.description', - //category: 'ldn-service.form.pattern.announce-review.category' - //}, - //{ - 'announce-service-result', - //name: 'ldn-service.form.pattern.announce-service-result.label', - //description: 'ldn-service.form.pattern.announce-service-result.description', - //category: 'ldn-service.form.pattern.announce-service-result.category' - //}, - //{ - 'request-endorsement', - //name: 'ldn-service.form.pattern.request-endorsement.label', - //description: 'ldn-service.form.pattern.request-endorsement.description', - //category: 'ldn-service.form.pattern.request-endorsement.category' - //}, - //{ - 'request-ingest', - //name: 'ldn-service.form.pattern.request-ingest.label', - //description: 'ldn-service.form.pattern.request-ingest.description', - //category: 'ldn-service.form.pattern.request-ingest.category' - //}, - //{ - 'request-review', - //name: 'ldn-service.form.pattern.request-review.label', - //description: 'ldn-service.form.pattern.request-review.description', - //category: 'ldn-service.form.pattern.request-review.category' - //}, - //{ - 'undo-offer', - //name: 'ldn-service.form.pattern.undo-offer.label', - //description: 'ldn-service.form.pattern.undo-offer.description', - //category: 'ldn-service.form.pattern.undo-offer.category' - //} + + 'ack-accept', + + 'ack-reject', + + 'ack-tentative-accept', + + 'ack-tentative-reject', + + 'announce-endorsement', + + 'announce-ingest', + + 'announce-relationship', + + 'announce-review', + + 'announce-service-result', + + 'request-endorsement', + + 'request-ingest', + + 'request-review', + + 'undo-offer', + ]; From 721b80a0e678880772c89412e114eb8189ed37b4 Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Tue, 14 Nov 2023 13:13:39 +0100 Subject: [PATCH 04/21] CST-12455 Changes for the page to be using an ngbdropdown logic are still required and being worked on --- .../ldn-service-form-edit.component.html | 121 ++++++++++++------ .../ldn-service-form-edit.component.scss | 8 +- .../ldn-service-form-edit.component.ts | 56 +++++++- .../ldn-service-form.component.html | 100 +++++++++++---- .../ldn-service-form.component.scss | 10 +- .../ldn-service-form.component.ts | 26 ++++ 6 files changed, 247 insertions(+), 74 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html index 56105ce805..192a6633a2 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html @@ -69,12 +69,12 @@
- +
-
- +
+
-
+
@@ -86,34 +86,55 @@
- -
+
+
+ + -
- - - -
- -
- -
-
+ +
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+ +
+
+
+ + + +
+ +
+ +
+
+
+
+
-
+
@@ -162,16 +183,36 @@
- +
+
+ + + + +
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+ +
+
+
- +
@@ -214,7 +255,7 @@ {{ 'ldn-new-service.form.label.submit' | translate }}
-
@@ -243,7 +284,7 @@ -
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.scss b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.scss index 0b244d76db..2fc1e693f0 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.scss +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.scss @@ -1,3 +1,6 @@ +@import '../../../shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.scss'; +@import '../../../shared/form/form.component.scss'; + form { font-size: 14px; position: relative; @@ -28,7 +31,6 @@ textarea { .add-pattern-link { color: #0048ff; cursor: pointer; - margin-left: 10px; } .remove-pattern-link { @@ -93,6 +95,10 @@ textarea { margin-top: 10px; } +.small-text { + font-size: 0.7em; + color: #888; +} .toggle-switch { cursor: pointer; margin-top: 3px; diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts index f0422e39e4..cb2805f069 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts @@ -5,7 +5,7 @@ import { ActivatedRoute, Router } from '@angular/router'; import { LdnServicesService } from '../ldn-services-data/ldn-services-data.service'; import { notifyPatterns } from '../ldn-services-patterns/ldn-service-coar-patterns'; import { animate, state, style, transition, trigger } from '@angular/animations'; -import { NgbModal } from '@ng-bootstrap/ng-bootstrap'; +import {NgbDropdownConfig, NgbModal} from '@ng-bootstrap/ng-bootstrap'; import { NotificationsService } from '../../../shared/notifications/notifications.service'; import { TranslateService } from '@ngx-translate/core'; import { LdnService } from '../ldn-services-model/ldn-services.model'; @@ -19,6 +19,7 @@ import { Observable } from 'rxjs'; import { PaginationService } from '../../../core/pagination/pagination.service'; import { FindListOptions } from '../../../core/data/find-list-options.model'; import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model'; +import {pattern} from "isbot"; @Component({ selector: 'ds-ldn-service-form-edit', @@ -65,6 +66,8 @@ export class LdnServiceFormEditComponent implements OnInit { private deletedOutboundPatterns: number[] = []; private modalRef: any; private service: LdnService; + selectedOutboundPatterns: string[]; + selectedInboundPatterns: string[]; constructor( protected ldnServicesService: LdnServicesService, @@ -164,8 +167,10 @@ export class LdnServiceFormEditComponent implements OnInit { this.createReplaceOperation(patchOperations, 'ldnUrl', '/ldnurl'); this.createReplaceOperation(patchOperations, 'url', '/url'); - this.handlePatterns(patchOperations, 'notifyServiceInboundPatterns'); - this.handlePatterns(patchOperations, 'notifyServiceOutboundPatterns'); + + + this.handlePatterns(patchOperations, 'notifyServiceInboundPatterns', this.selectedInboundPatterns); + this.handlePatterns(patchOperations, 'notifyServiceOutboundPatterns', this.selectedOutboundPatterns); this.deletedInboundPatterns.forEach(index => { const removeOperation: Operation = { @@ -201,6 +206,37 @@ export class LdnServiceFormEditComponent implements OnInit { } + selectOutboundPattern(patternValue: string, index: number): void { + // this.selectedOutboundPatterns = patternValue; + const patternArray = (this.formModel.get('notifyServiceOutboundPatterns') as FormArray).controls[index] + console.log((this.formModel.get('notifyServiceOutboundPatterns') as FormArray)) + patternArray.patchValue({pattern: patternValue} ) + //console.log(patternArray); + //this.getPatternControlNames(index) + } + + selectInboundPattern(patternValue: string, index: number): void { + // this.selectedInboundPatterns = patternValue; + const patternArray = (this.formModel.get('notifyServiceInboundPatterns') as FormArray).controls[index] + console.log((this.formModel.get('notifyServiceInboundPatterns') as FormArray)) + console.log(patternArray) + //console.log(patternArray); + //this.getPatternControlNames(index) + } + + + + getOutboundPatternControlNames(index: number) { + const patternArrayValue = (this.formModel.get('notifyServiceOutboundPatterns') as FormArray).controls[index]?.value + return patternArrayValue + } + + getInboundPatternControlNames(index: number) { + const patternArrayValue = (this.formModel.get('notifyServiceInboundPatterns') as FormArray).controls[index]?.value + return patternArrayValue + } + + toggleAutomatic(i: number) { const automaticControl = this.formModel.get(`notifyServiceInboundPatterns.${i}.automatic`); if (automaticControl) { @@ -245,6 +281,7 @@ export class LdnServiceFormEditComponent implements OnInit { patchService() { this.deleteMarkedInboundPatterns(); this.deleteMarkedOutboundPatterns(); + const patchOperations = this.generatePatchOperations(); @@ -343,11 +380,16 @@ export class LdnServiceFormEditComponent implements OnInit { } } - private handlePatterns(patchOperations: any[], formArrayName: string): void { + private handlePatterns(patchOperations: any[], formArrayName: string, selectedPatterns: string[]): void { + const patternsArray = this.formModel.get(formArrayName) as FormArray; for (let i = 0; i < patternsArray.length; i++) { + const patternGroup = patternsArray.at(i) as FormGroup; + console.warn('Calling setValueForControlInOutboundArray', formArrayName, i, selectedPatterns); + this.setValueForControlInOutboundArray(formArrayName, i, selectedPatterns[i] ) + const patternValue = patternGroup.value; if (patternGroup.dirty) { @@ -406,4 +448,10 @@ export class LdnServiceFormEditComponent implements OnInit { automatic: '', }); } + + setValueForControlInOutboundArray(formArrayName: string, index: number, value: string) { + const formArray = this.formModel.get(formArrayName) as FormArray; + console.warn('inside setValueForControlInOutboundArray', formArray); + formArray.at(index).setValue(value); + } } diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html index 1b4aa9048d..de7949614d 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html @@ -60,10 +60,10 @@
- +
-
- +
+
@@ -76,18 +76,41 @@
-
- +
+
+
+ + + + +
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.inboundPattern' | translate) }}
+
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+ +
+
+
- +
+
@@ -129,7 +153,7 @@
- +
@@ -145,16 +169,37 @@
- +
+
+ + + + +
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+ +
+
+
+
- + -
-
-
+
+ +
+
+
-
+
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.description' | translate) : ('' | translate) }}
- +
+
+
+
- -
- -
- -
-
+
+
+ +
+ + +
+ +
+   +
+ + +
+ + +
+ +
+   +
+ + +
+ + +
+ +
+   +
+ + +
+ + +
+ +
+   +
+ +
+
+ +
+
+ +
+
+ +
+
+
+
+ +
+ + + + +
+
+
+
+ + + + +
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+
+
-
- -
- - -
- -
-   -
- - -
- - -
- -
-   -
- - -
- - -
- -
-   -
- - -
- - -
- -
-   -
- -
-
- -
-
- -
-
- -
-
-
-
- -
- - - - -
-
-
-
- - - - -
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
-
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
- -
- -
-
-
-
- -
- - - -
- -
- -
-
-
-
- - -
- - - - -
-
+
+
+ + +
+ +
+ +
+
+
+
+ + +
+ + + + +
+
+
- {{ 'ldn-new-service.form.label.addPattern' | translate }} -
-   -
+ {{ 'ldn-new-service.form.label.addPattern' | translate }} -
-
- -
-
- -
-
- -
-
-
-
+
+   +
-
+
+
+ +
+
+ +
+
+ +
+
+
+
- +
- -
-
-
-
- - + - -
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
-
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.description' | translate) : ('' | translate) }}
- -
- -
-
-
-
- -
- - - -
+ +
+
+
+
+ + -
- -
-
-
-
- -
- - -
+ +
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedOutboundPatterns ? ('ldn-service.form.pattern.' + selectedOutboundPatterns + '.description' | translate) : ('' | translate) }}
+ +
+
+
+
+
+ +
+ + -
+
- {{ 'ldn-new-service.form.label.addPattern' | translate }} +
+ +
+
+
+
+ +
+ + +
+
+ +
+ + {{ 'ldn-new-service.form.label.addPattern' | translate }} -
-   -
- - +
+   +
+ +
-
+
- - - + + + +
-
+
- - - + + + +
From 35c45850e796539eddf7f56e100005e133c30f02 Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Wed, 15 Nov 2023 11:57:14 +0100 Subject: [PATCH 07/21] CST-12455 Itemfilter dropdown for the edit inboundpatterns is working, now changing all remaining code and finalizing task --- .../ldn-service-form-edit.component.html | 37 +++++++++++++++---- .../ldn-service-form-edit.component.ts | 14 +++++++ 2 files changed, 44 insertions(+), 7 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html index 0ea17d6fdd..51abf43f04 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html @@ -103,11 +103,11 @@ /> -
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.outboundPattern' | translate) }}
+
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.label' | translate) : ('ldn-new-service.form.label.placeholder.inboundPattern' | translate) }}
{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
-
+
+
+
+
diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts index 9c0e60040c..fdb07226aa 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.ts @@ -67,6 +67,7 @@ export class LdnServiceFormEditComponent implements OnInit { private modalRef: any; private service: LdnService; selectedOutboundPatterns: string[]; + selectedInboundItemfilters: any; selectedInboundPatterns: string[]; constructor( @@ -214,6 +215,16 @@ export class LdnServiceFormEditComponent implements OnInit { //this.getPatternControlNames(index) } + selectInboundItemFilter(filterValue: string, index: number): void { + // this.selectedOutboundPatterns = patternValue; + const filterArray = (this.formModel.get('notifyServiceInboundPatterns') as FormArray) + console.log((this.formModel.get('notifyServiceInboundPatterns') as FormArray)) + filterArray.controls[index].patchValue({constraint: filterValue} ) + + //console.log(patternArray); + //this.getPatternControlNames(index) + } + selectInboundPattern(patternValue: string, index: number): void { // this.selectedOutboundPatterns = patternValue; const patternArray = (this.formModel.get('notifyServiceInboundPatterns') as FormArray) @@ -474,4 +485,7 @@ export class LdnServiceFormEditComponent implements OnInit { //console.warn('inside setValueForControlInOutboundArray', formArray); //formArray.at(index).setValue(value); //} + + + } From 778a06724b33e036ce4ed4080d276f981e3e1dac Mon Sep 17 00:00:00 2001 From: Mattia Vianelli Date: Wed, 15 Nov 2023 12:48:53 +0100 Subject: [PATCH 08/21] CST-12455 Edit page logic is working now finishing up the styling for the page --- .../ldn-service-form-edit.component.html | 50 +- .../ldn-service-form-edit.component.ts | 892 +++++++++--------- 2 files changed, 483 insertions(+), 459 deletions(-) diff --git a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html index 51abf43f04..2940ee0039 100644 --- a/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html +++ b/src/app/admin/admin-ldn-services/ldn-service-form-edit/ldn-service-form-edit.component.html @@ -108,7 +108,8 @@ class="small-text">{{ selectedInboundPatterns ? ('ldn-service.form.pattern.' + selectedInboundPatterns + '.description' | translate) : ('' | translate) }}
-
- +