fixed bug where going to the mydspace page broke

src/app/core/cache/builders/remote-data-build.service.ts

@@ -113,7 +113,6 @@ export class RemoteDataBuildService {
       href$ = observableOf(href$);
     }
 
-    href$.subscribe(href => console.log('request url: ', href));
     const requestEntry$ = href$.pipe(getRequestFromRequestHref(this.requestService));
     const tDomainList$ = requestEntry$.pipe(
       getResourceLinksFromResponse(),

src/app/core/data/data.service.ts

@@ -197,7 +197,7 @@ export abstract class DataService<T extends CacheableObject> {
         }
       ),
       switchMap((href) => this.requestService.getByHref(href)),
-      skipWhile((requestEntry) => hasValue(requestEntry)),
+      skipWhile((requestEntry) => hasValue(requestEntry) && requestEntry.completed),
       switchMap((href) =>
         this.rdbService.buildList<T>(hrefObs) as Observable<RemoteData<PaginatedList<T>>>
       )

src/app/core/data/relationship.service.ts

@@ -323,9 +323,9 @@ export class RelationshipService extends DataService<Relationship> {
           const { relation, type } = relationshipAndType;
           let updatedRelationship;
           if (relationshipLabel === type.leftwardType) {
-            updatedRelationship = Object.assign(new Relationship(), relation, { rightwardValue: nameVariant });
-          } else {
             updatedRelationship = Object.assign(new Relationship(), relation, { leftwardValue: nameVariant });
+          } else {
+            updatedRelationship = Object.assign(new Relationship(), relation, { rightwardValue: nameVariant });
           }
           return this.update(updatedRelationship);
         })

src/app/core/shared/operators.ts

@@ -47,7 +47,6 @@ export const getResponseFromEntry = () =>
 export const getResourceLinksFromResponse = () =>
   (source: Observable<RequestEntry>): Observable<string[]> =>
     source.pipe(
-      tap((t) => console.log(t)),
       filterSuccessfulResponses(),
       map((response: DSOSuccessResponse) => response.resourceSelfLinks),
     );

src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts

@@ -222,7 +222,6 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
         getRemoteDataPayload(),
         switchMap((submissionObject: SubmissionObject) => (submissionObject.item as Observable<RemoteData<Item>>).pipe(getSucceededRemoteData(), getRemoteDataPayload())),
         switchMap((item: Item) => this.relationService.getRelatedItemsByLabel(item, this.model.relationship.relationshipType)),
-        tap((t) => console.log(t)),
         map((items: PaginatedList<Item>) => items.page.map((item) => Object.assign(new SearchResult(), { indexableObject: item }))),
       ).subscribe((relatedItems: SearchResult<Item>[]) => this.selectableListService.select(this.listId, relatedItems));