Changes based on feedback

src/app/+my-dspace-page/my-dspace-page.component.spec.ts

@@ -28,7 +28,7 @@ import { RoleDirective } from '../shared/roles/role.directive';
 import { RoleService } from '../core/roles/role.service';
 import { RoleServiceMock } from '../shared/mocks/role-service.mock';
 import { createSuccessfulRemoteDataObject$ } from '../shared/remote-data.utils';
-import { SidebarServiceStub } from '../shared/testing/SidebarServiceStub';
+import { SidebarServiceStub } from '../shared/testing/sidebar-service.stub';
 
 describe('MyDSpacePageComponent', () => {
   let comp: MyDSpacePageComponent;

src/app/+search-page/search.component.spec.ts

@@ -24,7 +24,7 @@ import { RouteService } from '../core/services/route.service';
 import { SearchConfigurationServiceStub } from '../shared/testing/search-configuration-service.stub';
 import { createSuccessfulRemoteDataObject$ } from '../shared/remote-data.utils';
 import { PaginatedSearchOptions } from '../shared/search/paginated-search-options.model';
-import { SidebarServiceStub } from '../shared/testing/SidebarServiceStub';
+import { SidebarServiceStub } from '../shared/testing/sidebar-service.stub';
 
 let comp: SearchComponent;
 let fixture: ComponentFixture<SearchComponent>;

src/app/shared/menu/menu.service.spec.ts

@@ -178,16 +178,6 @@ describe('MenuService', () => {
     });
 
     describe('when the subsection list is empty', () => {
-      beforeEach(() => {
-        /*        selectSpy.and.callFake(() => {
-                  return () => {
-                    return () => hot('a', {
-                        a: []
-                      }
-                    );
-                  };
-                });*/
-      });
       it('should return false', () => {
 
         const result = service.hasSubSections(MenuID.ADMIN, 'fakeId');

src/app/shared/search/search-settings/search-settings.component.spec.ts

@@ -15,7 +15,7 @@ import { VarDirective } from '../../utils/var.directive';
 import { take } from 'rxjs/operators';
 import { SEARCH_CONFIG_SERVICE } from '../../../+my-dspace-page/my-dspace-page.component';
 import { SidebarService } from '../../sidebar/sidebar.service';
-import { SidebarServiceStub } from '../../testing/SidebarServiceStub';
+import { SidebarServiceStub } from '../../testing/sidebar-service.stub';
 
 describe('SearchSettingsComponent', () => {
 

src/app/shared/sidebar/page-with-sidebar.component.spec.ts

@@ -7,7 +7,7 @@ import { of as observableOf } from 'rxjs';
 import { PageWithSidebarComponent } from './page-with-sidebar.component';
 import { SidebarService } from './sidebar.service';
 import { HostWindowService } from '../host-window.service';
-import { SidebarServiceStub } from '../testing/SidebarServiceStub';
+import { SidebarServiceStub } from '../testing/sidebar-service.stub';
 
 describe('PageWithSidebarComponent', () => {
   let comp: PageWithSidebarComponent;