Code clean up

This commit is contained in:
Julius Gruber
2019-10-15 15:14:36 +02:00
parent 909b47425f
commit 6718bfdcfe
3 changed files with 1 additions and 48 deletions

View File

@@ -62,32 +62,12 @@ export class LogInPasswordComponent implements OnInit {
*/ */
public hasMessage = false; public hasMessage = false;
/**
* Whether user is authenticated.
* @type {Observable<string>}
*/
/* public isAuthenticated: Observable<boolean>;*/
/**
* True if the authentication is loading.
* @type {boolean}
*/
/*
public loading: Observable<boolean>;
*/
/** /**
* The authentication form. * The authentication form.
* @type {FormGroup} * @type {FormGroup}
*/ */
public form: FormGroup; public form: FormGroup;
/* /!**
* Component state.
* @type {boolean}
*!/
private alive = true;*/
@Input() authMethodModel: InjectedAuthMethodModel; @Input() authMethodModel: InjectedAuthMethodModel;
/** /**
@@ -110,8 +90,6 @@ export class LogInPasswordComponent implements OnInit {
* @method ngOnInit * @method ngOnInit
*/ */
public ngOnInit() { public ngOnInit() {
// set isAuthenticated
/* this.isAuthenticated = this.store.pipe(select(isAuthenticated));*/
// set formGroup // set formGroup
this.form = this.formBuilder.group({ this.form = this.formBuilder.group({
@@ -137,28 +115,7 @@ export class LogInPasswordComponent implements OnInit {
}) })
); );
/* // set loading
this.loading = this.store.pipe(select(isAuthenticationLoading));
// subscribe to success
this.store.pipe(
select(isAuthenticated),
takeWhile(() => this.alive),
filter((authenticated) => authenticated))
.subscribe(() => {
this.authService.redirectAfterLoginSuccess(this.authMethodModel.isStandalonePage);
} }
);*/
}
/**
* Lifecycle hook that is called when a directive, pipe or service is destroyed.
* @method ngOnDestroy
*/
/* public ngOnDestroy() {
this.alive = false;
}*/
/** /**
* Reset error or message. * Reset error or message.

View File

@@ -1,9 +1,8 @@
<div class="form-login px-4 py-3 shibb" *ngIf="!(loading | async) && !(isAuthenticated | async)">
<a class="btn btn-lg btn-primary btn-block mt-3" <a class="btn btn-lg btn-primary btn-block mt-3"
(click)="submit()" (click)="submit()"
role="button" role="button"
>{{"login.form.shibboleth" | translate}}</a> >{{"login.form.shibboleth" | translate}}</a>
</div>

View File

@@ -1,3 +0,0 @@
.shibb {
color: #FFFFFF;
}