hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-08 18:44:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix tests and lint issues

Browse Source
This commit is contained in:
Art Lowel
2020-04-28 16:35:51 +02:00
parent e4c4a1ecd4
commit 673926c36b
5 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.spec.ts
View File

@@ -73,6 +73,7 @@ import { of as observableOf } from 'rxjs';
import { createSuccessfulRemoteDataObject } from '../../../testing/utils'; import { createSuccessfulRemoteDataObject } from '../../../testing/utils';
import { FormService } from '../../form.service'; import { FormService } from '../../form.service';
import { SubmissionService } from '../../../../submission/submission.service'; import { SubmissionService } from '../../../../submission/submission.service';
import { FormBuilderService } from '../form-builder.service';
describe('DsDynamicFormControlContainerComponent test suite', () => { describe('DsDynamicFormControlContainerComponent test suite', () => {
@@ -180,6 +181,7 @@ describe('DsDynamicFormControlContainerComponent test suite', () => {
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipService, useValue: {} },
{ provide: SelectableListService, useValue: {} }, { provide: SelectableListService, useValue: {} },
{ provide: FormService, useValue: {} }, { provide: FormService, useValue: {} },
{ provide: FormBuilderService, useValue: {} },
{ provide: SubmissionService, useValue: {} }, { provide: SubmissionService, useValue: {} },
{ {
provide: SubmissionObjectDataService, provide: SubmissionObjectDataService,

1
src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts
View File

@@ -390,7 +390,6 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
modalComp.item = this.item; modalComp.item = this.item;
modalComp.collection = this.collection; modalComp.collection = this.collection;
modalComp.submissionId = this.model.submissionId; modalComp.submissionId = this.model.submissionId;
modalComp.selectEvent
} }
/** /**

3
src/app/shared/form/builder/ds-dynamic-form-ui/existing-relation-list-element/existing-relation-list-element.component.ts
View File

@@ -61,7 +61,6 @@ export abstract class Reorderable {
} }
} }
/** /**
* Represents a single existing relationship value as metadata in submission * Represents a single existing relationship value as metadata in submission
*/ */
@@ -118,7 +117,7 @@ export class ExistingRelationListElementComponent implements OnInit, OnChanges,
* Removes the selected relationship from the list * Removes the selected relationship from the list
*/ */
removeSelection() { removeSelection() {
this.selectableListService.deselectSingle(this.listId, Object.assign(new ItemSearchResult(), { indexableObject: this.relatedItem$ })); this.selectableListService.deselectSingle(this.listId, Object.assign(new ItemSearchResult(), { indexableObject: this.relatedItem$.getValue() }));
this.store.dispatch(new RemoveRelationshipAction(this.submissionItem, this.relatedItem$.getValue(), this.relationshipOptions.relationshipType, this.submissionId)); this.store.dispatch(new RemoveRelationshipAction(this.submissionItem, this.relatedItem$.getValue(), this.relationshipOptions.relationshipType, this.submissionId));
} }

8
src/app/submission/sections/form/section-form-operations.service.spec.ts
View File

@@ -665,7 +665,7 @@ describe('SectionFormOperationsService test suite', () => {
spyOn(service, 'getFieldPathFromEvent').and.returnValue('path/1'); spyOn(service, 'getFieldPathFromEvent').and.returnValue('path/1');
spyOn(service, 'getFieldPathSegmentedFromChangeEvent').and.returnValue('path'); spyOn(service, 'getFieldPathSegmentedFromChangeEvent').and.returnValue('path');
spyOn(service, 'getFieldValueFromChangeEvent').and.returnValue(new FormFieldMetadataValueObject('test')); spyOn(service, 'getFieldValueFromChangeEvent').and.returnValue(new FormFieldMetadataValueObject('test'));
spyOn(service, 'getArrayIndexFromEvent').and.returnValue(1); spyOn(service, 'getArrayIndexFromEvent').and.returnValue(0);
spyOn(serviceAsAny, 'getValueMap'); spyOn(serviceAsAny, 'getValueMap');
spyOn(serviceAsAny, 'dispatchOperationsFromMap'); spyOn(serviceAsAny, 'dispatchOperationsFromMap');
formBuilderService.isQualdropGroup.and.returnValue(false); formBuilderService.isQualdropGroup.and.returnValue(false);
@@ -676,8 +676,10 @@ describe('SectionFormOperationsService test suite', () => {
serviceAsAny.dispatchOperationsFromChangeEvent(pathCombiner, event, previousValue, false); serviceAsAny.dispatchOperationsFromChangeEvent(pathCombiner, event, previousValue, false);
expect(jsonPatchOpBuilder.add).toHaveBeenCalledWith( expect(jsonPatchOpBuilder.add).toHaveBeenCalledWith(
pathCombiner.getPath('path/1'), pathCombiner.getPath('path'),
new FormFieldMetadataValueObject('test')); new FormFieldMetadataValueObject('test'),
true
);
}); });
}); });

2
src/app/submission/sections/form/section-form.component.spec.ts
View File

@@ -339,7 +339,7 @@ describe('SubmissionSectionformComponent test suite', () => {
comp.updateForm(sectionData, parsedSectionErrors); comp.updateForm(sectionData, parsedSectionErrors);
expect(comp.initForm).not.toHaveBeenCalled(); expect(comp.initForm).toHaveBeenCalled();
expect(comp.checksForErrors).toHaveBeenCalled(); expect(comp.checksForErrors).toHaveBeenCalled();
expect(comp.sectionData.data).toEqual(sectionData); expect(comp.sectionData.data).toEqual(sectionData);
}); });