From 682fd99ebb4bf60ff288f38f0f4a64b380fa07e7 Mon Sep 17 00:00:00 2001 From: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Date: Thu, 6 Mar 2025 11:21:39 -0600 Subject: [PATCH] [Port dspace-8_x] remove custom theme dependency in base component SuggestionListElementComponent (#4059) * remove custom theme dependency (cherry picked from commit 0c63c1720ed2cb6a5517f38387abe5bf141352e2) * remove custom theme component (cherry picked from commit 469164f00b5b7d71d8143a0dadc3042b7901042f) * remove obsolete constructor (cherry picked from commit b54638c863e9a33d98309a26cdbb83fe67e0cd68) * fix lint error (cherry picked from commit b0407fecc01374714312d72ebe40a8fcce3dde0f) * fix lint error (cherry picked from commit c6d83ec600c213f6a09ad1aaba49806548488bf9) --------- Co-authored-by: Sascha Szott --- .../suggestion-list-element.component.spec.ts | 2 +- .../suggestion-list-element.component.ts | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/app/notifications/suggestion-list-element/suggestion-list-element.component.spec.ts b/src/app/notifications/suggestion-list-element/suggestion-list-element.component.spec.ts index 3f803c468d..2933933ba3 100644 --- a/src/app/notifications/suggestion-list-element/suggestion-list-element.component.spec.ts +++ b/src/app/notifications/suggestion-list-element/suggestion-list-element.component.spec.ts @@ -9,9 +9,9 @@ import { TranslateModule } from '@ngx-translate/core'; import { getTestScheduler } from 'jasmine-marbles'; import { TestScheduler } from 'rxjs/testing'; -import { ItemSearchResultListElementComponent } from '../../../themes/custom/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component'; import { Item } from '../../core/shared/item.model'; import { mockSuggestionPublicationOne } from '../../shared/mocks/publication-claim.mock'; +import { ItemSearchResultListElementComponent } from '../../shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component'; import { SuggestionActionsComponent } from '../suggestion-actions/suggestion-actions.component'; import { SuggestionEvidencesComponent } from './suggestion-evidences/suggestion-evidences.component'; import { SuggestionListElementComponent } from './suggestion-list-element.component'; diff --git a/src/app/notifications/suggestion-list-element/suggestion-list-element.component.ts b/src/app/notifications/suggestion-list-element/suggestion-list-element.component.ts index 11bc64935b..99a22f89ea 100644 --- a/src/app/notifications/suggestion-list-element/suggestion-list-element.component.ts +++ b/src/app/notifications/suggestion-list-element/suggestion-list-element.component.ts @@ -6,14 +6,13 @@ import { OnInit, Output, } from '@angular/core'; -import { NgbModal } from '@ng-bootstrap/ng-bootstrap'; import { TranslateModule } from '@ngx-translate/core'; import { Suggestion } from 'src/app/core/notifications/suggestions/models/suggestion.model'; -import { ItemSearchResultListElementComponent } from '../../../themes/custom/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component'; import { Item } from '../../core/shared/item.model'; import { fadeIn } from '../../shared/animations/fade'; import { isNotEmpty } from '../../shared/empty.util'; +import { ItemSearchResultListElementComponent } from '../../shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component'; import { SuggestionActionsComponent } from '../suggestion-actions/suggestion-actions.component'; import { SuggestionApproveAndImport } from './suggestion-approve-and-import'; import { SuggestionEvidencesComponent } from './suggestion-evidences/suggestion-evidences.component'; @@ -62,13 +61,6 @@ export class SuggestionListElementComponent implements OnInit { */ @Output() selected = new EventEmitter(); - /** - * Initialize instance variables - * - * @param {NgbModal} modalService - */ - constructor(private modalService: NgbModal) { } - ngOnInit() { this.listableObject = { indexableObject: Object.assign(new Item(), { id: this.object.id, metadata: this.object.metadata }),