From 6e7fe85b4748472fb8b12b097424c9e4115b09ec Mon Sep 17 00:00:00 2001
From: Art Lowel <art@atmire.com>
Date: Wed, 14 Apr 2021 16:42:11 +0200
Subject: [PATCH] use the chromedriver npm package to download the webdriver
 version compatible with the installed chrome version

---
 .github/workflows/build.yml | 7 ++++++-
 e2e/protractor-ci.conf.js   | 4 ++++
 package.json                | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0b5b3f9d8c..d2e8b9fe5e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -53,6 +53,9 @@ jobs:
           key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
           restore-keys: ${{ runner.os }}-yarn-
 
+      - name: Install the latest chromedriver compatible with the installed chrome version
+        run: yarn global add chromedriver --detect_chromedriver_version
+
       - name: Install Yarn dependencies
         run: yarn install --frozen-lockfile
 
@@ -94,7 +97,9 @@ jobs:
         run: curl http://localhost:8080/server/api
 
       - name: Run e2e tests (integration tests)
-        run: yarn run e2e:ci
+        run: |
+          chromedriver --url-base='/wd/hub' --port=4444 &
+          yarn run e2e:ci
 
       - name: Shutdown Docker containers
         run: docker-compose -f ./docker/docker-compose-ci.yml down
diff --git a/e2e/protractor-ci.conf.js b/e2e/protractor-ci.conf.js
index 63173e44e3..0cfc1f9eaf 100644
--- a/e2e/protractor-ci.conf.js
+++ b/e2e/protractor-ci.conf.js
@@ -7,4 +7,8 @@ config.capabilities = {
     }
 };
 
+// don't use protractor's webdriver, as it may be incompatible with the installed chrome version
+config.directConnect = false;
+config.seleniumAddress = 'http://localhost:4444/wd/hub';
+
 exports.config = config;
diff --git a/package.json b/package.json
index 4008bb0ac3..80af52e264 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,7 @@
     "lint": "ng lint",
     "lint-fix": "ng lint --fix=true",
     "e2e": "ng e2e",
-    "e2e:ci": "ng e2e --protractor-config=./e2e/protractor-ci.conf.js",
+    "e2e:ci": "ng e2e --webdriver-update=false --protractor-config=./e2e/protractor-ci.conf.js",
     "compile:server": "webpack --config webpack.server.config.js --progress --color",
     "serve:ssr": "node dist/server",
     "clean:coverage": "rimraf coverage",