hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 10:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed item-edit.cy.ts regularly failing because of aria-required-children for role="row" & added missing roles to edit comcol tabs

Browse Source
This commit is contained in:
Alexandre Vryghem
2024-04-24 00:37:07 +02:00
parent c2684d3078
commit 77d0f9cd60
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cypress/e2e/item-edit.cy.ts
View File

@@ -18,6 +18,11 @@ describe('Edit Item > Edit Metadata tab', () => {
// <ds-edit-item-page> tag must be loaded // <ds-edit-item-page> tag must be loaded
cy.get('ds-edit-item-page').should('be.visible'); cy.get('ds-edit-item-page').should('be.visible');
// wait for all the ds-dso-edit-metadata-value components to be rendered
cy.get('ds-dso-edit-metadata-value div[role="row"]').each(($row: HTMLDivElement) => {
cy.wrap($row).find('div[role="cell"]').should('be.visible');
});
// Analyze <ds-edit-item-page> for accessibility issues // Analyze <ds-edit-item-page> for accessibility issues
testA11y('ds-edit-item-page'); testA11y('ds-edit-item-page');
}); });

7
src/app/shared/comcol/comcol-forms/edit-comcol-page/edit-comcol-page.component.html
View File

@@ -11,9 +11,10 @@
</div> </div>
</div> </div>
<div class="pt-2"> <div class="pt-2">
<ul class="nav nav-tabs justify-content-start mb-2"> <ul class="nav nav-tabs justify-content-start mb-2" role="tablist">
<li *ngFor="let page of pages" class="nav-item"> <li *ngFor="let page of pages" class="nav-item" role="presentation">
<a class="nav-link" <a class="nav-link" role="tab"
[attr.aria-selected]="page === currentPage"
[ngClass]="{'active' : page === currentPage}" [ngClass]="{'active' : page === currentPage}"
[routerLink]="['./' + page]" [routerLink]="['./' + page]"
[attr.data-test]="page"> [attr.data-test]="page">