fix lint, change translation, clean up component

This commit is contained in:
FrancescoMolinaro
2024-01-12 11:15:42 +01:00
parent b5fa46ce86
commit 7a5b52f691
7 changed files with 68 additions and 76 deletions

View File

@@ -1,6 +1,6 @@
import { IpV4Validator } from "./ipV4.validator";
import { TestBed } from "@angular/core/testing";
import { UntypedFormControl, UntypedFormGroup } from "@angular/forms";
import { IpV4Validator } from './ipV4.validator';
import { TestBed } from '@angular/core/testing';
import { UntypedFormControl, UntypedFormGroup } from '@angular/forms';
describe('IpV4 validator', () => {
@@ -22,15 +22,15 @@ describe('IpV4 validator', () => {
it('should return null for valid ipV4', () => {
formGroup.controls.ip.setValue(validIp);
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toBeNull()
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toBeNull();
});
it('should return {isValidIp: false} for invalid Ip', () => {
formGroup.controls.ip.setValue('100.260.45.1');
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false})
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false});
formGroup.controls.ip.setValue('100');
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false})
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false});
formGroup.controls.ip.setValue('testString');
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false})
expect(ipV4Validator.validate(formGroup.controls.ip as UntypedFormControl)).toEqual({isValidIp: false});
});
});