From 81b0d76f1ba4923ed763c05eae4f128bec115a3b Mon Sep 17 00:00:00 2001
From: Giuseppe Digilio <giuseppe.digilio@4science.com>
Date: Wed, 21 Feb 2024 16:29:36 +0100
Subject: [PATCH] [DURACOM-240] Improve markdown pipe in order to check for
 empty values

---
 src/app/shared/utils/markdown.pipe.spec.ts | 14 ++++++++++++++
 src/app/shared/utils/markdown.pipe.ts      |  5 +++--
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/app/shared/utils/markdown.pipe.spec.ts b/src/app/shared/utils/markdown.pipe.spec.ts
index cf644767e2..58a5c70e64 100644
--- a/src/app/shared/utils/markdown.pipe.spec.ts
+++ b/src/app/shared/utils/markdown.pipe.spec.ts
@@ -55,6 +55,20 @@ describe('Markdown Pipe', () => {
     );
   });
 
+  it('should render undefined value', async () => {
+    await testTransform(
+      undefined,
+      undefined,
+    );
+  });
+
+  it('should render null value', async () => {
+    await testTransform(
+      null,
+      null,
+    );
+  });
+
   async function testTransform(input: string, output: string) {
     expect(
       await markdownPipe.transform(input),
diff --git a/src/app/shared/utils/markdown.pipe.ts b/src/app/shared/utils/markdown.pipe.ts
index b226091034..9e7beeb2f5 100644
--- a/src/app/shared/utils/markdown.pipe.ts
+++ b/src/app/shared/utils/markdown.pipe.ts
@@ -11,6 +11,7 @@ import {
 } from '@angular/platform-browser';
 
 import { environment } from '../../../environments/environment';
+import { isEmpty } from '../empty.util';
 
 const markdownItLoader = async () => (await import('markdown-it')).default;
 type LazyMarkdownIt = ReturnType<typeof markdownItLoader>;
@@ -60,8 +61,8 @@ export class MarkdownPipe implements PipeTransform {
   ) {
   }
 
-  async transform(value: string): Promise<SafeHtml> {
-    if (!environment.markdown.enabled) {
+  async transform(value: string, forcePreview = false): Promise<SafeHtml> {
+    if (isEmpty(value) || (!environment.markdown.enabled && !forcePreview)) {
       return value;
     }
     const MarkdownIt = await this.markdownIt;