hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-11 20:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TLC-249] Addressing review feedback

Browse Source 
Adding comments and tidying some comments, imports
Expect text for status not integer
Send a 'type' parameter with a DOI registration
Rename item-status.register to registerDOI

As per todonohue's feedback on 2022-01-18
This commit is contained in:
Kim Shepherd
2023-01-19 15:01:04 +13:00
parent d0b5fc257a
commit 838cde4841
6 changed files with 37 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/app/shared/object-list/identifier-data/identifier-data.component.ts
View File

@@ -1,10 +1,8 @@
import { Component, Input } from '@angular/core';
import { catchError, map } from 'rxjs/operators';
import { Observable, of as observableOf } from 'rxjs';
import { map } from 'rxjs/operators';
import { Observable } from 'rxjs';
import { hasValue } from '../../empty.util';
import { environment } from 'src/environments/environment';
import { Item } from 'src/app/core/shared/item.model';
import { AccessStatusDataService } from 'src/app/core/data/access-status-data.service';
import {IdentifierData} from './identifier-data.model';
import {IdentifierDataService} from '../../../core/data/identifier-data.service';
@@ -13,18 +11,13 @@ import {IdentifierDataService} from '../../../core/data/identifier-data.service'
templateUrl: './identifier-data.component.html'
})
/**
* Component rendering the access status of an item as a badge
* Component rendering an identifier, eg. DOI or handle
*/
export class IdentifierDataComponent {
@Input() item: Item;
identifiers$: Observable<IdentifierData>;
/**
* Whether to show the access status badge or not
*/
showAccessStatus: boolean;
/**
* Initialize instance variables
*
@@ -34,11 +27,11 @@ export class IdentifierDataComponent {
ngOnInit(): void {
if (this.item == null) {
// Do not show the badge if the feature is inactive or if the item is null.
// Do not show the identifier if the feature is inactive or if the item is null.
return;
}
if (this.item.identifiers == null) {
// In case the access status has not been loaded, do it individually.
// In case the identifier has not been loaded, do it individually.
this.item.identifiers = this.identifierDataService.getIdentifierDataFor(this.item);
}
this.identifiers$ = this.item.identifiers.pipe(
@@ -49,8 +42,6 @@ export class IdentifierDataComponent {
return null;
}
}),
// EMpty array if none
//map((identifiers: IdentifierData) => hasValue(identifiers.identifiers) ? identifiers.identifiers : [])
);
}
}