hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 18:14:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed linting in pagination component spec

Browse Source
This commit is contained in:
William Welling
2017-07-13 07:33:02 -05:00
parent 8ba69590c8
commit 8a0eb1a88b
1 changed files with 20 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/app/shared/pagination/pagination.component.spec.ts
View File

@@ -47,21 +47,21 @@ function createTestComponent<T>(html: string, type: { new (...args: any[]): T })
TestBed.overrideComponent(type, { TestBed.overrideComponent(type, {
set: { template: html } set: { template: html }
}); });
let fixture = TestBed.createComponent(type); const fixture = TestBed.createComponent(type);
fixture.detectChanges(); fixture.detectChanges();
return fixture as ComponentFixture<T>; return fixture as ComponentFixture<T>;
} }
function expectPages(fixture: ComponentFixture<any>, pagesDef: string[]): void { function expectPages(fixture: ComponentFixture<any>, pagesDef: string[]): void {
let de = fixture.debugElement.query(By.css('.pagination')); const de = fixture.debugElement.query(By.css('.pagination'));
let pages = de.nativeElement.querySelectorAll('li'); const pages = de.nativeElement.querySelectorAll('li');
expect(pages.length).toEqual(pagesDef.length); expect(pages.length).toEqual(pagesDef.length);
for (let i = 0; i < pagesDef.length; i++) { for (let i = 0; i < pagesDef.length; i++) {
let pageDef = pagesDef[i]; const pageDef = pagesDef[i];
let classIndicator = pageDef.charAt(0); const classIndicator = pageDef.charAt(0);
if (classIndicator === '+') { if (classIndicator === '+') {
expect(pages[i].classList.contains('active')).toBeTruthy(); expect(pages[i].classList.contains('active')).toBeTruthy();
@@ -86,18 +86,16 @@ function expectPages(fixture: ComponentFixture<any>, pagesDef: string[]): void {
} }
function changePageSize(fixture: ComponentFixture<any>, pageSize: string): void { function changePageSize(fixture: ComponentFixture<any>, pageSize: string): void {
let buttonEl = fixture.nativeElement.querySelector('#paginationControls'); const buttonEl = fixture.nativeElement.querySelector('#paginationControls');
let activatedRouteStub: ActivatedRouteStub;
let routerStub: RouterStub;
buttonEl.click(); buttonEl.click();
let dropdownMenu = fixture.debugElement.query(By.css('#paginationControlsDropdownMenu')); const dropdownMenu = fixture.debugElement.query(By.css('#paginationControlsDropdownMenu'));
let buttons = dropdownMenu.nativeElement.querySelectorAll('button'); const buttons = dropdownMenu.nativeElement.querySelectorAll('button');
for (let i = 0; i < buttons.length; i++) { for (const button of buttons) {
if (buttons[i].textContent.trim() == pageSize) { if (button.textContent.trim() === pageSize) {
buttons[i].click(); button.click();
fixture.detectChanges(); fixture.detectChanges();
break; break;
} }
@@ -105,8 +103,8 @@ function changePageSize(fixture: ComponentFixture<any>, pageSize: string): void
} }
function changePage(fixture: ComponentFixture<any>, idx: number): void { function changePage(fixture: ComponentFixture<any>, idx: number): void {
let de = fixture.debugElement.query(By.css('.pagination')); const de = fixture.debugElement.query(By.css('.pagination'));
let buttons = de.nativeElement.querySelectorAll('li'); const buttons = de.nativeElement.querySelectorAll('li');
buttons[idx].querySelector('a').click(); buttons[idx].querySelector('a').click();
fixture.detectChanges(); fixture.detectChanges();
@@ -119,8 +117,6 @@ function normalizeText(txt: string): string {
describe('Pagination component', () => { describe('Pagination component', () => {
let fixture: ComponentFixture<PaginationComponent>;
let comp: PaginationComponent;
let testComp: TestComponent; let testComp: TestComponent;
let testFixture: ComponentFixture<TestComponent>; let testFixture: ComponentFixture<TestComponent>;
let de: DebugElement; let de: DebugElement;
@@ -130,8 +126,8 @@ describe('Pagination component', () => {
let activatedRouteStub: ActivatedRouteStub; let activatedRouteStub: ActivatedRouteStub;
let routerStub: RouterStub; let routerStub: RouterStub;
//Define initial state and test state // Define initial state and test state
let _initialState = { width: 1600, height: 770 }; const _initialState = { width: 1600, height: 770 };
// async beforeEach // async beforeEach
beforeEach(async(() => { beforeEach(async(() => {
@@ -251,8 +247,8 @@ describe('Pagination component', () => {
})); }));
it('should set correct route parameters', fakeAsync(() => { it('should set correct route parameters', fakeAsync(() => {
let paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references['p']; const paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references.p;
routerStub = <any>testFixture.debugElement.injector.get(Router); routerStub = testFixture.debugElement.injector.get(Router) as any;
testComp.collectionSize = 60; testComp.collectionSize = 60;
@@ -269,7 +265,7 @@ describe('Pagination component', () => {
it('should get parameters from route', () => { it('should get parameters from route', () => {
activatedRouteStub = <any>testFixture.debugElement.injector.get(ActivatedRoute); activatedRouteStub = testFixture.debugElement.injector.get(ActivatedRoute) as any;;
activatedRouteStub.testParams = { activatedRouteStub.testParams = {
pageId: 'test', pageId: 'test',
page: 2, page: 2,
@@ -296,8 +292,8 @@ describe('Pagination component', () => {
}); });
it('should respond to windows resize', () => { it('should respond to windows resize', () => {
let paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references['p']; const paginationComponent: PaginationComponent = testFixture.debugElement.query(By.css('ds-pagination')).references.p;
hostWindowServiceStub = <any>testFixture.debugElement.injector.get(HostWindowService); hostWindowServiceStub = testFixture.debugElement.injector.get(HostWindowService) as any;
hostWindowServiceStub.setWidth(400); hostWindowServiceStub.setWidth(400);