From 132e1f95240edbc7d6f24cbb089304c54b7670d6 Mon Sep 17 00:00:00 2001 From: Alexandre Vryghem Date: Tue, 9 Apr 2024 19:34:00 +0100 Subject: [PATCH 1/4] Minor UI improvements - Fixed DSO edit menu sometimes displaying underneath header based on header z-index - Fixed accessibility issue on request a copy page --- .../request-a-copy/bitstream-request-a-copy-page.component.html | 2 +- .../dso-edit-menu-expandable-section.component.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/item-page/bitstreams/request-a-copy/bitstream-request-a-copy-page.component.html b/src/app/item-page/bitstreams/request-a-copy/bitstream-request-a-copy-page.component.html index 1fae737fdb..2d4ac89fcc 100644 --- a/src/app/item-page/bitstreams/request-a-copy/bitstream-request-a-copy-page.component.html +++ b/src/app/item-page/bitstreams/request-a-copy/bitstream-request-a-copy-page.component.html @@ -1,5 +1,5 @@
-

{{'bitstream-request-a-copy.header' | translate}}

+

{{'bitstream-request-a-copy.header' | translate}}

{{'bitstream-request-a-copy.alert.canDownload1' | translate}} {{'bitstream-request-a-copy.alert.canDownload2'| translate}} diff --git a/src/app/shared/dso-page/dso-edit-menu/dso-edit-expandable-menu-section/dso-edit-menu-expandable-section.component.html b/src/app/shared/dso-page/dso-edit-menu/dso-edit-expandable-menu-section/dso-edit-menu-expandable-section.component.html index cb725e7d70..6e427400ee 100644 --- a/src/app/shared/dso-page/dso-edit-menu/dso-edit-expandable-menu-section/dso-edit-menu-expandable-section.component.html +++ b/src/app/shared/dso-page/dso-edit-menu/dso-edit-expandable-menu-section/dso-edit-menu-expandable-section.component.html @@ -1,6 +1,6 @@
+ [ngbTooltip]="itemModel.text | translate" container="body"> From f8a8b905568c47bf8ba5f9be32de28b7a190e459 Mon Sep 17 00:00:00 2001 From: Alexandre Vryghem Date: Tue, 23 Apr 2024 23:02:21 +0200 Subject: [PATCH 2/4] Aligned communities search results like collections on md screens (cherry picked from commit c2684d30789e4d2782915cff963af196b75a4169) --- .../community-search-result-list-element.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/shared/object-list/search-result-list-element/community-search-result/community-search-result-list-element.component.html b/src/app/shared/object-list/search-result-list-element/community-search-result/community-search-result-list-element.component.html index d38170e863..f4a0aa917f 100644 --- a/src/app/shared/object-list/search-result-list-element/community-search-result/community-search-result-list-element.component.html +++ b/src/app/shared/object-list/search-result-list-element/community-search-result/community-search-result-list-element.component.html @@ -1,5 +1,5 @@
-
+
From da439000ac8781b555e27631ee0e1a584dd8efa0 Mon Sep 17 00:00:00 2001 From: Alexandre Vryghem Date: Wed, 24 Apr 2024 00:37:07 +0200 Subject: [PATCH 3/4] Fixed item-edit.cy.ts regularly failing because of aria-required-children for role="row" & added missing roles to edit comcol tabs (cherry picked from commit 77d0f9cd605c2c0afe1bbf4682e9cb79228d6afa) --- cypress/e2e/item-edit.cy.ts | 5 +++++ .../edit-comcol-page/edit-comcol-page.component.html | 7 ++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cypress/e2e/item-edit.cy.ts b/cypress/e2e/item-edit.cy.ts index b4c01a1a94..44c8f567bd 100644 --- a/cypress/e2e/item-edit.cy.ts +++ b/cypress/e2e/item-edit.cy.ts @@ -18,6 +18,11 @@ describe('Edit Item > Edit Metadata tab', () => { // tag must be loaded cy.get('ds-edit-item-page').should('be.visible'); + // wait for all the ds-dso-edit-metadata-value components to be rendered + cy.get('ds-dso-edit-metadata-value div[role="row"]').each(($row: HTMLDivElement) => { + cy.wrap($row).find('div[role="cell"]').should('be.visible'); + }); + // Analyze for accessibility issues testA11y('ds-edit-item-page'); }); diff --git a/src/app/shared/comcol/comcol-forms/edit-comcol-page/edit-comcol-page.component.html b/src/app/shared/comcol/comcol-forms/edit-comcol-page/edit-comcol-page.component.html index a8ca674c26..7797ba13c9 100644 --- a/src/app/shared/comcol/comcol-forms/edit-comcol-page/edit-comcol-page.component.html +++ b/src/app/shared/comcol/comcol-forms/edit-comcol-page/edit-comcol-page.component.html @@ -11,9 +11,10 @@
-