hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 10:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CST-15592] add interceptor for edit group, fix landmark-unique accessibility issue in pagination component

Browse Source
This commit is contained in:
FrancescoMolinaro
2024-10-09 14:16:47 +02:00
parent 3df66e0257
commit 9079a968f0
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cypress/e2e/edit-group.cy.ts
View File

@@ -5,6 +5,9 @@ describe('Edit Group', () => {
// Must login as an Admin to see the page // Must login as an Admin to see the page
cy.visit('/access-control/groups/'.concat(Cypress.env('DSPACE_ADMINISTRATOR_GROUP')).concat('/edit')); cy.visit('/access-control/groups/'.concat(Cypress.env('DSPACE_ADMINISTRATOR_GROUP')).concat('/edit'));
cy.loginViaForm(Cypress.env('DSPACE_TEST_ADMIN_USER'), Cypress.env('DSPACE_TEST_ADMIN_PASSWORD')); cy.loginViaForm(Cypress.env('DSPACE_TEST_ADMIN_USER'), Cypress.env('DSPACE_TEST_ADMIN_PASSWORD'));
// Wait for all search components to be loaded
cy.intercept('GET', '/server/api/eperson/groups/'.concat(Cypress.env('DSPACE_ADMINISTRATOR_GROUP').concat('/subgroups*'))).as('subGroups');
cy.wait('@subGroups');
}); });
it('should pass accessibility tests', () => { it('should pass accessibility tests', () => {

3
src/app/shared/pagination/pagination.component.html
View File

@@ -39,7 +39,8 @@
<div *ngIf="shouldShowBottomPager | async"> <div *ngIf="shouldShowBottomPager | async">
<div *ngIf="showPaginator" class="pagination justify-content-center clearfix bottom"> <div *ngIf="showPaginator" class="pagination justify-content-center clearfix bottom">
<ngb-pagination [boundaryLinks]="paginationOptions.boundaryLinks" <ngb-pagination [attr.aria-label]="('pagination-control.page-number-bar' | translate) + paginationOptions.id"
[boundaryLinks]="paginationOptions.boundaryLinks"
[collectionSize]="collectionSize" [collectionSize]="collectionSize"
[disabled]="paginationOptions.disabled" [disabled]="paginationOptions.disabled"
[ellipses]="paginationOptions.ellipses" [ellipses]="paginationOptions.ellipses"

2
src/assets/i18n/en.json5
View File

@@ -832,6 +832,8 @@
"pagination.next.button.disabled.tooltip": "No more pages of results", "pagination.next.button.disabled.tooltip": "No more pages of results",
"pagination.page-number-bar": "Control bar for page navigation, relative to element with ID: ",
"browse.startsWith": ", starting with {{ startsWith }}", "browse.startsWith": ", starting with {{ startsWith }}",
"browse.startsWith.choose_start": "(Choose start)", "browse.startsWith.choose_start": "(Choose start)",