From 92c7922fbea17a5656f1a31240340223d81ffaed Mon Sep 17 00:00:00 2001 From: Koen Pauwels Date: Tue, 6 Dec 2022 15:59:01 +0100 Subject: [PATCH] 97183 Fixed linting issues --- src/app/menu.resolver.ts | 4 ++-- src/app/shared/menu/menu.service.spec.ts | 16 ++++++++-------- src/app/shared/menu/menu.service.ts | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/app/menu.resolver.ts b/src/app/menu.resolver.ts index 19413ab4be..933014c93a 100644 --- a/src/app/menu.resolver.ts +++ b/src/app/menu.resolver.ts @@ -275,7 +275,7 @@ export class MenuResolver implements Resolve { } as TextMenuItemModel, icon: 'plus', index: 0 - } + }; const editSubMenu = { id: 'edit', active: false, @@ -286,7 +286,7 @@ export class MenuResolver implements Resolve { } as TextMenuItemModel, icon: 'pencil-alt', index: 1 - } + }; const menuList = [ ...newSubMenuList, diff --git a/src/app/shared/menu/menu.service.spec.ts b/src/app/shared/menu/menu.service.spec.ts index 26f32b64ef..589b5ebf6b 100644 --- a/src/app/shared/menu/menu.service.spec.ts +++ b/src/app/shared/menu/menu.service.spec.ts @@ -245,7 +245,7 @@ describe('MenuService', () => { describe('isMenuVisibleWithVisibleSections', () => { it('should return false when the menu is empty', () => { - const fakeMenu = { + const testMenu = { id: MenuID.ADMIN, collapsed: false, visible: true, @@ -253,7 +253,7 @@ describe('MenuService', () => { previewCollapsed: false, sectionToSubsectionIndex: {} } as any; - spyOn(service, 'getMenu').and.returnValue(observableOf(fakeMenu)); + spyOn(service, 'getMenu').and.returnValue(observableOf(testMenu)); const result = service.isMenuVisibleWithVisibleSections(MenuID.ADMIN); const expected = cold('(b|)', { @@ -269,8 +269,8 @@ describe('MenuService', () => { section_3: {id: 's3', visible: false}, section_4: {id: 's1_1', visible: true, parentID: 's1'}, section_5: {id: 's2_1', visible: true, parentID: 's2'}, - } - const fakeMenu = { + }; + const testMenu = { id: MenuID.ADMIN, collapsed: false, visible: true, @@ -281,7 +281,7 @@ describe('MenuService', () => { 'section_2': ['section_5'], } } as any; - spyOn(service, 'getMenu').and.returnValue(observableOf(fakeMenu)); + spyOn(service, 'getMenu').and.returnValue(observableOf(testMenu)); const result = service.isMenuVisibleWithVisibleSections(MenuID.ADMIN); const expected = cold('(b|)', { @@ -298,8 +298,8 @@ describe('MenuService', () => { section_3: {id: 's3', visible: false}, section_4: {id: 's1_1', visible: true, parentID: 's1'}, section_5: {id: 's2_1', visible: true, parentID: 's2'}, - } - const fakeMenu = { + }; + const testMenu = { id: MenuID.ADMIN, collapsed: false, visible: true, @@ -310,7 +310,7 @@ describe('MenuService', () => { 'section_2': ['section_5'], } } as any; - spyOn(service, 'getMenu').and.returnValue(observableOf(fakeMenu)); + spyOn(service, 'getMenu').and.returnValue(observableOf(testMenu)); const result = service.isMenuVisibleWithVisibleSections(MenuID.ADMIN); const expected = cold('(b|)', { diff --git a/src/app/shared/menu/menu.service.ts b/src/app/shared/menu/menu.service.ts index 8e2cb8a894..eeb6c0f2c2 100644 --- a/src/app/shared/menu/menu.service.ts +++ b/src/app/shared/menu/menu.service.ts @@ -208,7 +208,7 @@ export class MenuService { * Check if a menu has at least one top-level (!) section that is visible. * @param {MenuID} menuID The ID of the menu that is to be checked * @returns {Observable} Emits true if the given menu has visible sections, emits false otherwise - */ + */ menuHasVisibleSections(menuID: MenuID): Observable { return this.getMenu(menuID).pipe( map((state: MenuState) => hasValue(state)