From 968c23309a73ba35d1cfa8ed3a14e9148db6faff Mon Sep 17 00:00:00 2001
From: Yury Bondarenko <ybnd@tuta.io>
Date: Tue, 19 Dec 2023 13:33:45 +0100
Subject: [PATCH] Manual lint fixes

This can serve as an example of the type of lint issues we'd have to fix by hand in ongoing PRs if this PR were to be merged.
---
 .../qa/events/quality-assurance-events.component.html  | 10 +++++-----
 .../project-entry-import-modal.component.html          |  4 ++--
 .../qa/source/quality-assurance-source.component.html  |  8 ++++----
 .../qa/source/quality-assurance-source.effects.ts      |  6 ++++--
 .../qa/topics/quality-assurance-topics.component.html  |  8 ++++----
 .../qa/topics/quality-assurance-topics.effects.ts      |  6 ++++--
 6 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/src/app/notifications/qa/events/quality-assurance-events.component.html b/src/app/notifications/qa/events/quality-assurance-events.component.html
index d87ff1b353..59075996a1 100644
--- a/src/app/notifications/qa/events/quality-assurance-events.component.html
+++ b/src/app/notifications/qa/events/quality-assurance-events.component.html
@@ -17,23 +17,23 @@
 
       <ds-loading class="container" *ngIf="(isEventPageLoading | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
 
-      <ds-pagination *ngIf="!(isEventPageLoading | async)"
+      <ds-pagination *ngIf="(isEventPageLoading | async) === false"
                       [paginationOptions]="paginationConfig"
                       [collectionSize]="(totalElements$ | async)"
                       [sortOptions]="paginationSortConfig"
                       (paginationChange)="getQualityAssuranceEvents()">
 
         <ng-container>
-          <div *ngIf="(eventsUpdated$|async)?.length == 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
+          <div *ngIf="(eventsUpdated$ | async)?.length === 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
             {{'quality-assurance.noEvents' | translate}}
           </div>
-          <div *ngIf="(eventsUpdated$|async)?.length != 0" class="table-responsive mt-2">
+          <div *ngIf="(eventsUpdated$ | async)?.length !== 0" class="table-responsive mt-2">
             <table id="events" class="table table-striped table-hover table-bordered">
               <thead>
               <tr>
                 <th scope="col" class="trust-col">{{'quality-assurance.event.table.trust' | translate}}</th>
                 <th scope="col" class="title-col">{{'quality-assurance.event.table.publication' | translate}}</th>
-                <th *ngIf="hasDetailColumn() && showTopic.indexOf('/PROJECT') == -1" scope="col" class="content-col">
+                <th *ngIf="hasDetailColumn() && showTopic.indexOf('/PROJECT') === -1" scope="col" class="content-col">
                   {{'quality-assurance.event.table.details' | translate}}
                 </th>
                 <th *ngIf="hasDetailColumn() && showTopic.indexOf('/PROJECT') !== -1" scope="col" class="content-col">
@@ -126,7 +126,7 @@
                       >
                         <i class="fas fa-check"></i>
                       </button>
-                      <button *ngIf="showTopic.indexOf('/PROJECT') == -1"
+                      <button *ngIf="showTopic.indexOf('/PROJECT') === -1"
                               class="btn btn-outline-success btn-sm button-width"
                               ngbTooltip="{{'quality-assurance.event.action.accept' | translate}}"
                               container="body"
diff --git a/src/app/notifications/qa/project-entry-import-modal/project-entry-import-modal.component.html b/src/app/notifications/qa/project-entry-import-modal/project-entry-import-modal.component.html
index 0622e08ab0..bbaef85687 100644
--- a/src/app/notifications/qa/project-entry-import-modal/project-entry-import-modal.component.html
+++ b/src/app/notifications/qa/project-entry-import-modal/project-entry-import-modal.component.html
@@ -38,7 +38,7 @@
     </div>
 
     <ds-loading *ngIf="(isLoading$ | async)" message="{{'loading.search-results' | translate}}"></ds-loading>
-    <ds-themed-search-results *ngIf="(localEntitiesRD$ | async)?.payload?.page?.length > 0 && !(isLoading$ | async)"
+    <ds-themed-search-results *ngIf="(localEntitiesRD$ | async)?.payload?.page?.length > 0 && (isLoading$ | async) === false"
                               [searchResults]="(localEntitiesRD$ | async)"
                               [sortConfig]="this.searchOptions?.sort"
                               [searchConfig]="this.searchOptions"
@@ -53,7 +53,7 @@
                               (selectObject)="selectEntity($event)">
     </ds-themed-search-results>
 
-    <div *ngIf="(localEntitiesRD$ | async)?.payload?.page?.length < 1 && !(isLoading$ | async)">
+    <div *ngIf="(localEntitiesRD$ | async)?.payload?.page?.length < 1 && (isLoading$ | async) === false">
       <ds-alert [type]="'alert-info'">
         <p class="lead mb-0">{{(labelPrefix + label + '.notFound' | translate)}}</p>
       </ds-alert>
diff --git a/src/app/notifications/qa/source/quality-assurance-source.component.html b/src/app/notifications/qa/source/quality-assurance-source.component.html
index 0f6cf18402..61789f838b 100644
--- a/src/app/notifications/qa/source/quality-assurance-source.component.html
+++ b/src/app/notifications/qa/source/quality-assurance-source.component.html
@@ -10,7 +10,7 @@
         <h4 class="border-bottom pb-2">{{'quality-assurance.source'| translate}}</h4>
 
         <ds-loading class="container" *ngIf="(isSourceLoading() | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
-        <ds-pagination *ngIf="!(isSourceLoading() | async)"
+        <ds-pagination *ngIf="(isSourceLoading() | async) === false"
                        [paginationOptions]="paginationConfig"
                        [collectionSize]="(totalElements$ | async)"
                        [hideGear]="false"
@@ -18,11 +18,11 @@
                        (paginationChange)="getQualityAssuranceSource()">
 
           <ds-loading class="container" *ngIf="(isSourceProcessing() | async)" message="'quality-assurance.loading' | translate"></ds-loading>
-          <ng-container *ngIf="!(isSourceProcessing() | async)">
-            <div *ngIf="(sources$|async)?.length == 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
+          <ng-container *ngIf="(isSourceProcessing() | async) === false">
+            <div *ngIf="(sources$ | async)?.length === 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
               {{'quality-assurance.noSource' | translate}}
             </div>
-            <div *ngIf="(sources$|async)?.length != 0" class="table-responsive mt-2">
+            <div *ngIf="(sources$ | async)?.length !== 0" class="table-responsive mt-2">
               <table id="epeople" class="table table-striped table-hover table-bordered">
                 <thead>
                 <tr>
diff --git a/src/app/notifications/qa/source/quality-assurance-source.effects.ts b/src/app/notifications/qa/source/quality-assurance-source.effects.ts
index 7dacef60e7..d866d43365 100644
--- a/src/app/notifications/qa/source/quality-assurance-source.effects.ts
+++ b/src/app/notifications/qa/source/quality-assurance-source.effects.ts
@@ -47,9 +47,11 @@ export class QualityAssuranceSourceEffects {
         map((sources: PaginatedList<QualityAssuranceSourceObject>) =>
           new AddSourceAction(sources.page, sources.totalPages, sources.currentPage, sources.totalElements),
         ),
-        catchError((error: Error) => {
-          if (error) {
+        catchError((error: unknown) => {
+          if (error instanceof Error) {
             console.error(error.message);
+          } else {
+            console.error('Unexpected object thrown', error);
           }
           return observableOf(new RetrieveAllSourceErrorAction());
         }),
diff --git a/src/app/notifications/qa/topics/quality-assurance-topics.component.html b/src/app/notifications/qa/topics/quality-assurance-topics.component.html
index db8586f264..5d2b373442 100644
--- a/src/app/notifications/qa/topics/quality-assurance-topics.component.html
+++ b/src/app/notifications/qa/topics/quality-assurance-topics.component.html
@@ -10,7 +10,7 @@
       <h4 class="border-bottom pb-2">{{'quality-assurance.topics'| translate}}</h4>
 
       <ds-loading class="container" *ngIf="(isTopicsLoading() | async)" message="{{'quality-assurance.loading' | translate}}"></ds-loading>
-      <ds-pagination *ngIf="!(isTopicsLoading() | async)"
+      <ds-pagination *ngIf="(isTopicsLoading() | async) === false"
                      [paginationOptions]="paginationConfig"
                      [collectionSize]="(totalElements$ | async)"
                      [hideGear]="false"
@@ -18,11 +18,11 @@
                      (paginationChange)="getQualityAssuranceTopics()">
 
         <ds-loading class="container" *ngIf="(isTopicsProcessing() | async)" message="'quality-assurance.loading' | translate"></ds-loading>
-        <ng-container *ngIf="!(isTopicsProcessing() | async)">
-          <div *ngIf="(topics$|async)?.length == 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
+        <ng-container *ngIf="(isTopicsProcessing() | async) === false">
+          <div *ngIf="(topics$ | async)?.length === 0" class="alert alert-info w-100 mb-2 mt-2" role="alert">
             {{'quality-assurance.noTopics' | translate}}
           </div>
-          <div *ngIf="(topics$|async)?.length != 0" class="table-responsive mt-2">
+          <div *ngIf="(topics$ | async)?.length !== 0" class="table-responsive mt-2">
             <table id="epeople" class="table table-striped table-hover table-bordered">
               <thead>
               <tr>
diff --git a/src/app/notifications/qa/topics/quality-assurance-topics.effects.ts b/src/app/notifications/qa/topics/quality-assurance-topics.effects.ts
index e142c2a100..58d5c57460 100644
--- a/src/app/notifications/qa/topics/quality-assurance-topics.effects.ts
+++ b/src/app/notifications/qa/topics/quality-assurance-topics.effects.ts
@@ -47,9 +47,11 @@ export class QualityAssuranceTopicsEffects {
         map((topics: PaginatedList<QualityAssuranceTopicObject>) =>
           new AddTopicsAction(topics.page, topics.totalPages, topics.currentPage, topics.totalElements),
         ),
-        catchError((error: Error) => {
-          if (error) {
+        catchError((error: unknown) => {
+          if (error instanceof Error) {
             console.error(error.message);
+          } else {
+            console.error('Unexpected object thrown', error);
           }
           return observableOf(new RetrieveAllTopicsErrorAction());
         }),