87968: Minor code changes to pass lint

src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.ts

@@ -127,10 +127,10 @@ export class BrowseByMetadataPageComponent implements OnInit {
           return [Object.assign({}, routeParams, queryParams),currentPage,currentSort];
         })
       ).subscribe(([params, currentPage, currentSort]: [Params, PaginationComponentOptions, SortOptions]) => {
-          this.browseId = params.id || this.defaultBrowseId;
+          this.browseId = params.id || this.defaultBrowseId;
           this.authority = params.authority;
-          this.value = +params.value || params.value || '';
-          this.startsWith = +params.startsWith || params.startsWith;
+          this.value = +params.value || params.value || '';
+          this.startsWith = +params.startsWith || params.startsWith;
           const searchOptions = browseParamsToOptions(params, currentPage, currentSort, this.browseId);
           if (isNotEmpty(this.value)) {
             this.updatePageWithItems(searchOptions, this.value, this.authority);

src/app/browse-by/browse-by-title-page/browse-by-title-page.component.ts

@@ -45,7 +45,7 @@ export class BrowseByTitlePageComponent extends BrowseByMetadataPageComponent {
           return [Object.assign({}, routeParams, queryParams),currentPage,currentSort];
         })
       ).subscribe(([params, currentPage, currentSort]: [Params, PaginationComponentOptions, SortOptions]) => {
-        this.browseId = params.id || this.defaultBrowseId;
+        this.browseId = params.id || this.defaultBrowseId;
         this.updatePageWithItems(browseParamsToOptions(params, currentPage, currentSort, this.browseId), undefined, undefined);
         this.updateParent(params.scope);
       }));

src/app/community-list-page/community-list/themed-community-list.component.ts

@@ -7,7 +7,8 @@ import { Component } from '@angular/core';
   selector: 'ds-themed-community-list',
   styleUrls: [],
   templateUrl: '../../shared/theme-support/themed.component.html',
-})export class ThemedCommunityListComponent extends ThemedComponent<CommunityListComponent> {
+})
+export class ThemedCommunityListComponent extends ThemedComponent<CommunityListComponent> {
   protected getComponentName(): string {
     return 'CommunityListComponent';
   }

src/app/core/auth/auth.service.ts

@@ -112,7 +112,7 @@ export class AuthService {
         if (hasValue(rd.payload) && rd.payload.authenticated) {
           return rd.payload;
         } else {
-          throw(new Error('Invalid email or password'));
+          throw (new Error('Invalid email or password'));
         }
       }));
 
@@ -166,7 +166,7 @@ export class AuthService {
         if (hasValue(status) && status.authenticated) {
           return status._links.eperson.href;
         } else {
-          throw(new Error('Not authenticated'));
+          throw (new Error('Not authenticated'));
         }
       }));
   }
@@ -249,7 +249,7 @@ export class AuthService {
         if (hasValue(status) && status.authenticated) {
           return status.token;
         } else {
-          throw(new Error('Not authenticated'));
+          throw (new Error('Not authenticated'));
         }
       }));
   }
@@ -288,7 +288,7 @@ export class AuthService {
         if (hasValue(status) && !status.authenticated) {
           return true;
         } else {
-          throw(new Error('auth.errors.invalid-user'));
+          throw (new Error('auth.errors.invalid-user'));
         }
       }));
   }

src/app/core/auth/server-auth.service.ts

@@ -36,7 +36,7 @@ export class ServerAuthService extends AuthService {
         if (hasValue(status) && status.authenticated) {
           return status._links.eperson.href;
         } else {
-          throw(new Error('Not authenticated'));
+          throw (new Error('Not authenticated'));
         }
       }));
   }

src/app/core/data/filtered-discovery-page-response-parsing.service.ts

@@ -16,7 +16,8 @@ export class FilteredDiscoveryPageResponseParsingService extends BaseResponsePar
   toCache = false;
   constructor(
     protected objectCache: ObjectCacheService,
-  ) { super();
+  ) {
+    super();
   }
 
   /**

src/app/entity-groups/research-entities/metadata-representations/person/person-item-metadata-list-element.component.spec.ts

@@ -9,7 +9,7 @@ import { Item } from '../../../../core/shared/item.model';
 import { PersonItemMetadataListElementComponent } from './person-item-metadata-list-element.component';
 import { MetadataValue } from '../../../../core/shared/metadata.models';
 
-const jobTitle ='Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.';
+const jobTitle = 'Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.';
 const firstName = 'Joe';
 const lastName = 'Anonymous';
 const mockItem = Object.assign(new Item(), { metadata: { 'person.jobTitle': [{ value: jobTitle }], 'person.givenName': [{ value: firstName }], 'person.familyName': [{ value: lastName }] } });

src/app/my-dspace-page/my-dspace-new-submission/my-dspace-new-external-dropdown/my-dspace-new-external-dropdown.component.spec.ts

@@ -185,5 +185,5 @@ describe('MyDSpaceNewExternalDropdownComponent test', () => {
 class TestComponent {
   reload = (event) => {
     return;
-  }
+  };
 }

src/app/my-dspace-page/my-dspace-new-submission/my-dspace-new-submission-dropdown/my-dspace-new-submission-dropdown.component.spec.ts

@@ -190,5 +190,5 @@ describe('MyDSpaceNewSubmissionDropdownComponent test', () => {
 class TestComponent {
   reload = (event) => {
     return;
-  }
+  };
 }

src/app/my-dspace-page/my-dspace-new-submission/my-dspace-new-submission.component.spec.ts

@@ -124,5 +124,5 @@ class TestComponent {
 
   reload = (event) => {
     return;
-  }
+  };
 }

src/app/shared/animations/slide.ts

@@ -33,8 +33,7 @@ const options = { params: { sidebarWidth: '*' } };
 export const slideSidebar = trigger('slideSidebar', [
 
   transition('expanded => collapsed',
-    group
-    (
+    group(
       [
         query('@*', animateChild()),
         query('.sidebar-collapsible', expandedStyle, options),
@@ -43,8 +42,7 @@ export const slideSidebar = trigger('slideSidebar', [
     )),
 
   transition('collapsed => expanded',
-    group
-    (
+    group(
       [
         query('@*', animateChild()),
         query('.sidebar-collapsible', collapsedStyle),

src/app/shared/form/builder/ds-dynamic-form-ui/models/lookup/dynamic-lookup.component.ts

@@ -59,7 +59,7 @@ export class DsDynamicLookupComponent extends DsDynamicVocabularyComponent imple
    */
   inputFormatter = (x: { display: string }, y: number) => {
     return y === 1 ? this.firstInputValue : this.secondInputValue;
-  }
+  };
 
   /**
    * Initialize the component, setting up the init form value

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts

@@ -80,7 +80,7 @@ export class DsDynamicOneboxComponent extends DsDynamicVocabularyComponent imple
    */
   formatter = (x: { display: string }) => {
     return (typeof x === 'object') ? x.display : x;
-  }
+  };
 
   /**
    * Converts a stream of text values from the `<input>` element to the stream of the array of items
@@ -116,7 +116,7 @@ export class DsDynamicOneboxComponent extends DsDynamicVocabularyComponent imple
       tap(() => this.changeSearchingStatus(false)),
       merge(this.hideSearchingWhenUnsubscribed$)
     );
-  }
+  };
 
   /**
    * Initialize the component, setting up the init form value

src/app/shared/form/builder/ds-dynamic-form-ui/models/tag/dynamic-tag.component.ts

@@ -90,7 +90,7 @@ export class DsDynamicTagComponent extends DsDynamicVocabularyComponent implemen
       }),
       map((list: PaginatedList<VocabularyEntry>) => list.page),
       tap(() => this.changeSearchingStatus(false)),
-      merge(this.hideSearchingWhenUnsubscribed))
+      merge(this.hideSearchingWhenUnsubscribed));
 
   /**
    * Initialize the component, setting up the init form value

src/app/shared/input-suggestions/input-suggestions.component.ts

@@ -111,10 +111,10 @@ export class InputSuggestionsComponent implements ControlValueAccessor, OnChange
   @Input() disabled = false;
   propagateChange = (_: any) => {
     /* Empty implementation */
-  }
+  };
   propagateTouch = (_: any) => {
     /* Empty implementation */
-  }
+  };
 
   /**
    * When any of the inputs change, check if we should still show the suggestions

src/app/shared/menu/menu.effects.ts

@@ -19,7 +19,6 @@ export class MenuEffects {
   /**
    * On route change, build menu sections for every menu type depending on the current route data
    */
-  
   public buildRouteMenuSections$: Observable<Action> = createEffect(() => this.actions$
     .pipe(
       ofType(ROUTER_NAVIGATED),

src/app/shared/notifications/notification/notification.component.ts

@@ -120,7 +120,7 @@ export class NotificationComponent implements OnInit, OnDestroy {
       }
       this.zone.run(() => this.cdr.detectChanges());
     });
-  }
+  };
 
   public remove() {
     if (this.animate) {

src/app/shared/object-select/object-select.reducer.ts

@@ -35,7 +35,7 @@ export function objectSelectionReducer(state = initialState, action: ObjectSelec
   switch (action.type) {
 
     case ObjectSelectionActionTypes.INITIAL_SELECT: {
-      if (isEmpty(state) || isEmpty(state[action.key]) || isEmpty(state[action.key][action.id])) {
+      if (isEmpty(state) || isEmpty(state[action.key]) || isEmpty(state[action.key][action.id])) {
         return Object.assign({}, state, {
           [action.key]: Object.assign({}, state[action.key], {
             [action.id]: {
@@ -48,7 +48,7 @@ export function objectSelectionReducer(state = initialState, action: ObjectSelec
     }
 
     case ObjectSelectionActionTypes.INITIAL_DESELECT: {
-      if (isEmpty(state) || isEmpty(state[action.key]) || isEmpty(state[action.key][action.id])) {
+      if (isEmpty(state) || isEmpty(state[action.key]) || isEmpty(state[action.key][action.id])) {
         return Object.assign({}, state, {
           [action.key]: Object.assign({}, state[action.key], {
             [action.id]: {

src/app/shared/testing/auth-service.stub.ts

@@ -33,7 +33,7 @@ export class AuthServiceStub {
       return observableOf(authStatus);
     } else {
       console.log('error');
-      throw(new Error('Message Error test'));
+      throw (new Error('Message Error test'));
     }
   }
 
@@ -41,7 +41,7 @@ export class AuthServiceStub {
     if (token.accessToken === 'token_test') {
       return observableOf(EPersonMock._links.self.href);
     } else {
-      throw(new Error('Message Error test'));
+      throw (new Error('Message Error test'));
     }
   }
 

src/app/shared/theme-support/themed.component.ts

@@ -46,7 +46,7 @@ export abstract class ThemedComponent<T> implements OnInit, OnDestroy, OnChanges
     // if an input or output has changed
     if (this.inAndOutputNames.some((name: any) => hasValue(changes[name]))) {
       this.connectInputsAndOutputs();
-      if (this.compRef?.instance && 'ngOnChanges' in this.compRef?.instance) {
+      if (this.compRef?.instance && 'ngOnChanges' in this.compRef.instance) {
         (this.compRef.instance as any).ngOnChanges(changes);
       }
     }

src/app/shared/uploader/uploader.component.spec.ts

@@ -79,7 +79,7 @@ class TestComponent {
 
   /* eslint-disable no-empty,@typescript-eslint/no-empty-function */
   public onBeforeUpload = () => {
-  }
+  };
 
   onCompleteItem(event) {
   }

src/app/shared/vocabulary-treeview/vocabulary-treeview.component.ts

@@ -161,7 +161,7 @@ export class VocabularyTreeviewComponent implements OnDestroy, OnInit {
       this.treeControl.expand(newNode);
     }
     return newNode;
-  }
+  };
 
   /**
    * Get tree level for a given node

src/app/submission/form/submission-upload-files/submission-upload-files.component.ts

@@ -83,7 +83,7 @@ export class SubmissionUploadFilesComponent implements OnChanges {
       .subscribe();
     this.subs.push(sub);
     return sub;
-  }
+  };
 
   /**
    * Initialize instance variables

src/app/submission/objects/submission-objects.effects.ts

@@ -303,7 +303,6 @@ export class SubmissionObjectEffects {
   /**
    * Show a notification on success and redirect to MyDSpace page
    */
-  
   discardSubmissionSuccess$ = createEffect(() => this.actions$.pipe(
     ofType(SubmissionObjectActionTypes.DISCARD_SUBMISSION_SUCCESS),
     tap(() => this.notificationsService.success(null, this.translate.get('submission.sections.general.discard_success_notice'))),

src/config/config.server.ts

@@ -73,7 +73,7 @@ const getLocalConfigPath = (env: Environment) => {
       break;
     case 'development':
     default:
-      envVariations = ['dev', 'development']
+      envVariations = ['dev', 'development'];
   }
 
   // check if any environment variations of app config exist

src/typings.d.ts

@@ -31,14 +31,14 @@ declare module 'modern-lru' {
   export = x;
 }
 
-declare var System: SystemJS;
+declare let System: SystemJS;
 
 interface SystemJS {
   import: (path?: string) => Promise<any>;
 }
 // Extra variables that live on Global that will be replaced by webpack DefinePlugin
-declare var ENV: string;
-declare var HMR: boolean;
+declare let ENV: string;
+declare let HMR: boolean;
 interface GlobalEnvironment {
   ENV;
   HMR;