From 9be8a87a5736286bf3b2f006315fb9fc57ec4fb5 Mon Sep 17 00:00:00 2001
From: Andrea Barbasso <´andrea.barbasso@4science.com´>
Date: Thu, 15 May 2025 10:54:18 +0200
Subject: [PATCH] [DURACOM-309] fix pipeline, remove cookie settings link from
 footer if popup is disabled

---
 src/app/footer/footer.component.html                   | 4 +++-
 src/app/footer/footer.component.spec.ts                | 8 ++++----
 src/app/footer/footer.component.ts                     | 4 +++-
 src/app/shared/cookies/browser-orejime.service.spec.ts | 3 +++
 src/config/default-app-config.ts                       | 1 +
 src/environments/environment.production.ts             | 3 ---
 src/environments/environment.test.ts                   | 1 -
 src/environments/environment.ts                        | 3 ---
 8 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/app/footer/footer.component.html b/src/app/footer/footer.component.html
index 1a995aaf01..57f0cc56b6 100644
--- a/src/app/footer/footer.component.html
+++ b/src/app/footer/footer.component.html
@@ -59,11 +59,13 @@
         href="https://www.lyrasis.org/" role="link" tabindex="0">{{ 'footer.link.lyrasis' | translate}}</a>
       </p>
       <ul class="footer-info list-unstyled d-flex justify-content-center mb-0">
+        @if (showCookieSettings) {
         <li>
-          <button class="btn btn-link text-white" type="button" (click)="showCookieSettings()" role="button" tabindex="0">
+          <button class="btn btn-link text-white" type="button" (click)="openCookieSettings()" role="button" tabindex="0">
             {{ 'footer.link.cookies' | translate}}
           </button>
         </li>
+        }
         @if (showPrivacyPolicy) {
           <li>
             <a class="btn text-white"
diff --git a/src/app/footer/footer.component.spec.ts b/src/app/footer/footer.component.spec.ts
index 527e570364..8096cb9066 100644
--- a/src/app/footer/footer.component.spec.ts
+++ b/src/app/footer/footer.component.spec.ts
@@ -63,21 +63,21 @@ describe('Footer component', () => {
     expect(comp.showEndUserAgreement).toBe(environment.info.enableEndUserAgreement);
   });
 
-  describe('showCookieSettings', () => {
+  describe('openCookieSettings', () => {
     it('should call cookies.showSettings() if cookies is defined', () => {
       const cookies = jasmine.createSpyObj('cookies', ['showSettings']);
       comp.cookies = cookies;
-      comp.showCookieSettings();
+      comp.openCookieSettings();
       expect(cookies.showSettings).toHaveBeenCalled();
     });
 
     it('should not call cookies.showSettings() if cookies is undefined', () => {
       comp.cookies = undefined;
-      expect(() => comp.showCookieSettings()).not.toThrow();
+      expect(() => comp.openCookieSettings()).not.toThrow();
     });
 
     it('should return false', () => {
-      expect(comp.showCookieSettings()).toBeFalse();
+      expect(comp.openCookieSettings()).toBeFalse();
     });
   });
 
diff --git a/src/app/footer/footer.component.ts b/src/app/footer/footer.component.ts
index c691203c02..6beeeb4ece 100644
--- a/src/app/footer/footer.component.ts
+++ b/src/app/footer/footer.component.ts
@@ -39,6 +39,7 @@ export class FooterComponent implements OnInit {
    * A boolean representing if to show or not the top footer container
    */
   showTopFooter = false;
+  showCookieSettings = false;
   showPrivacyPolicy: boolean;
   showEndUserAgreement: boolean;
   showSendFeedback$: Observable<boolean>;
@@ -53,13 +54,14 @@ export class FooterComponent implements OnInit {
   }
 
   ngOnInit(): void {
+    this.showCookieSettings = this.appConfig.info.enableCookieConsentPopup;
     this.showPrivacyPolicy = this.appConfig.info.enablePrivacyStatement;
     this.showEndUserAgreement = this.appConfig.info.enableEndUserAgreement;
     this.coarLdnEnabled$ = this.appConfig.info.enableCOARNotifySupport ? this.notifyInfoService.isCoarConfigEnabled() : observableOf(false);
     this.showSendFeedback$ = this.authorizationService.isAuthorized(FeatureID.CanSendFeedback);
   }
 
-  showCookieSettings() {
+  openCookieSettings() {
     if (hasValue(this.cookies)) {
       this.cookies.showSettings();
     }
diff --git a/src/app/shared/cookies/browser-orejime.service.spec.ts b/src/app/shared/cookies/browser-orejime.service.spec.ts
index 0b11805ccf..ce87591a1d 100644
--- a/src/app/shared/cookies/browser-orejime.service.spec.ts
+++ b/src/app/shared/cookies/browser-orejime.service.spec.ts
@@ -6,6 +6,7 @@ import cloneDeep from 'lodash/cloneDeep';
 import { of as observableOf } from 'rxjs';
 import { TestScheduler } from 'rxjs/testing';
 
+import { environment } from '../../../environments/environment';
 import { AuthService } from '../../core/auth/auth.service';
 import { RestResponse } from '../../core/cache/response.models';
 import { ConfigurationDataService } from '../../core/data/configuration-data.service';
@@ -78,6 +79,8 @@ describe('BrowserOrejimeService', () => {
       },
     });
 
+    environment.info.enableCookieConsentPopup = true;
+
     TestBed.configureTestingModule({
       providers: [
         BrowserOrejimeService,
diff --git a/src/config/default-app-config.ts b/src/config/default-app-config.ts
index 3dbcc8a326..ad54fd3f43 100644
--- a/src/config/default-app-config.ts
+++ b/src/config/default-app-config.ts
@@ -483,6 +483,7 @@ export class DefaultAppConfig implements AppConfig {
     enableEndUserAgreement: true,
     enablePrivacyStatement: true,
     enableCOARNotifySupport: true,
+    enableCookieConsentPopup: true,
   };
 
   // Whether to enable Markdown (https://commonmark.org/) and MathJax (https://www.mathjax.org/)
diff --git a/src/environments/environment.production.ts b/src/environments/environment.production.ts
index ca7d16894e..9bd663922c 100644
--- a/src/environments/environment.production.ts
+++ b/src/environments/environment.production.ts
@@ -14,7 +14,4 @@ export const environment: Partial<BuildConfig> = {
     enableSearchComponent: false,
     enableBrowseComponent: false,
   },
-  info: {
-    enableCookieConsentPopup: true,
-  },
 };
diff --git a/src/environments/environment.test.ts b/src/environments/environment.test.ts
index 2ffd1e83b1..b6348f949d 100644
--- a/src/environments/environment.test.ts
+++ b/src/environments/environment.test.ts
@@ -324,7 +324,6 @@ export const environment: BuildConfig = {
     enableEndUserAgreement: true,
     enablePrivacyStatement: true,
     enableCOARNotifySupport: true,
-    enableCookieConsentPopup: true,
   },
   markdown: {
     enabled: false,
diff --git a/src/environments/environment.ts b/src/environments/environment.ts
index f2f1e6da9a..39ab31de03 100644
--- a/src/environments/environment.ts
+++ b/src/environments/environment.ts
@@ -19,9 +19,6 @@ export const environment: Partial<BuildConfig> = {
     enableSearchComponent: false,
     enableBrowseComponent: false,
   },
-  info: {
-    enableCookieConsentPopup: true,
-  },
 };
 
 /*