hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 10:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use more semantically appropriate elements and explicit names

Browse Source
This commit is contained in:
Adam Doan
2023-05-11 11:50:28 +00:00
parent c914b42de2
commit 9ddd75dbdf
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/app/shared/view-mode-switch/view-mode-switch.component.html
View File

@@ -1,5 +1,5 @@
<div class="btn-group" data-toggle="buttons">
<a *ngIf="isToShow(viewModeEnum.ListElement)"
<button *ngIf="isToShow(viewModeEnum.ListElement)"
routerLink="."
[queryParams]="{view: 'list'}"
queryParamsHandling="merge"
@@ -8,9 +8,9 @@
[class.active]="currentMode === viewModeEnum.ListElement"
class="btn btn-secondary"
[attr.data-test]="'list-view' | dsBrowserOnly">
<i class="fas fa-list" title="{{'search.view-switch.show-list' | translate}}"></i>
</a>
<a *ngIf="isToShow(viewModeEnum.GridElement)"
<span class="fas fa-list"></span><span class="sr-only">{{'search.view-switch.show-list' | translate}}</span>
</button>
<button *ngIf="isToShow(viewModeEnum.GridElement)"
routerLink="."
[queryParams]="{view: 'grid'}"
queryParamsHandling="merge"
@@ -19,9 +19,9 @@
[class.active]="currentMode === viewModeEnum.GridElement"
class="btn btn-secondary"
[attr.data-test]="'grid-view' | dsBrowserOnly">
<i class="fas fa-th-large" title="{{'search.view-switch.show-grid' | translate}}"></i>
</a>
<a *ngIf="isToShow(viewModeEnum.DetailedListElement)"
<span class="fas fa-th-large"></span><span class="sr-only">{{'search.view-switch.show-grid' | translate}}</span>
</button>
<button *ngIf="isToShow(viewModeEnum.DetailedListElement)"
routerLink="."
[queryParams]="{view: 'detailed'}"
queryParamsHandling="merge"
@@ -30,6 +30,6 @@
[class.active]="currentMode === viewModeEnum.DetailedListElement"
class="btn btn-secondary"
[attr.data-test]="'detail-view' | dsBrowserOnly">
<i class="far fa-square" title="{{'search.view-switch.show-detail' | translate}}"></i>
</a>
<span class="far fa-square"></span><span class="sr-only">{{'search.view-switch.show-detail' | translate}}</span>
</button>
</div>